Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor APB package to have a public exposed API and internal API that handles shared behavior #501

Closed
shawn-hurley opened this issue Oct 17, 2017 · 1 comment
Labels
3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 feature

Comments

@shawn-hurley
Copy link
Contributor

Right now bind/unbind/provision/update/deprovsion will all have some similar logic that is not being captured. examples are checking if the namespace exists, checking if the spec has an image, executing the APB cleaning up the sandbox. Some of them (provision/bind) will have to extract the credentials.

I think that this is tied to #248 and we should also think about this from unit testing of callers standpoint (make it easily overridable so that the broker can be unit tested properly).

@rthallisey
Copy link
Contributor

We're going to create a new issue after an in depth vendoring discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 feature
Projects
None yet
Development

No branches or pull requests

2 participants