DAO & Mock Registry #7
Conversation
eriknelson
commented
Jan 26, 2017
eriknelson
commented
- Implemented some basic dao features for talking with etcd
- Filled out a mock-registry as a separate binary so we have something to pull data from in a real way.
* DevRegistry implementation
| r.config = config | ||
| fmt.Printf("DevRegistry::Init with url -> [ %s ] \n", r.config.Url) | ||
| r.log = log | ||
| return nil |
There was a problem hiding this comment.
Why return anything if we're just going to return nil?
There was a problem hiding this comment.
Won't compile without it
There was a problem hiding this comment.
I expect real registries to be doing more interesting things with failure possibility; this guys just kind of a test stub for us for now.
There was a problem hiding this comment.
Oh I get it now. The interface signature requires an error for REAL registries. For the dev one we don't care. Ok I forgot about that. +1
|
|
||
| return reg | ||
| return reg, err |
| return nil | ||
| func (r *RHCCRegistry) LoadApps() ([]*Spec, error) { | ||
| r.log.Debug("RHCCRegistry::LoadApps") | ||
| return []*Spec{}, nil | ||
| } |
There was a problem hiding this comment.
I do like the pluggable registry mechanism.
| fmt.Println("============================================================") | ||
| fmt.Println("== Starting Ansible Service Broker... ==") | ||
| fmt.Println("============================================================") | ||
|
|
| return app | ||
| } | ||
|
|
||
| func (a *App) Start() { | ||
| a.log.Info("Starting application") | ||
| a.log.Notice("Ansible Service Broker Started") | ||
| a.registry.LoadApps() |
There was a problem hiding this comment.
Good catch; I actually should remove this line for this PR. I'm picturing this start method being the one responsibly for starting the http mux listener. That will call into methods like broker.Bootstrap() (not written yet), which in turn, will be the guy that calls registry.LoadApps().
So the full story has yet to be written here. This PR should be a lot of support without action in Start(). I'll try to make a note of this in //TODOs to explain myself a little better inline.
| // Key generators | ||
| //////////////////////////////////////////////////////////// | ||
| func specKey(id string) string { | ||
| return fmt.Sprintf("/spec/%s", id) |
* Remove `LoadApps` call from App::Start. It doesn't belong there and got committed as part of testing. * Renamed `LoadApps` to `LoadSpecs` since it's more accurate
|
ACK |
* Add etcd client deps * Initial checkin of dao spec ops * Add mock-registry * Start loading Specs from the mock registry * DevRegistry implementation * Updates based on feedback * Remove `LoadApps` call from App::Start. It doesn't belong there and got committed as part of testing. * Renamed `LoadApps` to `LoadSpecs` since it's more accurate
…ft#54) * moves the methods for extracting credentials to runtime package * adds tests for extract credentials. This is better set up to be overriden in the future. This PR does not allow for the ExtractCredentials to be overridden.
