Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use commonlib.buildURL #1938

Merged
merged 2 commits into from Sep 16, 2019
Merged

Use commonlib.buildURL #1938

merged 2 commits into from Sep 16, 2019

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Aug 30, 2019

And correct a widespread typo

@joepvd
Use commonlib.buildURL
7742821 
And correct a widespread typo
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2019
@tbielawa
Copy link
Contributor

@joepvd Somebody else maintains the alderan files. We shouldn't be changing those, even if they are just tyop fixes. Your other fixes though, like under jobs and pipeline-scripts and scheduled-jobs are good!

We need to fix this up in the future by having our own repo instead of sharing one.

@sosiouxme
Copy link
Contributor

LGTM now please merge monday when we're around to notice failures (not that any are expected).

@tbielawa tbielawa merged commit 97967b9 into openshift-eng:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joepvd @tbielawa @sosiouxme @openshift-ci-robot