GRPA-2847: Copy AMI for ROSA during RHCOS sync #2478
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
LorbusChris
force-pushed
the
rosa-ami-sync
branch
from
7a4df65
to
21b6675
Compare
|
@ashcrow @jharrington22 PTAL |
LorbusChris
force-pushed
the
rosa-ami-sync
branch
from
21b6675
to
0b8a8d5
Compare
| @@ -22,5 +22,6 @@ RUN yum install -y \ | |||
| rhpkg \ | |||
| && yum clean all | |||
|
|
|||
| RUN pip3 install -U koji tox twine requests>=2.20 setuptools wheel codecov rh-doozer rh-elliott rh-ocp-build-data-validator | |||
| # TODO: Clarify: Is this the image used to run rhcos_sync in prod? | |||
There was a problem hiding this comment.
Will lift the hold on this PR once this question is addressed.
There was a problem hiding this comment.
Specifically your asking if the image created here gets used as the jenkins worker, correct?
There was a problem hiding this comment.
I've ping'd ART folks asking if they can confirm.
There was a problem hiding this comment.
@LorbusChris based on the response from ART are we OK with moving this forward?
There was a problem hiding this comment.
@ashcrow this is blocked on https://issues.redhat.com/browse/ART-2597
There was a problem hiding this comment.
cc'ing @thegreyd who's assigned to it :) I guess installing awscli in this Dockerfile isn't strictly required for now - should I remove it or leave it here?
There was a problem hiding this comment.
Hey @LorbusChris 👋 I think you can leave this out and instead add the dependency in the initialize func in the build.groovy file for the job commonlib.shell(script: "pip install awscli"), each of our job runs in a venv. Also version lock it if needed.
There was a problem hiding this comment.
🎉 thank you @thegreyd! Updated, PTAL :)
LorbusChris
force-pushed
the
rosa-ami-sync
branch
2 times, most recently
from
a9a252f
to
5a8d8ae
Compare
LorbusChris
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
LorbusChris
force-pushed
the
rosa-ami-sync
branch
from
5a8d8ae
to
9d2b786
Compare
|
thank you @sosiouxme :) |
|
/lgtm |
|
@sosiouxme Looks like this requires an ART member to merge. |
| DRY_RUN_FLAG="--dry-run" | ||
| fi | ||
|
|
||
| ami=$(jq -r "[.amis[]|select(.name==\"us-east-1\")][0].hvm" "${META_JSON_PATH}") |
There was a problem hiding this comment.
this should be jq -r "[.amis[\"us-east-1\"].hvm][0]" ... based on my testing with the latest rhcos.json file here: https://github.com/openshift/installer/blob/master/data/data/rhcos.json
There was a problem hiding this comment.
When running manually, the input for this shouldn't be an installer rhcos.json!
In Jenkins, the URL to a meta.json file like this is passed to the job: https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.6/46.82.202101131942-0/x86_64/meta.json (browser at https://releases-rhcos-art.cloud.privileged.psi.redhat.com/)
It's downloaded by the job and that path is later passed to rosa_sync.sh - so when running manually, a meta.json must be referenced.
The meta.json may contain multiple amis for one single region, which is why I used the select pipe here.
There was a problem hiding this comment.
I've tested this script only with a manual dry run with a meta.json -- could you confirm that works as intended for you?
There was a problem hiding this comment.
We need @jharrington22 to weigh in here as I've been instructed to use the rhcos.json file instead to manually copy to the stage/prod rosa accounts.
@jharrington22 - meta.json and rhcos.json are in different formats, what file do we want to use for the sync?
There was a problem hiding this comment.
@LorbusChris - I've confirmed it works with a meta.json manually and the script copied the latest ami to the production rosa account.
The meta.json used: https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.6/46.82.202101150340-0/x86_64/meta.json
There was a problem hiding this comment.
thank you @dustman9000 for the confirmation, and my apologies to all involved for not raising awareness of the differences of formats here before.
The intended goal for this PR is to copy the AMI for each bootimage release over to ROSA.
It was decided that this pipeline (which updates the download links on the mirrors) is the best place to put it, since not all z-stream releases get a boot imagebump, but this particular pipeline is run for each bootimage that does get released. It's triggered manually by someone from ART who has a reference to the exact build (it receives a particular build's meta.json as input).
The rhcos.json in the installer repo is also derivative of a build's meta.json and one should be able to backtrace it to its integral (https://github.com/openshift/installer/blob/master/hack/update-rhcos-bootimage.py#L2).
|
Bump :-) |
|
FYI to ARTists, |
No description provided.