Create only candidate PR #2671
Merged
Create only candidate PR #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR openshift/cincinnati-graph-data#841 should take care of the rest ;D
|
cc @wking |
|
more context for reviewers of this PR: https://coreos.slack.com/archives/CJARLA942/p1624599157134600?thread_ts=1624598725.134500&cid=CJARLA942 |
|
/lgtm |
wking
added a commit
to wking/aos-cd-jobs
that referenced
this pull request
Dec 8, 2021
Since 936c878 (Create only candidate PR, 2021-06-25, openshift-eng#2671), fast and later promotion has been managed by the graph-data stabilization robot. Instead of asking the user to set this property, just inspect the requested release name to determine if it's a prerelease (which won't want an errata link) or not (where we'll now return to requiring an errata link).
sosiouxme
added a commit
that referenced
this pull request
Dec 9, 2021
* jobs/build/cincinnati-prs: Drop CANDIDATE_CHANNEL_ONLY Since 936c878 (Create only candidate PR, 2021-06-25, #2671), fast and later promotion has been managed by the graph-data stabilization robot. Instead of asking the user to set this property, just inspect the requested release name to determine if it's a prerelease (which won't want an errata link) or not (where we'll now return to requiring an errata link). * release.groovy: remove 4.1 cruft Co-authored-by: Luke Meyer <lmeyer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR openshift/cincinnati-graph-data#841 should take care of the rest ;D