-
Notifications
You must be signed in to change notification settings - Fork 143
/
policy.go
392 lines (323 loc) · 12.1 KB
/
policy.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
/*
Copyright 2019 The OpenShift Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package actuator
import (
"fmt"
log "github.com/sirupsen/logrus"
"google.golang.org/api/cloudresourcemanager/v1"
"google.golang.org/api/iam/v1"
iamadminpb "google.golang.org/genproto/googleapis/iam/admin/v1"
ccgcp "github.com/openshift/cloud-credential-operator/pkg/gcp"
)
// EnsurePolicyBindingsForProject ensures that given roles and member, appropriate binding is added to project
func EnsurePolicyBindingsForProject(rootClient ccgcp.Client, roles []string, member string) error {
needPolicyUpdate := false
projectName := rootClient.GetProjectName()
policy, err := rootClient.GetProjectIamPolicy(projectName, &cloudresourcemanager.GetIamPolicyRequest{})
if err != nil {
return fmt.Errorf("error fetching policy for project: %v", err)
}
// Validate that each role exists, and add the policy binding as needed
for _, definedRole := range roles {
// Earlier we've verified that the requested roles already exist.
// Add policy binding
modified := addPolicyBindingForProject(policy, definedRole, member)
if modified {
needPolicyUpdate = true
}
}
// Remove extra role bindings as needed
modified := purgeExtraPolicyBindingsForProject(policy, roles, member)
if modified {
needPolicyUpdate = true
}
if needPolicyUpdate {
if rootClient == nil {
return fmt.Errorf("detected need for policy update, but no root creds available")
}
return setProjectIamPolicy(rootClient, policy, projectName)
}
// If we made it this far there were no updates needed
return nil
}
// EnsurePolicyBindingsForServiceAccount ensures that given roles and member, appropriate binding is added to IAM service account
func EnsurePolicyBindingsForServiceAccount(rootClient ccgcp.Client, svcAcct *iamadminpb.ServiceAccount, roles []string, member string) error {
needPolicyUpdate := false
projectName := rootClient.GetProjectName()
svcAcctResource := fmt.Sprintf("projects/%s/serviceAccounts/%s", projectName, svcAcct.Email)
policy, err := rootClient.GetServiceAccountIamPolicy(svcAcctResource)
if err != nil {
return fmt.Errorf("error fetching policy for service account: %v", err)
}
// Validate that each role exists, and add the policy binding as needed
for _, definedRole := range roles {
// Earlier we've verified that the requested roles already exist.
// Add policy binding
modified := addPolicyBindingForServiceAccount(policy, definedRole, member)
if modified {
needPolicyUpdate = true
}
}
// Remove extra role bindings as needed
modified := purgeExtraPolicyBindingsForServiceAccount(policy, roles, member)
if modified {
needPolicyUpdate = true
}
if needPolicyUpdate {
if rootClient == nil {
return fmt.Errorf("detected need for policy update, but no root creds available")
}
return setServiceAccountIamPolicy(rootClient, policy, svcAcctResource)
}
// If we made it this far there were no updates needed
return nil
}
func purgeExtraPolicyBindingsForProject(policy *cloudresourcemanager.Policy, roleList []string, memberName string) bool {
modifiedPolicy := false
for _, binding := range policy.Bindings {
// find if given member has an entry in this binding
for j, member := range binding.Members {
if member == memberName {
removeMember := true
// check if this role is one that should be bound to this project's roleList
for _, role := range roleList {
if role == binding.Role {
removeMember = false
break
}
}
if removeMember {
// It is okay to submit a policy with a binding entry where the member list
// is empty. The policy will be cleaned up on the GCP-side and it will be
// as if we had removed the entire binding entry.
binding.Members = append(binding.Members[:j], binding.Members[j+1:]...)
modifiedPolicy = true
}
}
}
}
return modifiedPolicy
}
func purgeExtraPolicyBindingsForServiceAccount(policy *iam.Policy, roleList []string, memberName string) bool {
modifiedPolicy := false
for _, binding := range policy.Bindings {
// find if our member has an entry in this binding
for j, member := range binding.Members {
if member == memberName {
removeMember := true
// check if this role is one that should be bound to this service account's roleList
for _, role := range roleList {
if role == binding.Role {
removeMember = false
break
}
}
if removeMember {
// It is okay to submit a policy with a binding entry where the member list
// is empty. The policy will be cleaned up on the GCP-side and it will be
// as if we had removed the entire binding entry.
binding.Members = append(binding.Members[:j], binding.Members[j+1:]...)
modifiedPolicy = true
}
}
}
}
return modifiedPolicy
}
func addPolicyBindingForProject(policy *cloudresourcemanager.Policy, roleName, memberName string) bool {
for i, binding := range policy.Bindings {
if binding.Role == roleName {
return addMemberToBindingForProject(memberName, policy.Bindings[i])
}
}
// if we didn't find an existing binding entry, then make one
createMemberRoleBindingForProject(policy, roleName, memberName)
return true
}
func addPolicyBindingForServiceAccount(policy *iam.Policy, roleName, memberName string) bool {
for i, binding := range policy.Bindings {
if binding.Role == roleName {
return addMemberToBindingForServiceAccount(memberName, policy.Bindings[i])
}
}
// if we didn't find an existing binding entry, then make one
createMemberRoleBindingForServiceAccount(policy, roleName, memberName)
return true
}
func createMemberRoleBindingForProject(policy *cloudresourcemanager.Policy, roleName, memberName string) {
policy.Bindings = append(policy.Bindings, &cloudresourcemanager.Binding{
Members: []string{memberName},
Role: roleName,
})
}
func createMemberRoleBindingForServiceAccount(policy *iam.Policy, roleName, memberName string) {
policy.Bindings = append(policy.Bindings, &iam.Binding{
Members: []string{memberName},
Role: roleName,
})
}
// adds member to existing binding. returns bool indicating if an entry was made
func addMemberToBindingForProject(memberName string, binding *cloudresourcemanager.Binding) bool {
for _, member := range binding.Members {
if member == memberName {
// already present
return false
}
}
binding.Members = append(binding.Members, memberName)
return true
}
// adds member to existing binding. returns bool indicating if an entry was made
func addMemberToBindingForServiceAccount(memberName string, binding *iam.Binding) bool {
for _, member := range binding.Members {
if member == memberName {
// already present
return false
}
}
binding.Members = append(binding.Members, memberName)
return true
}
func serviceAccountNeedsPermissionsUpdate(gcpClient ccgcp.Client, serviceAccountID, roleID string, predefinedRoles, permissions []string) (bool, error) {
projectName := gcpClient.GetProjectName()
svcAcct, err := GetServiceAccount(gcpClient, serviceAccountID)
if err != nil {
return true, fmt.Errorf("error fetching service account details: %v", err)
}
svcAcctBindingName := ServiceAccountBindingName(svcAcct)
policy, err := gcpClient.GetProjectIamPolicy(projectName, &cloudresourcemanager.GetIamPolicyRequest{})
if err != nil {
return true, fmt.Errorf("error fetching current project iam policy: %v", err)
}
// check do we have bindings for everything in the credentialsRequest
for _, roleName := range predefinedRoles {
foundRole := false
for _, binding := range policy.Bindings {
if binding.Role == roleName {
foundRole = true
if !isServiceAccountInBinding(svcAcctBindingName, binding) {
log.Debugf("service account %s is missing role: %s", svcAcctBindingName, roleName)
return true, nil
}
}
}
if !foundRole {
// we have a role being requested that we don't have a policy binding for
log.Debugf("no binding found for role: %s", roleName)
return true, nil
}
}
// if permissions are specified check if binding exists for custom role and if custom role has all the permissions
var customRole string
if len(permissions) > 0 {
foundCustomRole := false
customRole = fmt.Sprintf("projects/%s/roles/%s", projectName, roleID)
for _, binding := range policy.Bindings {
if binding.Role == customRole {
foundCustomRole = true
if !isServiceAccountInBinding(svcAcctBindingName, binding) {
log.Debugf("service account %s is missing role: %s", svcAcctBindingName, customRole)
return true, nil
}
}
}
if !foundCustomRole {
// permissions are specified but we do not have any policy binding for the custom role
log.Debugf("no binding found for role: %s", customRole)
return true, nil
}
role, err := GetRole(gcpClient, roleID, projectName)
if err != nil {
return true, fmt.Errorf("error fetching custom role: %v", err)
}
// custom roles should not be in the deleted state
if role.Deleted {
log.Debugf("custom role should not be deleted: %s", customRole)
return true, nil
}
addedPermissions, _ := CalculateSliceDiff(role.IncludedPermissions, permissions)
if len(addedPermissions) > 0 {
log.Debug("cutom role is missing permissions")
return true, nil
}
}
// check whether we have extra policy bindings
for _, binding := range policy.Bindings {
if isServiceAccountInBinding(svcAcctBindingName, binding) {
extraRoleDetected := true
for _, roleName := range predefinedRoles {
if roleName == binding.Role {
extraRoleDetected = false
break
}
}
if extraRoleDetected && binding.Role != customRole {
log.Debugf("extra role detected for %s: %s", svcAcctBindingName, binding.Role)
return true, nil
}
}
}
// if we made it this far, then the existing policy bindings don't need changing
return false, nil
}
// RemovePolicyBindingsForProject ensures that given member, all the associated bindings for that member are removed
// from the project policy
func RemovePolicyBindingsForProject(gcpClient ccgcp.Client, memberName string) error {
projectName := gcpClient.GetProjectName()
policy, err := gcpClient.GetProjectIamPolicy(projectName, &cloudresourcemanager.GetIamPolicyRequest{})
if err != nil {
return fmt.Errorf("error retrieving current policy: %v", err)
}
for _, binding := range policy.Bindings {
for j, member := range binding.Members {
if member == memberName {
// It is okay to submit a policy with a binding entry where the member list
// is empty. The policy will be cleaned up on the GCP-side and it will be
// as if we had removed the entire binding entry.
binding.Members = append(binding.Members[:j], binding.Members[j+1:]...)
}
}
}
if err := setProjectIamPolicy(gcpClient, policy, projectName); err != nil {
return fmt.Errorf("error updating policy: %v", err)
}
return nil
}
func setProjectIamPolicy(gcpClient ccgcp.Client, policy *cloudresourcemanager.Policy, projectName string) error {
policyRequest := &cloudresourcemanager.SetIamPolicyRequest{
Policy: policy,
}
_, err := gcpClient.SetProjectIamPolicy(projectName, policyRequest)
if err != nil {
return fmt.Errorf("error setting project policy: %v", err)
}
return nil
}
func setServiceAccountIamPolicy(gcpClient ccgcp.Client, policy *iam.Policy, svcAcctResource string) error {
policyRequest := &iam.SetIamPolicyRequest{
Policy: policy,
}
_, err := gcpClient.SetServiceAccountIamPolicy(svcAcctResource, policyRequest)
if err != nil {
return fmt.Errorf("error setting service account policy: %v", err)
}
return nil
}
func isServiceAccountInBinding(svcAcctBindingName string, binding *cloudresourcemanager.Binding) bool {
for _, member := range binding.Members {
if member == svcAcctBindingName {
return true
}
}
return false
}