GCP: Make the sentence "Enter 2 empty lines to finish" less confusing && add option to specify the Service Account file.

[vlours]

As a no-English first language speaker, I’ve understood the sentence "[Enter 2 empty lines to finish]" as something:

Enter 2 empty lines to “cancel”

So it will be better to use a strong word (or much better avoid to hit enter twice ?) to Confirm

Press Enter two additional times to confirm your choice

# grep -n -A2 -B2 "Enter 2 empty lines to finish" cloud-credential-operator/vendor/github.com/AlecAivazis/survey/v2/multiline.go
33-{{- else }}
34-  {{- if .Default}}{{color "white"}}({{.Default}}) {{color "reset"}}{{end}}
35:  {{- color "cyan"}}[Enter 2 empty lines to finish]{{color "reset"}}
36-{{- end}}`
37-

This will have less confusion here:

33-{{- else }}
34-  {{- if .Default}}{{color "white"}}({{.Default}}) {{color "reset"}}{{end}}
35:  {{- color "cyan"}}[Press Enter two additional times to confirm your choice]{{color "reset"}}
36-{{- end}}`
37-

Another way to avoid this will be to allow to pass the GCP service account JSON file with an option like --gcp-sa-json

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[vlours]

I've created another Issue with the Owner of the multiline.go file: AlecAivazis/survey#419 to address the first part of this issue (the confusing double empty line).

But that will be awesome if the ccoctl command will have an option to pass the Service Account directly, such as: --sa-json <Service_Account_full_PATH.json>

[2uasimojo]

Hi @vlours. Sorry for the delay here -- we tend to pay attention to Jira rather than issues. It would be great if you could open this as a new Story in the CCO-* project. Thanks!

/cc @akhil-rane

[vlours]

Thanks @2uasimojo.

I've created a Story in Jira as suggested:
CCO-224 - [RFE] addoitional option for ccoctl to allow Service Account in GCP

Feel free to close this Issue if no longer relevant.

Cheers,

[2uasimojo]

Thanks @vlours. Closing in favor of CCO-224.