-
Notifications
You must be signed in to change notification settings - Fork 82
/
dns_status.go
314 lines (287 loc) · 14.5 KB
/
dns_status.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
package controller
import (
"context"
"fmt"
"reflect"
"strings"
"time"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/sirupsen/logrus"
operatorv1 "github.com/openshift/api/operator/v1"
appsv1 "k8s.io/api/apps/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
)
// syncDNSStatus computes the current status of dns and
// updates status upon any changes since last sync.
// If the elapsed time between time.Now() and
// oldCondition.LastTransitionTime is <= transitionUnchangedToleration
// for progressing and degraded then consider oldCondition to be recent
// and return oldCondition to prevent frequent updates.
func (r *reconciler) syncDNSStatus(dns *operatorv1.DNS, clusterIP, clusterDomain string, haveDNSDaemonset bool, dnsDaemonset *appsv1.DaemonSet, haveNodeResolverDaemonset bool, nodeResolverDaemonset *appsv1.DaemonSet, transitionUnchangedToleration time.Duration, reconcileResult *reconcile.Result) error {
updated := dns.DeepCopy()
updated.Status.ClusterIP = clusterIP
updated.Status.ClusterDomain = clusterDomain
updated.Status.Conditions = computeDNSStatusConditions(dns, clusterIP, haveDNSDaemonset, dnsDaemonset, haveNodeResolverDaemonset, nodeResolverDaemonset, transitionUnchangedToleration, reconcileResult)
if !dnsStatusesEqual(updated.Status, dns.Status) {
if err := r.client.Status().Update(context.TODO(), updated); err != nil {
return fmt.Errorf("failed to update dns status: %v", err)
}
logrus.Infof("updated DNS %s status: old: %#v, new: %#v", dns.ObjectMeta.Name, dns.Status, updated.Status)
}
return nil
}
// computeDNSStatusConditions computes dns status conditions based on
// the status of the dns and node-resolver daemonsets and clusterIP.
// If the elapsed time between time.Now() and
// oldCondition.LastTransitionTime is <= transitionUnchangedToleration
// for progressing and degraded then consider oldCondition to be recent
// and return oldCondition to prevent frequent updates.
func computeDNSStatusConditions(dns *operatorv1.DNS, clusterIP string, haveDNSDaemonset bool, dnsDaemonset *appsv1.DaemonSet, haveNodeResolverDaemonset bool, nodeResolverDaemonset *appsv1.DaemonSet, transitionUnchangedToleration time.Duration, reconcileResult *reconcile.Result) []operatorv1.OperatorCondition {
oldConditions := dns.Status.Conditions
var oldDegradedCondition, oldProgressingCondition, oldAvailableCondition, oldUpgradeableCondition *operatorv1.OperatorCondition
for i := range oldConditions {
switch oldConditions[i].Type {
case operatorv1.OperatorStatusTypeDegraded:
oldDegradedCondition = &oldConditions[i]
case operatorv1.OperatorStatusTypeProgressing:
oldProgressingCondition = &oldConditions[i]
case operatorv1.OperatorStatusTypeAvailable:
oldAvailableCondition = &oldConditions[i]
case operatorv1.OperatorStatusTypeUpgradeable:
oldUpgradeableCondition = &oldConditions[i]
}
}
now := time.Now()
conditions := []operatorv1.OperatorCondition{
computeDNSDegradedCondition(oldDegradedCondition, clusterIP, haveDNSDaemonset, dnsDaemonset, transitionUnchangedToleration, now),
computeDNSProgressingCondition(oldProgressingCondition, dns, clusterIP, haveDNSDaemonset, dnsDaemonset, haveNodeResolverDaemonset, nodeResolverDaemonset, transitionUnchangedToleration, now, reconcileResult),
computeDNSAvailableCondition(oldAvailableCondition, clusterIP, haveDNSDaemonset, dnsDaemonset),
computeDNSUpgradeableCondition(oldUpgradeableCondition, dns),
}
return conditions
}
// computeDNSDegradedCondition computes the dns Degraded status
// condition based on the status of clusterIP and the DNS daemonset.
// The node-resolver daemonset is not a part of the calculation of
// degraded condition. If the elapsed time between currentTime and
// oldCondition.LastTransitionTime is <= transitionUnchangedToleration
// then consider oldCondition to be recent and return oldCondition to
// prevent frequent updates.
func computeDNSDegradedCondition(oldCondition *operatorv1.OperatorCondition, clusterIP string, haveDNSDaemonset bool, dnsDaemonset *appsv1.DaemonSet, transitionUnchangedToleration time.Duration, currentTime time.Time) operatorv1.OperatorCondition {
degradedCondition := &operatorv1.OperatorCondition{
Type: operatorv1.OperatorStatusTypeDegraded,
}
status := operatorv1.ConditionUnknown
degradedReasons := []string{}
messages := []string{}
if len(clusterIP) == 0 {
status = operatorv1.ConditionTrue
degradedReasons = append(degradedReasons, "NoService")
messages = append(messages, "No IP address is assigned to the DNS service.")
}
if !haveDNSDaemonset {
status = operatorv1.ConditionTrue
degradedReasons = append(degradedReasons, "NoDNSDaemonSet")
messages = append(messages, "The DNS daemonset does not exist.")
} else {
want := dnsDaemonset.Status.DesiredNumberScheduled
have := dnsDaemonset.Status.NumberAvailable
numberUnavailable := want - have
maxUnavailableIntStr := intstr.FromInt(1)
if dnsDaemonset.Spec.UpdateStrategy.RollingUpdate != nil && dnsDaemonset.Spec.UpdateStrategy.RollingUpdate.MaxUnavailable != nil {
maxUnavailableIntStr = *dnsDaemonset.Spec.UpdateStrategy.RollingUpdate.MaxUnavailable
}
maxUnavailable, intstrErr := intstr.GetScaledValueFromIntOrPercent(&maxUnavailableIntStr, int(want), true)
switch {
case want == 0:
status = operatorv1.ConditionTrue
degradedReasons = append(degradedReasons, "NoDNSPodsDesired")
messages = append(messages, "No DNS pods are desired; this could mean all nodes are tainted or unschedulable.")
case have == 0:
status = operatorv1.ConditionTrue
degradedReasons = append(degradedReasons, "NoDNSPodsAvailable")
messages = append(messages, "No DNS pods are available.")
case intstrErr != nil:
degradedReasons = append(degradedReasons, "InvalidDNSMaxUnavailable")
messages = append(messages, fmt.Sprintf("The DNS daemonset has an invalid MaxUnavailable value: %v", intstrErr))
case int(numberUnavailable) > maxUnavailable:
status = operatorv1.ConditionTrue
degradedReasons = append(degradedReasons, "MaxUnavailableDNSPodsExceeded")
messages = append(messages, fmt.Sprintf("Too many DNS pods are unavailable (%d > %d max unavailable).", numberUnavailable, maxUnavailable))
}
}
if len(degradedReasons) != 0 {
// if the last status was set to false within the last transitionUnchangedToleration, skip the new update
// to prevent frequent status flaps, and try to keep the long-lasting state (i.e. Degraded=False). See https://bugzilla.redhat.com/show_bug.cgi?id=2037190.
if oldCondition != nil && oldCondition.Status == operatorv1.ConditionFalse && lastTransitionTimeIsRecent(currentTime, oldCondition.LastTransitionTime.Time, transitionUnchangedToleration) {
return *oldCondition
}
degradedCondition.Status = status
degradedCondition.Reason = strings.Join(degradedReasons, "")
degradedCondition.Message = strings.Join(messages, "\n")
} else {
degradedCondition.Status = operatorv1.ConditionFalse
degradedCondition.Reason = "AsExpected"
degradedCondition.Message = "Enough DNS pods are available, and the DNS service has a cluster IP address."
}
return setDNSLastTransitionTime(degradedCondition, oldCondition)
}
// computeDNSProgressingCondition computes the dns Progressing status
// condition based on the status of the DNS and node-resolver
// daemonsets. If the elapsed time between currentTime and
// oldCondition.LastTransitionTime is <= transitionUnchangedToleration then
// consider oldCondition to be recent and return oldCondition to
// prevent frequent updates.
func computeDNSProgressingCondition(oldCondition *operatorv1.OperatorCondition, dns *operatorv1.DNS, clusterIP string, haveDNSDaemonset bool, dnsDaemonset *appsv1.DaemonSet, haveNodeResolverDaemonset bool, nodeResolverDaemonset *appsv1.DaemonSet, transitionUnchangedToleration time.Duration, currentTime time.Time, reconcileResult *reconcile.Result) operatorv1.OperatorCondition {
progressingCondition := &operatorv1.OperatorCondition{
Type: operatorv1.OperatorStatusTypeProgressing,
}
messages := []string{}
if len(clusterIP) == 0 {
messages = append(messages, "No IP address is assigned to the DNS service.")
}
if !haveDNSDaemonset {
messages = append(messages, "The DNS daemonset does not exist.")
} else {
have := dnsDaemonset.Status.NumberAvailable
want := dnsDaemonset.Status.DesiredNumberScheduled
if have != want {
messages = append(messages, fmt.Sprintf("Have %d available DNS pods, want %d.", have, want))
}
have = dnsDaemonset.Status.UpdatedNumberScheduled
want = dnsDaemonset.Status.DesiredNumberScheduled
if have != want {
messages = append(messages, fmt.Sprintf("Have %d up-to-date DNS pods, want %d.", have, want))
}
haveSelector := dnsDaemonset.Spec.Template.Spec.NodeSelector
wantSelector := nodeSelectorForDNS(dns)
if !reflect.DeepEqual(haveSelector, wantSelector) {
messages = append(messages, fmt.Sprintf("Have DNS daemonset with node selector %+v, want %+v.", haveSelector, wantSelector))
}
haveTolerations := dnsDaemonset.Spec.Template.Spec.Tolerations
wantTolerations := tolerationsForDNS(dns)
if !reflect.DeepEqual(haveTolerations, wantTolerations) {
messages = append(messages, fmt.Sprintf("Have DNS daemonset with tolerations %+v, want %+v.", haveTolerations, wantTolerations))
}
}
if !haveNodeResolverDaemonset {
messages = append(messages, "The node-resolver daemonset does not exist.")
} else {
have := nodeResolverDaemonset.Status.NumberAvailable
want := nodeResolverDaemonset.Status.DesiredNumberScheduled
if have != want {
messages = append(messages, fmt.Sprintf("Have %d available node-resolver pods, want %d.", have, want))
}
}
if len(messages) != 0 {
// if the last status was set to false within the last transitionUnchangedToleration, skip the new update
// to prevent frequent status flaps, and try to keep the long-lasting state (i.e. Progressing=False). See https://bugzilla.redhat.com/show_bug.cgi?id=2037190.
if oldCondition != nil && oldCondition.Status == operatorv1.ConditionFalse && lastTransitionTimeIsRecent(currentTime, oldCondition.LastTransitionTime.Time, transitionUnchangedToleration) {
reconcileResult.Requeue = true
reconcileResult.RequeueAfter = transitionUnchangedToleration
return *oldCondition
}
progressingCondition.Status = operatorv1.ConditionTrue
progressingCondition.Reason = "Reconciling"
progressingCondition.Message = strings.Join(messages, "\n")
} else {
progressingCondition.Status = operatorv1.ConditionFalse
progressingCondition.Reason = "AsExpected"
progressingCondition.Message = "All DNS and node-resolver pods are available, and the DNS service has a cluster IP address."
}
return setDNSLastTransitionTime(progressingCondition, oldCondition)
}
// computeDNSAvailableCondition computes the dns Available status condition
// based on the status of clusterIP and the DNS daemonset.
func computeDNSAvailableCondition(oldCondition *operatorv1.OperatorCondition, clusterIP string, haveDNSDaemonset bool, dnsDaemonset *appsv1.DaemonSet) operatorv1.OperatorCondition {
availableCondition := &operatorv1.OperatorCondition{
Type: operatorv1.OperatorStatusTypeAvailable,
}
unavailableReasons := []string{}
messages := []string{}
if !haveDNSDaemonset {
unavailableReasons = append(unavailableReasons, "NoDaemonSet")
messages = append(messages, "The DNS daemonset does not exist.")
} else if dnsDaemonset.Status.NumberAvailable == 0 {
unavailableReasons = append(unavailableReasons, "NoDaemonSetPods")
messages = append(messages, "The DNS daemonset has no pods available.")
}
if len(clusterIP) == 0 {
unavailableReasons = append(unavailableReasons, "NoService")
messages = append(messages, "No IP address is assigned to the DNS service.")
}
if len(unavailableReasons) != 0 {
availableCondition.Status = operatorv1.ConditionFalse
availableCondition.Reason = strings.Join(unavailableReasons, "")
availableCondition.Message = strings.Join(messages, "\n")
} else {
availableCondition.Status = operatorv1.ConditionTrue
availableCondition.Reason = "AsExpected"
availableCondition.Message = "The DNS daemonset has available pods, and the DNS service has a cluster IP address."
}
return setDNSLastTransitionTime(availableCondition, oldCondition)
}
func computeDNSUpgradeableCondition(oldCondition *operatorv1.OperatorCondition, dns *operatorv1.DNS) operatorv1.OperatorCondition {
upgradeableCondition := &operatorv1.OperatorCondition{
Type: operatorv1.OperatorStatusTypeUpgradeable,
}
if dns.Spec.ManagementState == operatorv1.Unmanaged {
upgradeableCondition.Status = operatorv1.ConditionFalse
upgradeableCondition.Reason = "OperatorUnmanaged"
upgradeableCondition.Message = "Cannot upgrade while managementState is Unmanaged"
} else {
upgradeableCondition.Status = operatorv1.ConditionTrue
upgradeableCondition.Reason = "AsExpected"
upgradeableCondition.Message = "DNS Operator can be upgraded"
}
return setDNSLastTransitionTime(upgradeableCondition, oldCondition)
}
// setDNSLastTransitionTime sets LastTransitionTime for the given condition.
// If the condition has changed, it will assign a new timestamp otherwise keeps the old timestamp.
func setDNSLastTransitionTime(condition, oldCondition *operatorv1.OperatorCondition) operatorv1.OperatorCondition {
if oldCondition != nil && condition.Status == oldCondition.Status {
condition.LastTransitionTime = oldCondition.LastTransitionTime
} else {
condition.LastTransitionTime = metav1.Now()
}
return *condition
}
// dnsStatusesEqual compares two DNSStatus values. Returns true
// if the provided values should be considered equal for the purpose of determining
// whether an update is necessary, false otherwise.
func dnsStatusesEqual(a, b operatorv1.DNSStatus) bool {
conditionCmpOpts := []cmp.Option{
cmpopts.EquateEmpty(),
cmpopts.SortSlices(func(a, b operatorv1.OperatorCondition) bool { return a.Type < b.Type }),
}
if !cmp.Equal(a.Conditions, b.Conditions, conditionCmpOpts...) {
return false
}
if a.ClusterIP != b.ClusterIP {
return false
}
if a.ClusterDomain != b.ClusterDomain {
return false
}
return true
}
// lastTransitionTimeIsRecent returns true if elapsed time
// (currTime-prevTime) <= toleration. It returns false if currTime is
// before prevTime or if toleration < 0. It returns true if elapsed time
// is 0.
func lastTransitionTimeIsRecent(currTime, prevTime time.Time, toleration time.Duration) bool {
if toleration < 0 {
return false
}
switch elapsed := currTime.Sub(prevTime); {
case elapsed == 0:
return true
case elapsed < 0:
return false
default:
return elapsed <= toleration
}
}