Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish information about the registry #29

Closed
dmage opened this issue Oct 3, 2018 · 5 comments
Closed

Publish information about the registry #29

dmage opened this issue Oct 3, 2018 · 5 comments
Assignees

Comments

@dmage
Copy link
Member

dmage commented Oct 3, 2018

In order to make the internal registry discoverable by other components (the API server, for example), we should create the ConfigMap openshift-image-registry/(image-registry-)?public-info with:

  1. our internal host name (image-registry.openshift-image-registry.svc.cluster.local:5000),
  2. our external host name.

This ConfigMap should be readable by system:authenticated.

@bparees
Copy link
Contributor

bparees commented Oct 3, 2018

In addition to doing this, i'd like to change the api server behavior to default to image-registry.openshift-image-registry.svc.cluster.local:5000 so that when the apiserver comes up before the registry is installed, it still has the correct value.

The reason this is important is because the imagechangecontroller caches the values of the imagestreams it lists, and the imagestream list/get api uses a decorator to apply the status.dockerImageRepository value based on the internalHostname.

The overall impact of which is that if the imagechangecontroller is up before the registry configuration is available, it will cache values that have an empty status.dockerImageRepository and even after the registry comes up, it will use the incorrect value.

Also of course once we start publishing this information, we need the api server to consume it.

@legionus
Copy link
Contributor

@dmage Is this still relevant?

@bparees
Copy link
Contributor

bparees commented Oct 22, 2018

Yes, some of this will be part of my work this sprint: the image-registry operator will need to publish the internalRegistryHostname value into the cluster configuration so it can be consumed by the apisever and controllers (previously those components got the value from master-config.yaml).

and I have a PR for defaulting the value in some of the components themselves here, but i'm not sure it's going to go anywhere: openshift/origin#21160

@bparees bparees self-assigned this Oct 22, 2018
@bparees
Copy link
Contributor

bparees commented Jan 8, 2019

we're now publishing this information (internalhostname anyway) to the image clusterconfig object.

the default hostname should be published there as well, when it is defined.

@dmage
Copy link
Member Author

dmage commented May 19, 2020

We publish information about all known hostnames to the image.config object.

@dmage dmage closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants