Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to retry failed deploymentconfig rollouts or switch to deployments #34

Closed
deads2k opened this issue Oct 12, 2018 · 1 comment
Closed
Assignees

Comments

@deads2k
Copy link
Contributor

deads2k commented Oct 12, 2018

Upstream deployments constantly try to rollout the latest state until explicitly asked not to. DeploymentConfigs give up unless triggered again. Given an operator managed deploymentconfig that should be actively reconciled, you should be retrying failed deployments since they can later succeed.

The current state in openshift/installer is a good example where a blip in the first rollout will cause the image registry to be stuck indefinitely. Switching to a deployment will resolve this problem. Alternatively you can rebuild the oc rollout logic.

@bparees
Copy link
Contributor

bparees commented Oct 12, 2018

/assign @legionus

if you want to switch the registry to a deployment for "new" registries you can, but it means you still need to deal with deploymentconfigs for 3.11 registries. And we are still not prepared to take on migrating those 3.11 registries from a DC to a Deployment since ensuring we can do so without causing an outage, breaking storage, or otherwise blowing things up, isn't something i think we are in a position to tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants