Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update empty volumeSource to use emptyDir #91

Closed
dmage opened this issue Nov 28, 2018 · 1 comment
Closed

Can't update empty volumeSource to use emptyDir #91

dmage opened this issue Nov 28, 2018 · 1 comment
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dmage
Copy link
Member

dmage commented Nov 28, 2018

The operator doesn't allow to change configuration from

  storage:
    filesystem: {}

to

  storage:
    filesystem:
      volumeSource:
        emptyDir: {}

because storage type change is not supported: expected storage type filesystem, but got emptydir.

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2018
@bparees
Copy link
Contributor

bparees commented Nov 28, 2018

I think for now we need to remove the logic that prevents storage changes.

we can discuss it on scrum or elsewhere, but i'm coming to the conclusion that trying to block storage changes is going to be too painful in light of the need for users to potentially tweak settings like adding cloudfront to s3, or us generally getting storage wrong.

i'd rather start w/ it being allowed and in the future when we have more time we can figure out how to put sensible restrictions in place along with a proper way for users to get around those restrictions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants