Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong annotation for ThanosRulerConfig.Resources #2069

Closed
juzhao opened this issue Aug 9, 2023 · 1 comment
Closed

wrong annotation for ThanosRulerConfig.Resources #2069

juzhao opened this issue Aug 9, 2023 · 1 comment

Comments

@juzhao
Copy link

juzhao commented Aug 9, 2023

https://github.com/openshift/cluster-monitoring-operator/blob/release-4.14/pkg/manifests/types.go#L648-L649

// Defines resource requests and limits for the Alertmanager container.
should be
// Defines resource requests and limits for the Thanos Ruler container.
@juzhao
Copy link
Author

juzhao commented Aug 9, 2023

tracked in https://issues.redhat.com/browse/OCPBUGS-17487

@juzhao juzhao closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juzhao