Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name on CSV doesn't match entry in art.yaml (4.8 only) #197

Closed
thiagoalessio opened this issue Aug 12, 2021 · 1 comment
Closed

Name on CSV doesn't match entry in art.yaml (4.8 only) #197

thiagoalessio opened this issue Aug 12, 2021 · 1 comment

Comments

@thiagoalessio
Copy link
Member

In all release-4.* branches, the CSV has name: nfd..., so the string replacement defined in art.yaml works fine, creating a unique name for every new release of the operator's bundle.

But in release-4.8, the name in the CSV is different:

    name: node-feature-discovery-operator.v4.8.0

https://github.com/openshift/cluster-nfd-operator/blob/release-4.8/manifests/4.8/manifests/nfd.v4.8.0.clusterserviceversion.yaml#L44

So art.yaml replacements don't happen, and pushing the bundles fail without a unique name.

Similar issue happened kubernetes-nmstate: openshift/kubernetes-nmstate#203

We can either change the entry in art.yaml only for release-4.8 branch, to something like this:

    update_list:
-    - search: "nfd.v{MAJOR}.{MINOR}.0"
-      replace: "nfd.{FULL_VER}"
+    - search: "node-feature-discovery-operator.v{MAJOR}.{MINOR}.0"
+      replace: "node-feature-discovery-operator.{FULL_VER}"

Or change the name to "nfd" in the CSV

    operatorframework.io/arch.ppc64le: supported
    operatorframework.io/arch.s390x: supported
-  name: node-feature-discovery-operator.v4.8.0
+  name: nfd.v4.8.0
  namespace: placeholder
@thiagoalessio
Copy link
Member Author

@ArangoGutierrez closing this issue, as it seems to have been resolved by e499df2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant