New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1754638: loopback: don't tear down #15
Conversation
There is a bug in CRIO that issues deletes against processes running in the root network namespace. This means we take the node's loopback interface down. This is bad. This bug was always present, BTW, but we skipped loopback on teardown.
aws flake |
/lgtm |
I think this has to be 4.3 then backported to 4.2.z now.. |
this is a critical bug - we definitely need this in 4.2.0 |
/bugzilla refresh |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, knobunc, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
For the record: Xiaoli said on a 6am call today that if we had fixes in for this bug by EOD today, QE could absorb it. |
/retitle Bug 1754638: loopback: don't tear down |
@squeed: This pull request references Bugzilla bug 1754638, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I am approving this for 4.2.0. Since we cannot merge to 4.3 yet I am not waiting on the parent BZ to be VERIFIED. Since I want this in 4.2.0 and not 4.2.z I'm ignoring the complain about that as well. Now hopefully CI passes. |
/retest |
@squeed: An error was encountered searching for external tracker bugs for bug 1754638 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@stevekuznetsov: Bugzilla bug 1754638 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is a bug in CRIO that issues deletes against processes running in the root network namespace. This means we take the node's loopback interface down. This is bad.
This bug was always present, BTW, but we skipped loopback on teardown.
/cc @dcbw