Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1754638: loopback: don't tear down #15

Merged
merged 1 commit into from Sep 23, 2019

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Sep 23, 2019

There is a bug in CRIO that issues deletes against processes running in the root network namespace. This means we take the node's loopback interface down. This is bad.

This bug was always present, BTW, but we skipped loopback on teardown.

/cc @dcbw

There is a bug in CRIO that issues deletes against processes running in
the root network namespace. This means we take the node's loopback
interface down. This is bad.

This bug was always present, BTW, but we skipped loopback on teardown.
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2019
@squeed
Copy link
Contributor Author

squeed commented Sep 23, 2019

aws flake
/retest

@dcbw
Copy link
Contributor

dcbw commented Sep 23, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@kikisdeliveryservice
Copy link

kikisdeliveryservice commented Sep 23, 2019

I think this has to be 4.3 then backported to 4.2.z now..

@squeed
Copy link
Contributor Author

squeed commented Sep 23, 2019

this is a critical bug - we definitely need this in 4.2.0

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 23, 2019
@knobunc
Copy link

knobunc commented Sep 23, 2019

/bugzilla refresh

@knobunc knobunc removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 23, 2019
@knobunc
Copy link

knobunc commented Sep 23, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, knobunc, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice
Copy link

/bugzilla refresh

@knobunc
Copy link

knobunc commented Sep 23, 2019

For the record: Xiaoli said on a 6am call today that if we had fixes in for this bug by EOD today, QE could absorb it.

@kikisdeliveryservice
Copy link

/retitle Bug 1754638: loopback: don't tear down

@openshift-ci-robot openshift-ci-robot changed the title Bug 1754154: loopback: don't tear down Bug 1754638: loopback: don't tear down Sep 23, 2019
@openshift-ci-robot
Copy link
Contributor

@squeed: This pull request references Bugzilla bug 1754638, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug 1754154 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1754638: loopback: don't tear down

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 23, 2019
@eparis
Copy link
Member

eparis commented Sep 23, 2019

I am approving this for 4.2.0. Since we cannot merge to 4.3 yet I am not waiting on the parent BZ to be VERIFIED. Since I want this in 4.2.0 and not 4.2.z I'm ignoring the complain about that as well.

Now hopefully CI passes.

@knobunc knobunc removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 23, 2019
@openshift openshift deleted a comment from openshift-ci-robot Sep 23, 2019
@openshift openshift deleted a comment from openshift-ci-robot Sep 23, 2019
@openshift openshift deleted a comment from openshift-ci-robot Sep 23, 2019
@knobunc
Copy link

knobunc commented Sep 23, 2019

/retest

@stevekuznetsov stevekuznetsov merged commit b5e1059 into openshift:release-4.2 Sep 23, 2019
@openshift-ci-robot
Copy link
Contributor

@squeed: An error was encountered searching for external tracker bugs for bug 1754638 on the Bugzilla server at https://bugzilla.redhat.com:

could not parse external identifier "/pull/15/" as pull: invalid pull identifier with 5 parts: "/pull/15/"
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1754638: loopback: don't tear down

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: Bugzilla bug 1754638 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants