This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Transition to using python-bugzilla library #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
size/M
smunilla
force-pushed
the
convert-to-bzlib
branch
from
868c404
to
e369908
Compare
smunilla
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
smunilla
force-pushed
the
convert-to-bzlib
branch
from
e369908
to
0278c6c
Compare
tbielawa
reviewed
Jan 14, 2019
| else: | ||
| bug_ids = [elliottlib.bugzilla.Bug(id=i) for i in id] | ||
| bzapi = elliottlib.bzutil.get_bzapi(bz_data) | ||
| bug_ids = [bzapi.getbug(i) for i in id] |
There was a problem hiding this comment.
We are the best at duplicating code
tbielawa
reviewed
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from using shell callouts to the python-bugzilla cli and use the actual library. Also remove the deprecated bug transition searches now that we can add VERIFIED bugs regardless of the path they took to get there.