-
Notifications
You must be signed in to change notification settings - Fork 233
/
clusterdeployment_controller.go
2169 lines (1939 loc) · 82.3 KB
/
clusterdeployment_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package clusterdeployment
import (
"context"
"fmt"
"os"
"reflect"
"sort"
"strconv"
"strings"
"time"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
routev1 "github.com/openshift/api/route/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/dynamic"
"k8s.io/client-go/rest"
"k8s.io/client-go/util/flowcontrol"
"k8s.io/client-go/util/workqueue"
"k8s.io/utils/pointer"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
librarygocontroller "github.com/openshift/library-go/pkg/controller"
"github.com/openshift/library-go/pkg/manifest"
"github.com/openshift/library-go/pkg/verify"
"github.com/openshift/library-go/pkg/verify/store/sigstore"
apihelpers "github.com/openshift/hive/apis/helpers"
hivev1 "github.com/openshift/hive/apis/hive/v1"
hiveintv1alpha1 "github.com/openshift/hive/apis/hiveinternal/v1alpha1"
"github.com/openshift/hive/pkg/constants"
hivemetrics "github.com/openshift/hive/pkg/controller/metrics"
"github.com/openshift/hive/pkg/controller/utils"
controllerutils "github.com/openshift/hive/pkg/controller/utils"
"github.com/openshift/hive/pkg/imageset"
"github.com/openshift/hive/pkg/remoteclient"
k8slabels "github.com/openshift/hive/pkg/util/labels"
)
var (
// controllerKind contains the schema.GroupVersionKind for this controller type.
controllerKind = hivev1.SchemeGroupVersion.WithKind("ClusterDeployment")
// clusterDeploymentConditions are the cluster deployment conditions controlled or
// initialized by cluster deployment controller
clusterDeploymentConditions = []hivev1.ClusterDeploymentConditionType{
hivev1.DNSNotReadyCondition,
hivev1.InstallImagesNotResolvedCondition,
hivev1.ProvisionFailedCondition,
hivev1.SyncSetFailedCondition,
hivev1.InstallLaunchErrorCondition,
hivev1.DeprovisionLaunchErrorCondition,
hivev1.ProvisionStoppedCondition,
hivev1.AuthenticationFailureClusterDeploymentCondition,
hivev1.RequirementsMetCondition,
hivev1.ProvisionedCondition,
// ClusterInstall conditions copied over to cluster deployment
hivev1.ClusterInstallFailedClusterDeploymentCondition,
hivev1.ClusterInstallCompletedClusterDeploymentCondition,
hivev1.ClusterInstallStoppedClusterDeploymentCondition,
hivev1.ClusterInstallRequirementsMetClusterDeploymentCondition,
// ImageSet condition initialized by cluster deployment
hivev1.InstallerImageResolutionFailedCondition,
}
)
const (
ControllerName = hivev1.ClusterDeploymentControllerName
defaultRequeueTime = 10 * time.Second
maxProvisions = 3
platformAuthFailureReason = "PlatformAuthError"
platformAuthSuccessReason = "PlatformAuthSuccess"
clusterImageSetNotFoundReason = "ClusterImageSetNotFound"
clusterImageSetFoundReason = "ClusterImageSetFound"
defaultDNSNotReadyTimeout = 10 * time.Minute
dnsNotReadyReason = "DNSNotReady"
dnsNotReadyTimedoutReason = "DNSNotReadyTimedOut"
dnsUnsupportedPlatformReason = "DNSUnsupportedPlatform"
dnsZoneResourceConflictReason = "DNSZoneResourceConflict"
dnsReadyReason = "DNSReady"
dnsReadyAnnotation = "hive.openshift.io/dnsready"
installAttemptsLimitReachedReason = "InstallAttemptsLimitReached"
installOnlyOnceSetReason = "InstallOnlyOnceSet"
failureReasonNotListed = "FailureReasonNotRetryable"
provisionNotStoppedReason = "ProvisionNotStopped"
deleteAfterAnnotation = "hive.openshift.io/delete-after" // contains a duration after which the cluster should be cleaned up.
tryInstallOnceAnnotation = "hive.openshift.io/try-install-once"
regionUnknown = "unknown"
)
// Add creates a new ClusterDeployment controller and adds it to the manager with default RBAC.
func Add(mgr manager.Manager) error {
logger := log.WithField("controller", ControllerName)
concurrentReconciles, clientRateLimiter, queueRateLimiter, err := controllerutils.GetControllerConfig(mgr.GetClient(), ControllerName)
if err != nil {
logger.WithError(err).Error("could not get controller configurations")
return err
}
return AddToManager(mgr, NewReconciler(mgr, logger, clientRateLimiter), concurrentReconciles, queueRateLimiter)
}
// NewReconciler returns a new reconcile.Reconciler
func NewReconciler(mgr manager.Manager, logger log.FieldLogger, rateLimiter flowcontrol.RateLimiter) reconcile.Reconciler {
r := &ReconcileClusterDeployment{
Client: controllerutils.NewClientWithMetricsOrDie(mgr, ControllerName, &rateLimiter),
scheme: mgr.GetScheme(),
logger: logger,
expectations: controllerutils.NewExpectations(logger),
watchingClusterInstall: map[string]struct{}{},
validateCredentialsForClusterDeployment: controllerutils.ValidateCredentialsForClusterDeployment,
}
r.remoteClusterAPIClientBuilder = func(cd *hivev1.ClusterDeployment) remoteclient.Builder {
return remoteclient.NewBuilder(r.Client, cd, ControllerName)
}
protectedDeleteEnvVar := os.Getenv(constants.ProtectedDeleteEnvVar)
if protectedDelete, err := strconv.ParseBool(protectedDeleteEnvVar); protectedDelete && err == nil {
logger.Info("Protected Delete enabled")
r.protectedDelete = true
}
verifier, err := LoadReleaseImageVerifier(mgr.GetConfig())
if err == nil {
logger.Info("Release Image verification enabled")
r.releaseImageVerifier = verifier
} else {
logger.WithError(err).Error("Release Image verification failed to be configured")
}
return r
}
// AddToManager adds a new Controller to mgr with r as the reconcile.Reconciler
func AddToManager(mgr manager.Manager, r reconcile.Reconciler, concurrentReconciles int, rateLimiter workqueue.RateLimiter) error {
cdReconciler, ok := r.(*ReconcileClusterDeployment)
if !ok {
return errors.New("reconciler supplied is not a ReconcileClusterDeployment")
}
logger := log.WithField("controller", ControllerName)
c, err := controller.New("clusterdeployment-controller", mgr, controller.Options{
Reconciler: r,
MaxConcurrentReconciles: concurrentReconciles,
RateLimiter: rateLimiter,
})
if err != nil {
logger.WithError(err).Error("could not create controller")
return err
}
// Inject watcher to the clusterdeployment reconciler.
controllerutils.InjectWatcher(cdReconciler, c)
if err := mgr.GetFieldIndexer().IndexField(context.TODO(), &hivev1.ClusterDeployment{},
clusterInstallIndexFieldName, indexClusterInstall); err != nil {
logger.WithError(err).Error("Error indexing cluster deployment for cluster install")
return err
}
// Watch for changes to ClusterDeployment
err = c.Watch(&source.Kind{Type: &hivev1.ClusterDeployment{}},
controllerutils.NewRateLimitedUpdateEventHandler(&handler.EnqueueRequestForObject{}, controllerutils.IsClusterDeploymentErrorUpdateEvent))
if err != nil {
logger.WithError(err).Error("Error watching cluster deployment")
return err
}
// Watch for provisions
if err := cdReconciler.watchClusterProvisions(c); err != nil {
return err
}
// Watch for jobs created by a ClusterDeployment:
err = c.Watch(&source.Kind{Type: &batchv1.Job{}}, &handler.EnqueueRequestForOwner{
IsController: true,
OwnerType: &hivev1.ClusterDeployment{},
})
if err != nil {
logger.WithError(err).Error("Error watching cluster deployment job")
return err
}
// Watch for pods created by an install job
err = c.Watch(&source.Kind{Type: &corev1.Pod{}}, handler.EnqueueRequestsFromMapFunc(selectorPodWatchHandler))
if err != nil {
logger.WithError(err).Error("Error watching cluster deployment pods")
return err
}
// Watch for deprovision requests created by a ClusterDeployment
err = c.Watch(&source.Kind{Type: &hivev1.ClusterDeprovision{}}, &handler.EnqueueRequestForOwner{
IsController: true,
OwnerType: &hivev1.ClusterDeployment{},
})
if err != nil {
logger.WithError(err).Error("Error watching deprovision request created by cluster deployment")
return err
}
// Watch for dnszones created by a ClusterDeployment
err = c.Watch(&source.Kind{Type: &hivev1.DNSZone{}}, &handler.EnqueueRequestForOwner{
IsController: true,
OwnerType: &hivev1.ClusterDeployment{},
})
if err != nil {
logger.WithError(err).Error("Error watching cluster deployment dnszones")
return err
}
// Watch for changes to ClusterSyncs
if err := c.Watch(
&source.Kind{Type: &hiveintv1alpha1.ClusterSync{}},
&handler.EnqueueRequestForOwner{OwnerType: &hivev1.ClusterDeployment{}},
); err != nil {
return errors.Wrap(err, "cannot start watch on ClusterSyncs")
}
return nil
}
var _ reconcile.Reconciler = &ReconcileClusterDeployment{}
// ReconcileClusterDeployment reconciles a ClusterDeployment object
type ReconcileClusterDeployment struct {
client.Client
scheme *runtime.Scheme
logger log.FieldLogger
// watcher allows the reconciler to add new watches
// at runtime.
watcher controllerutils.Watcher
// this is a set of cluster install contracts that are currently
// being watched. this allows the reconciler to only add Watch for
// these once.
watchingClusterInstall map[string]struct{}
// A TTLCache of clusterprovision creates each clusterdeployment expects to see
expectations controllerutils.ExpectationsInterface
// remoteClusterAPIClientBuilder is a function pointer to the function that gets a builder for building a client
// for the remote cluster's API server
remoteClusterAPIClientBuilder func(cd *hivev1.ClusterDeployment) remoteclient.Builder
// validateCredentialsForClusterDeployment is what this controller will call to validate
// that the platform creds are good (used for testing)
validateCredentialsForClusterDeployment func(client.Client, *hivev1.ClusterDeployment, log.FieldLogger) (bool, error)
// releaseImageVerifier, if provided, will be used to check an release image before it is executed.
// Any error will prevent a release image from being accessed.
releaseImageVerifier verify.Interface
protectedDelete bool
}
// Reconcile reads that state of the cluster for a ClusterDeployment object and makes changes based on the state read
// and what is in the ClusterDeployment.Spec
func (r *ReconcileClusterDeployment) Reconcile(ctx context.Context, request reconcile.Request) (result reconcile.Result, returnErr error) {
cdLog := controllerutils.BuildControllerLogger(ControllerName, "clusterDeployment", request.NamespacedName)
cdLog.Info("reconciling cluster deployment")
recobsrv := hivemetrics.NewReconcileObserver(ControllerName, cdLog)
defer recobsrv.ObserveControllerReconcileTime()
// Fetch the ClusterDeployment instance
cd := &hivev1.ClusterDeployment{}
err := r.Get(context.TODO(), request.NamespacedName, cd)
if err != nil {
if apierrors.IsNotFound(err) {
// Object not found, return. Created objects are automatically garbage collected.
// For additional cleanup logic use finalizers.
cdLog.Info("cluster deployment Not Found")
r.expectations.DeleteExpectations(request.NamespacedName.String())
return reconcile.Result{}, nil
}
// Error reading the object - requeue the request.
cdLog.WithError(err).Error("Error getting cluster deployment")
return reconcile.Result{}, err
}
// Ensure owner references are correctly set
err = controllerutils.ReconcileOwnerReferences(cd, generateOwnershipUniqueKeys(cd), r, r.scheme, r.logger)
if err != nil {
cdLog.WithError(err).Error("Error reconciling object ownership")
return reconcile.Result{}, err
}
// Initialize cluster deployment conditions if not set
newConditions := controllerutils.InitializeClusterDeploymentConditions(cd.Status.Conditions, clusterDeploymentConditions)
if len(newConditions) > len(cd.Status.Conditions) {
cd.Status.Conditions = newConditions
cdLog.Info("initializing cluster deployment controller conditions")
if err := r.Status().Update(context.TODO(), cd); err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "failed to update cluster deployment status")
return reconcile.Result{}, err
}
return reconcile.Result{}, nil
}
// Remove legacy conditions if present:
legacyConditions := []string{
"ClusterImageSetNotFound",
}
newConditions = []hivev1.ClusterDeploymentCondition{}
var removedLegacyConditions bool
for _, c := range cd.Status.Conditions {
isLegacy := false
for _, lc := range legacyConditions {
if string(c.Type) == lc {
isLegacy = true
break
}
}
if !isLegacy {
newConditions = append(newConditions, c)
} else {
cdLog.Infof("removing legacy condition: %v", c)
removedLegacyConditions = true
}
}
if removedLegacyConditions {
cd.Status.Conditions = newConditions
if err := r.Status().Update(context.TODO(), cd); err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "failed to update cluster deployment status")
return reconcile.Result{}, err
}
return reconcile.Result{}, nil
}
return r.reconcile(request, cd, cdLog)
}
func (r *ReconcileClusterDeployment) SetWatcher(w controllerutils.Watcher) {
r.watcher = w
}
func generateOwnershipUniqueKeys(owner hivev1.MetaRuntimeObject) []*controllerutils.OwnershipUniqueKey {
return []*controllerutils.OwnershipUniqueKey{
{
TypeToList: &hivev1.ClusterProvisionList{},
LabelSelector: map[string]string{constants.ClusterDeploymentNameLabel: owner.GetName()},
Controlled: true,
},
{
TypeToList: &corev1.PersistentVolumeClaimList{},
LabelSelector: map[string]string{
constants.ClusterDeploymentNameLabel: owner.GetName(),
constants.PVCTypeLabel: constants.PVCTypeInstallLogs,
},
Controlled: true,
},
{
TypeToList: &batchv1.JobList{},
LabelSelector: map[string]string{
constants.ClusterDeploymentNameLabel: owner.GetName(),
constants.JobTypeLabel: constants.JobTypeImageSet,
},
Controlled: true,
},
{
TypeToList: &hivev1.ClusterDeprovisionList{},
LabelSelector: map[string]string{
constants.ClusterDeploymentNameLabel: owner.GetName(),
},
Controlled: true,
},
{
TypeToList: &hivev1.DNSZoneList{},
LabelSelector: map[string]string{
constants.ClusterDeploymentNameLabel: owner.GetName(),
constants.DNSZoneTypeLabel: constants.DNSZoneTypeChild,
},
Controlled: true,
},
{
TypeToList: &corev1.SecretList{},
LabelSelector: map[string]string{
constants.ClusterDeploymentNameLabel: owner.GetName(),
constants.SecretTypeLabel: constants.SecretTypeMergedPullSecret,
},
Controlled: true,
},
{
TypeToList: &corev1.SecretList{},
LabelSelector: map[string]string{
constants.ClusterDeploymentNameLabel: owner.GetName(),
constants.SecretTypeLabel: constants.SecretTypeKubeConfig,
},
Controlled: false,
},
{
TypeToList: &corev1.SecretList{},
LabelSelector: map[string]string{
constants.ClusterDeploymentNameLabel: owner.GetName(),
constants.SecretTypeLabel: constants.SecretTypeKubeAdminCreds,
},
Controlled: false,
},
}
}
func (r *ReconcileClusterDeployment) addAdditionalKubeconfigCAs(cd *hivev1.ClusterDeployment,
cdLog log.FieldLogger) error {
adminKubeconfigSecret := &corev1.Secret{}
if err := r.Get(context.Background(), types.NamespacedName{Namespace: cd.Namespace, Name: cd.Spec.ClusterMetadata.AdminKubeconfigSecretRef.Name}, adminKubeconfigSecret); err != nil {
cdLog.WithError(err).Error("failed to get admin kubeconfig secret")
return err
}
originalSecret := adminKubeconfigSecret.DeepCopy()
rawData, hasRawData := adminKubeconfigSecret.Data[constants.RawKubeconfigSecretKey]
if !hasRawData {
adminKubeconfigSecret.Data[constants.RawKubeconfigSecretKey] = adminKubeconfigSecret.Data[constants.KubeconfigSecretKey]
rawData = adminKubeconfigSecret.Data[constants.KubeconfigSecretKey]
}
var err error
adminKubeconfigSecret.Data[constants.KubeconfigSecretKey], err = controllerutils.AddAdditionalKubeconfigCAs(rawData)
if err != nil {
cdLog.WithError(err).Errorf("error adding additional CAs to admin kubeconfig")
return err
}
if reflect.DeepEqual(originalSecret.Data, adminKubeconfigSecret.Data) {
cdLog.Debug("secret data has not changed, no need to update")
return nil
}
cdLog.Info("admin kubeconfig has been modified, updating")
err = r.Update(context.TODO(), adminKubeconfigSecret)
if err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "error updating admin kubeconfig secret")
return err
}
return nil
}
func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hivev1.ClusterDeployment, cdLog log.FieldLogger) (result reconcile.Result, returnErr error) {
// Set platform label on the ClusterDeployment
if platform := getClusterPlatform(cd); cd.Labels[hivev1.HiveClusterPlatformLabel] != platform {
if cd.Labels == nil {
cd.Labels = make(map[string]string)
}
if cd.Labels[hivev1.HiveClusterPlatformLabel] != "" {
cdLog.Warnf("changing the value of %s from %s to %s", hivev1.HiveClusterPlatformLabel,
cd.Labels[hivev1.HiveClusterPlatformLabel], platform)
}
cd.Labels[hivev1.HiveClusterPlatformLabel] = platform
err := r.Update(context.TODO(), cd)
if err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "failed to set cluster platform label")
}
return reconcile.Result{}, err
}
// Set region label on the ClusterDeployment
if region := getClusterRegion(cd); cd.Spec.Platform.BareMetal == nil && cd.Spec.Platform.AgentBareMetal == nil &&
cd.Labels[hivev1.HiveClusterRegionLabel] != region {
if cd.Labels == nil {
cd.Labels = make(map[string]string)
}
if cd.Labels[hivev1.HiveClusterRegionLabel] != "" {
cdLog.Warnf("changing the value of %s from %s to %s", hivev1.HiveClusterRegionLabel,
cd.Labels[hivev1.HiveClusterRegionLabel], region)
}
cd.Labels[hivev1.HiveClusterRegionLabel] = region
err := r.Update(context.TODO(), cd)
if err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "failed to set cluster region label")
}
return reconcile.Result{}, err
}
if cd.Spec.ManageDNS {
changed, err := r.ensureDNSZonePreserveOnDelete(cd, cdLog)
if err != nil {
return reconcile.Result{}, err
}
if changed {
return reconcile.Result{}, nil
}
}
if cd.DeletionTimestamp != nil {
if !controllerutils.HasFinalizer(cd, hivev1.FinalizerDeprovision) {
// Make sure we have no deprovision underway metric even though this was probably cleared when we
// removed the finalizer.
clearDeprovisionUnderwaySecondsMetric(cd, cdLog)
return reconcile.Result{}, nil
}
// Deprovision still underway, report metric for this cluster.
hivemetrics.MetricClusterDeploymentDeprovisioningUnderwaySeconds.WithLabelValues(
cd.Name,
cd.Namespace,
hivemetrics.GetClusterDeploymentType(cd)).Set(
time.Since(cd.DeletionTimestamp.Time).Seconds())
return r.syncDeletedClusterDeployment(cd, cdLog)
}
// Check for the delete-after annotation, and if the cluster has expired, delete it
deleteAfter, ok := cd.Annotations[deleteAfterAnnotation]
if ok {
cdLog.Debugf("found delete after annotation: %s", deleteAfter)
dur, err := time.ParseDuration(deleteAfter)
if err != nil {
cdLog.WithError(err).WithField("deleteAfter", deleteAfter).Infof("error parsing %s as a duration", deleteAfterAnnotation)
return reconcile.Result{}, fmt.Errorf("error parsing %s as a duration: %v", deleteAfterAnnotation, err)
}
if !cd.CreationTimestamp.IsZero() {
expiry := cd.CreationTimestamp.Add(dur)
cdLog.Debugf("cluster expires at: %s", expiry)
if time.Now().After(expiry) {
cdLog.WithField("expiry", expiry).Info("cluster has expired, issuing delete")
err := utils.SafeDelete(r, context.TODO(), cd)
if err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "error deleting expired cluster")
}
return reconcile.Result{}, err
}
defer func() {
// We have an expiry time but we're not expired yet. Set requeueAfter to the expiry time
// so that we requeue cluster for deletion once reconcile has completed
result, returnErr = controllerutils.EnsureRequeueAtLeastWithin(
time.Until(cd.CreationTimestamp.Add(dur)),
result,
returnErr,
)
}()
}
}
if !controllerutils.HasFinalizer(cd, hivev1.FinalizerDeprovision) {
cdLog.Debugf("adding clusterdeployment finalizer")
if err := r.addClusterDeploymentFinalizer(cd); err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "error adding finalizer")
return reconcile.Result{}, err
}
metricClustersCreated.WithLabelValues(hivemetrics.GetClusterDeploymentType(cd)).Inc()
return reconcile.Result{}, nil
}
if cd.Spec.ManageDNS {
dnsZone, err := r.ensureManagedDNSZone(cd, cdLog)
if err != nil {
return reconcile.Result{}, err
}
if dnsZone == nil {
// dnsNotReady condition was set.
if isSet, _ := isDNSNotReadyConditionSet(cd); isSet {
// dnsNotReadyReason is why the dnsNotReady condition was set, therefore requeue so that we check to see if it times out.
// add defaultRequeueTime to avoid the race condition where the controller is reconciled at the exact time of the timeout (unlikely, but possible).
return reconcile.Result{RequeueAfter: defaultDNSNotReadyTimeout + defaultRequeueTime}, nil
}
return reconcile.Result{}, nil
}
updated, err := r.setDNSDelayMetric(cd, dnsZone, cdLog)
if updated || err != nil {
return reconcile.Result{}, err
}
}
if cd.Spec.Installed {
// set installedTimestamp for adopted clusters
if cd.Status.InstalledTimestamp == nil {
cd.Status.InstalledTimestamp = &cd.ObjectMeta.CreationTimestamp
if err := r.Status().Update(context.TODO(), cd); err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "could not set cluster installed timestamp")
return reconcile.Result{Requeue: true}, nil
}
}
// Set the Provisioned status condition for adopted clusters (and in case we upgraded to/past where that condition was introduced)
if err := r.updateCondition(
cd,
hivev1.ProvisionedCondition,
corev1.ConditionTrue,
hivev1.ProvisionedReasonProvisioned,
"Cluster is provisioned",
cdLog,
); err != nil {
cdLog.WithError(err).Error("Error updating Provisioned status condition")
return reconcile.Result{}, err
}
// update SyncSetFailedCondition status condition
cdLog.Debug("Check if any syncsets are failing")
if err := r.setSyncSetFailedCondition(cd, cdLog); err != nil {
cdLog.WithError(err).Error("Error updating SyncSetFailedCondition status condition")
return reconcile.Result{}, err
}
switch {
case cd.Spec.Provisioning != nil:
if r, err := r.reconcileInstalledClusterProvision(cd, cdLog); err != nil {
return r, err
}
}
if cd.Spec.ClusterMetadata != nil &&
cd.Spec.ClusterMetadata.AdminKubeconfigSecretRef.Name != "" {
if err := r.addAdditionalKubeconfigCAs(cd, cdLog); err != nil {
return reconcile.Result{}, err
}
// Add cluster deployment as additional owner reference to admin secrets
if err := r.addOwnershipToSecret(cd, cdLog, cd.Spec.ClusterMetadata.AdminKubeconfigSecretRef.Name); err != nil {
return reconcile.Result{}, err
}
if cd.Spec.ClusterMetadata.AdminPasswordSecretRef != nil && cd.Spec.ClusterMetadata.AdminPasswordSecretRef.Name != "" {
if err := r.addOwnershipToSecret(cd, cdLog, cd.Spec.ClusterMetadata.AdminPasswordSecretRef.Name); err != nil {
return reconcile.Result{}, err
}
}
if cd.Status.WebConsoleURL == "" || cd.Status.APIURL == "" {
return r.setClusterStatusURLs(cd, cdLog)
}
}
return reconcile.Result{}, nil
}
// If the ClusterDeployment is being relocated to another Hive instance, stop any current provisioning and do not
// do any more reconciling.
switch _, relocateStatus, err := controllerutils.IsRelocating(cd); {
case err != nil:
return reconcile.Result{}, errors.Wrap(err, "could not determine relocate status")
case relocateStatus == hivev1.RelocateOutgoing:
result, err := r.stopProvisioning(cd, cdLog)
if result == nil {
result = &reconcile.Result{}
}
return *result, err
}
// Sanity check the platform/cloud credentials and set hivev1.AuthenticationFailureClusterDeploymentCondition
validCreds, authError := r.validatePlatformCreds(cd, cdLog)
_, err := r.setAuthenticationFailure(cd, validCreds, authError, cdLog)
if err != nil {
cdLog.WithError(err).Error("unable to update clusterdeployment")
return reconcile.Result{}, err
}
// If the platform credentials are no good, return error and go into backoff
authCondition := controllerutils.FindClusterDeploymentCondition(cd.Status.Conditions, hivev1.AuthenticationFailureClusterDeploymentCondition)
if authCondition.Status == corev1.ConditionTrue {
authError := errors.New(authCondition.Message)
cdLog.WithError(authError).Error("cannot proceed with provision while platform credentials authentication is failing.")
return reconcile.Result{}, authError
}
imageSet, err := r.getClusterImageSet(cd, cdLog)
if err != nil {
cdLog.WithError(err).Error("failed to get cluster image set for the clusterdeployment")
return reconcile.Result{}, err
}
releaseImage := r.getReleaseImage(cd, imageSet, cdLog)
cdLog.Debug("loading pull secrets")
pullSecret, err := r.mergePullSecrets(cd, cdLog)
if err != nil {
cdLog.WithError(err).Error("Error merging pull secrets")
return reconcile.Result{}, err
}
// Update the pull secret object if required
switch updated, err := r.updatePullSecretInfo(pullSecret, cd, cdLog); {
case err != nil:
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "Error updating the merged pull secret")
return reconcile.Result{}, err
case updated:
// The controller will not automatically requeue the cluster deployment
// since the controller is not watching for secrets. So, requeue manually.
return reconcile.Result{Requeue: true}, nil
}
// let's verify the release image before using it here.
if r.releaseImageVerifier != nil {
var releaseDigest string
if index := strings.LastIndex(releaseImage, "@"); index != -1 {
releaseDigest = releaseImage[index+1:]
}
cdLog.WithField("releaseImage", releaseImage).
WithField("releaseDigest", releaseDigest).Debugf("verifying the release image using %s", r.releaseImageVerifier)
err := r.releaseImageVerifier.Verify(context.TODO(), releaseDigest)
if err != nil {
cdLog.WithField("releaseImage", releaseImage).
WithField("releaseDigest", releaseDigest).
WithError(err).Error("Verification of release image failed")
return reconcile.Result{}, r.updateCondition(cd, hivev1.InstallImagesNotResolvedCondition, corev1.ConditionTrue, "ReleaseImageVerificationFailed", err.Error(), cdLog)
}
}
switch result, err := r.resolveInstallerImage(cd, releaseImage, cdLog); {
case err != nil:
return reconcile.Result{}, err
case result != nil:
return *result, nil
}
if !r.expectations.SatisfiedExpectations(request.String()) {
cdLog.Debug("waiting for expectations to be satisfied")
return reconcile.Result{}, nil
}
switch {
case cd.Spec.Provisioning != nil:
// Ensure the install config matches the ClusterDeployment:
// TODO: Move with the openshift-installer ClusterInstall code when we implement https://issues.redhat.com/browse/HIVE-1522
if cd.Spec.Provisioning.InstallConfigSecretRef == nil {
cdLog.Info("install config not specified")
conditions, changed := controllerutils.SetClusterDeploymentConditionWithChangeCheck(
cd.Status.Conditions,
hivev1.RequirementsMetCondition,
corev1.ConditionFalse,
"InstallConfigRefNotSet",
"Install config reference is not set",
controllerutils.UpdateConditionIfReasonOrMessageChange)
if changed {
cd.Status.Conditions = conditions
return reconcile.Result{}, r.Status().Update(context.TODO(), cd)
}
return reconcile.Result{}, nil
}
icSecret := &corev1.Secret{}
err = r.Get(context.Background(),
types.NamespacedName{
Namespace: cd.Namespace,
Name: cd.Spec.Provisioning.InstallConfigSecretRef.Name,
},
icSecret)
if err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "Error loading install config secret")
return reconcile.Result{}, err
}
err = ValidateInstallConfig(cd, icSecret.Data["install-config.yaml"])
if err != nil {
cdLog.WithError(err).Info("install config validation failed")
conditions, changed := controllerutils.SetClusterDeploymentConditionWithChangeCheck(
cd.Status.Conditions,
hivev1.RequirementsMetCondition,
corev1.ConditionFalse,
"InstallConfigValidationFailed",
err.Error(),
controllerutils.UpdateConditionIfReasonOrMessageChange)
if changed {
cd.Status.Conditions = conditions
return reconcile.Result{}, r.Status().Update(context.TODO(), cd)
}
return reconcile.Result{}, nil
}
// If we made it this far, RequirementsMet condition should be True:
//
// TODO: when https://github.com/openshift/hive/pull/1413 is implemented
// we'll want to remove this assumption as ClusterInstall implementations may
// later indicate their requirements are not met. Instead, we should explicitly clear
// the condition back to Unknown if we see our Reason set, but the problem is no longer
// present.
conditions, changed := controllerutils.SetClusterDeploymentConditionWithChangeCheck(
cd.Status.Conditions,
hivev1.RequirementsMetCondition,
corev1.ConditionTrue,
"AllRequirementsMet",
"All pre-provision requirements met",
controllerutils.UpdateConditionIfReasonOrMessageChange)
if changed {
cd.Status.Conditions = conditions
err = r.Status().Update(context.TODO(), cd)
if err != nil {
return reconcile.Result{}, err
}
}
return r.reconcileInstallingClusterProvision(cd, releaseImage, cdLog)
case cd.Spec.ClusterInstallRef != nil:
return r.reconcileInstallingClusterInstall(cd, cdLog)
default:
return reconcile.Result{}, errors.New("invalid provisioning configuration")
}
}
func (r *ReconcileClusterDeployment) reconcileInstallingClusterProvision(cd *hivev1.ClusterDeployment, releaseImage string, logger log.FieldLogger) (reconcile.Result, error) {
if cd.Status.ProvisionRef == nil {
return r.startNewProvision(cd, releaseImage, logger)
}
return r.reconcileExistingProvision(cd, logger)
}
func (r *ReconcileClusterDeployment) reconcileInstalledClusterProvision(cd *hivev1.ClusterDeployment, logger log.FieldLogger) (reconcile.Result, error) {
// delete failed provisions which are more than 7 days old
existingProvisions, err := r.existingProvisions(cd, logger)
if err != nil {
return reconcile.Result{}, err
}
r.deleteOldFailedProvisions(existingProvisions, logger)
logger.Debug("cluster is already installed, no processing of provision needed")
r.cleanupInstallLogPVC(cd, logger)
return reconcile.Result{}, nil
}
func (r *ReconcileClusterDeployment) reconcileInstallingClusterInstall(cd *hivev1.ClusterDeployment, logger log.FieldLogger) (reconcile.Result, error) {
ref := cd.Spec.ClusterInstallRef
gvk := schema.GroupVersionKind{
Group: ref.Group,
Version: ref.Version,
Kind: ref.Kind,
}
if err := r.watchClusterInstall(gvk, logger); err != nil {
logger.WithField("gvk", gvk.String()).WithError(err).Error("failed to watch for cluster install contract")
return reconcile.Result{}, err
}
return r.reconcileExistingInstallingClusterInstall(cd, logger)
}
func isDNSNotReadyConditionSet(cd *hivev1.ClusterDeployment) (bool, *hivev1.ClusterDeploymentCondition) {
dnsNotReadyCondition := controllerutils.FindClusterDeploymentCondition(cd.Status.Conditions, hivev1.DNSNotReadyCondition)
return dnsNotReadyCondition.Status == corev1.ConditionTrue &&
(dnsNotReadyCondition.Reason == dnsNotReadyReason || dnsNotReadyCondition.Reason == dnsNotReadyTimedoutReason),
dnsNotReadyCondition
}
// getReleaseImage looks for a a release image in clusterdeployment or its corresponding imageset in the following order:
// 1 - specified in the cluster deployment spec.images.releaseImage
// 2 - referenced in the cluster deployment spec.imageSet
func (r *ReconcileClusterDeployment) getReleaseImage(cd *hivev1.ClusterDeployment, imageSet *hivev1.ClusterImageSet, cdLog log.FieldLogger) string {
if cd.Spec.Provisioning != nil && cd.Spec.Provisioning.ReleaseImage != "" {
return cd.Spec.Provisioning.ReleaseImage
}
if imageSet != nil {
return imageSet.Spec.ReleaseImage
}
return ""
}
func (r *ReconcileClusterDeployment) getClusterImageSet(cd *hivev1.ClusterDeployment, cdLog log.FieldLogger) (*hivev1.ClusterImageSet, error) {
imageSetKey := types.NamespacedName{}
switch {
case cd.Spec.Provisioning != nil:
imageSetKey.Name = getClusterImageSetFromProvisioning(cd)
if imageSetKey.Name == "" {
return nil, nil
}
case cd.Spec.ClusterInstallRef != nil:
isName, err := getClusterImageSetFromClusterInstall(r.Client, cd)
if err != nil {
return nil, err
}
imageSetKey.Name = isName
default:
cdLog.Warning("clusterdeployment references no clusterimageset")
if err := r.setReqsMetConditionImageSetNotFound(cd, "unknown", true, cdLog); err != nil {
return nil, err
}
}
imageSet := &hivev1.ClusterImageSet{}
err := r.Get(context.TODO(), imageSetKey, imageSet)
if apierrors.IsNotFound(err) {
cdLog.WithField("clusterimageset", imageSetKey.Name).
Warning("clusterdeployment references non-existent clusterimageset")
if err := r.setReqsMetConditionImageSetNotFound(cd, imageSetKey.Name, true, cdLog); err != nil {
return nil, err
}
return nil, err
}
if err != nil {
cdLog.WithError(err).WithField("clusterimageset", imageSetKey.Name).
Error("unexpected error retrieving clusterimageset")
return nil, err
}
if err := r.setReqsMetConditionImageSetNotFound(cd, imageSetKey.Name, false, cdLog); err != nil {
return nil, err
}
return imageSet, nil
}
func (r *ReconcileClusterDeployment) statusUpdate(cd *hivev1.ClusterDeployment, cdLog log.FieldLogger) error {
err := r.Status().Update(context.TODO(), cd)
if err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "cannot update clusterdeployment status")
}
return err
}
const (
imagesResolvedReason = "ImagesResolved"
imagesResolvedMsg = "Images required for cluster deployment installations are resolved"
)
func (r *ReconcileClusterDeployment) resolveInstallerImage(cd *hivev1.ClusterDeployment, releaseImage string, cdLog log.FieldLogger) (*reconcile.Result, error) {
areImagesResolved := cd.Status.InstallerImage != nil && cd.Status.CLIImage != nil
jobKey := client.ObjectKey{Namespace: cd.Namespace, Name: imageset.GetImageSetJobName(cd.Name)}
jobLog := cdLog.WithField("job", jobKey.Name)
existingJob := &batchv1.Job{}
switch err := r.Get(context.Background(), jobKey, existingJob); {
// The job does not exist. If the images have been resolved, continue reconciling. Otherwise, create the job.
case apierrors.IsNotFound(err):
if areImagesResolved {
return nil, r.updateCondition(cd, hivev1.InstallImagesNotResolvedCondition, corev1.ConditionFalse, imagesResolvedReason, imagesResolvedMsg, cdLog)
}
job := imageset.GenerateImageSetJob(cd, releaseImage, controllerutils.InstallServiceAccountName,
os.Getenv("HTTP_PROXY"),
os.Getenv("HTTPS_PROXY"),
os.Getenv("NO_PROXY"))
cdLog.WithField("derivedObject", job.Name).Debug("Setting labels on derived object")
job.Labels = k8slabels.AddLabel(job.Labels, constants.ClusterDeploymentNameLabel, cd.Name)
job.Labels = k8slabels.AddLabel(job.Labels, constants.JobTypeLabel, constants.JobTypeImageSet)
if err := controllerutil.SetControllerReference(cd, job, r.scheme); err != nil {
cdLog.WithError(err).Error("error setting controller reference on job")
return nil, err
}
jobLog.WithField("releaseImage", releaseImage).Info("creating imageset job")
err = controllerutils.SetupClusterInstallServiceAccount(r, cd.Namespace, cdLog)
if err != nil {
cdLog.WithError(err).Log(controllerutils.LogLevel(err), "error setting up service account and role")
return nil, err
}
if err := r.Create(context.TODO(), job); err != nil {
jobLog.WithError(err).Log(controllerutils.LogLevel(err), "error creating job")
return nil, err
}
// kickstartDuration calculates the delay between creation of cd and start of imageset job
kickstartDuration := time.Since(cd.CreationTimestamp.Time)
cdLog.WithField("elapsed", kickstartDuration.Seconds()).Info("calculated time to imageset job seconds")
metricImageSetDelaySeconds.Observe(float64(kickstartDuration.Seconds()))
return &reconcile.Result{}, nil
// There was an error getting the job. Return the error.
case err != nil:
jobLog.WithError(err).Error("cannot get job")
return nil, err
// The job exists and is in the process of getting deleted. If the images were resolved, then continue reconciling.
// If the images were not resolved, requeue and wait for the delete to complete.
case !existingJob.DeletionTimestamp.IsZero():
if areImagesResolved {
return nil, r.updateCondition(cd, hivev1.InstallImagesNotResolvedCondition, corev1.ConditionFalse, imagesResolvedReason, imagesResolvedMsg, cdLog)
}
jobLog.Debug("imageset job is being deleted. Will recreate once deleted")
return &reconcile.Result{RequeueAfter: defaultRequeueTime}, err
// If job exists and is finished, delete it. If the images were not resolved, then the job will be re-created.
case controllerutils.IsFinished(existingJob):
jobLog.WithField("successful", controllerutils.IsSuccessful(existingJob)).
Warning("Finished job found. Deleting.")
if err := r.Delete(
context.Background(),
existingJob,
client.PropagationPolicy(metav1.DeletePropagationForeground),
); err != nil {
jobLog.WithError(err).Log(controllerutils.LogLevel(err), "cannot delete imageset job")
return nil, err
}