Installer fails to lint manifest before proceeding

[brianredbeard]

Version

$ openshift-install version
0.9.1

Platform (aws|libvirt|openstack):

aws

What happened?

The openshift installer fails to lint the install config before generating terraform manifests. This leads to a condition where incorrect manifests will be generated which will fail if an attempt is made to use them.

[bharrington@leviathan OPENSHIFT.lVLL]$ ls -l
total 244756
-rw-r--r--. 2 bharrington bharrington      1656 Jan  8 13:15 install-config.yaml
-rwxrwxr-x. 3 bharrington bharrington 250621547 Jan  7 13:14 openshift-install-linux-amd64
[bharrington@leviathan OPENSHIFT.lVLL]$ AWS_PROFILE=product-installer ./openshift-install-linux-amd64 create manifests 
INFO Consuming "Install Config" from target directory 
[bharrington@leviathan OPENSHIFT.lVLL]$ ls -l
total 244760
drwxr-xr-x. 2 bharrington bharrington      4096 Jan  8 13:20 manifests
drwxr-xr-x. 2 bharrington bharrington      4096 Jan  8 13:21 openshift
-rwxrwxr-x. 3 bharrington bharrington 250621547 Jan  7 13:14 openshift-install-linux-amd64
[bharrington@leviathan OPENSHIFT.lVLL]$ AWS_PROFILE=product-installer ./openshift-install-linux-amd64 create cluster 
WARNING     Discarding the "Common Manifests" that was provided in the target directory because its dependencies are dirty and it needs to be regenerated 
WARNING     Discarding the "Openshift Manifests" that was provided in the target directory because its dependencies are dirty and it needs to be regenerated 
INFO Consuming "Network Config" from target directory 
INFO Consuming "Common Manifests" from target directory 
INFO Consuming "Ingress Config" from target directory 
INFO Consuming "Openshift Manifests" from target directory 
INFO Consuming "DNS Config" from target directory 
INFO Creating cluster...                          
ERROR                                              
ERROR Error: module.vpc.aws_vpc.new_vpc: expected cidr_block to contain a valid network CIDR, expected 192.168.128.0/20, got 192.168.132.0/20 
ERROR                                              
ERROR                                              
ERROR Failed to read tfstate: open /tmp/openshift-install-384405890/terraform.tfstate: no such file or directory 
FATAL failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply using Terraform 

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Attempt to perform a create manifests with the following install-config.yaml, then perform a create cluster.

baseDomain: os4.rvu.io
clusterID: 705ce3c3-fd29-4576-becd-cbf0ca14ba56
machines:
- name: master
  platform: {}
  replicas: 3
- name: worker
  platform: {}
  replicas: 3
metadata:
  creationTimestamp: null
  name: e652b42c
networking:
  clusterNetworks:
  - cidr: 10.128.0.0/14
    hostSubnetLength: 9
  serviceCIDR: 172.30.0.0/16
  type: OpenshiftSDN
platform:
  aws:
    region: us-west-2
    vpcCIDRBlock: 192.168.132.0/20
pullSecret: ''
sshKey: |
  ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDVUVfmNA8ybrjfBMJQrJS2stImcGdaiWSAdkCnVi0urbRwChnREhndrCueMyQwUeofzZuyCZAQ323QSAEussO+H5vSgCT+lM93oeN7nays5Y9l3kaj3eJtDzSeJ7e7X0Bo//BO4xevO1PqlfplwPGXJgV61O/iRYP9EtkCXbgjO40IpD3knXw6De++fqSdKe6FPdWkjQTLvR8X558UXf+C4CaP8xMLbVsH+lIWdm4yRRn/RM+qjCUTQDPMPkEZy/gsL0P0HX1Ecx0FcoXSsVcLMed3HIQFXrw+MD2gLbQ3yWvKQO+EvD47TRwlU4WcuM/Ua3cC1R/eK2LlovPih8/pS8aeSQG+BRb/UhTf6gZfDTTUyM/SuYCM9RWMT0SS9SEuyo2q9WrOOQtu6ouLJHyYZMX7jbkuzmAEJDGtvfYzSC6vvHK8rOMdJgMujnqHmV2JoUbubkivE8pcJQYcH1MzCoeNMqzzBHocJCJ/aqDPNbyselB3BeiCjgIIoI6naZBrQCFotD5mH+VC394IL36T1lfgu4gJMaPORqP4GM+DyZMcndz3LSV5zxfVJrVsamGoKAZgNlOVw+AbBf0L/+c7xfeXKT+JT/lVXdSanjhWYCcQla6oHvi+MxZO4lfGjaBXXLssxDf9+O5ikZ/5fMnffog4xJlMte12JN98idKGjw==

Related to:

• Installer prematurely removes install manifest #1022
• Installer ignores file permissions and deletes local resources #1011
• RFE: preserve install-config.yml #898