Fix error handling of status controller

openshift · Apr 13, 2020 · e43e3d5 · e43e3d5
1 parent d3cb092
commit e43e3d5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/operator/status/status_controller.go b/pkg/operator/status/status_controller.go
@@ -142,8 +142,8 @@ func (c StatusSyncer) Sync(ctx context.Context, syncCtx factory.SyncContext) err
 		if equality.Semantic.DeepEqual(clusterOperatorObj, originalClusterOperatorObj) {
 			return nil
 		}
-		if _, updateErr := c.clusterOperatorClient.ClusterOperators().UpdateStatus(ctx, clusterOperatorObj, metav1.UpdateOptions{}); err != nil {
-			return updateErr
+		if _, err := c.clusterOperatorClient.ClusterOperators().UpdateStatus(ctx, clusterOperatorObj, metav1.UpdateOptions{}); err != nil {
+			return err
 		}
 		syncCtx.Recorder().Eventf("OperatorStatusChanged", "Status for operator %s changed: %s", c.clusterOperatorName, configv1helpers.GetStatusDiff(originalClusterOperatorObj.Status, clusterOperatorObj.Status))
 		return nil