Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider id is not set correctly when using PowerVSMachineProviderConfig.ServiceInstance #15

Closed
Karthik-K-N opened this issue Apr 6, 2022 · 0 comments · Fixed by #16

Comments

@Karthik-K-N
Copy link
Member

Karthik-K-N commented Apr 6, 2022

When the machine is created by supplying ServiceInstance.ID or Name, The machine provider id the serviceinstance will be empty

For example:
Expected format: ibmpowervs://region/zone/service_instance_id/powervs_machine_id
Actual format: ibmpowervs://region/zone//powervs_machine_id

Add a check to validate non empty service instance id before forming a ProviderID

Reference:

providerID := client.FormatProviderID(r.powerVSClient.GetRegion(), r.powerVSClient.GetZone(), r.providerSpec.ServiceInstanceID, *instance.PvmInstanceID)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant