Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor embedded services to service interface and manager #161

Closed
fzdarsky opened this issue Jul 15, 2021 · 5 comments
Closed

Refactor embedded services to service interface and manager #161

fzdarsky opened this issue Jul 15, 2021 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@fzdarsky
Copy link
Contributor

With #152 and #153 we've started restructuring MicroShift such that embedded services (etcd, kube-apiserver, etc.) have their logic self-contained (one file per service), conform to a common Service interface, and using a service manager to implement startup dependencies and cancellation consistently.

So far, only etcd and kube-apiserver have been migrated over. We need all other components to be migrated, too:

  • kube-controller-manager
  • kube-scheduler
  • openshift-preparation (namespaces, SCCs, CRDs, etc.)
  • openshift-apiserver
  • openshift-controller-manager
  • kubelet
  • kubeproxy
  • component-loader (see Optionally start OpenShift components #144)

Services can likely be migrated over one-by-one in multiple PRs / by multiple people.

@fzdarsky fzdarsky added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 15, 2021
@fzdarsky
Copy link
Contributor Author

Note that some services currently hardcode the SIGTERM signal handler to the stop channel in the upstream code and that patches in /hack/patches patch out from our vendored packages. When refactoring kube-scheduler, kube-controller-manager, and klusterlet (following the example of kube-apiserver), please therefore ensure to test without those patches applied (see also #163).

@oglok
Copy link
Contributor

oglok commented Aug 4, 2021

I will work on porting the kube-scheduler to the new service manager framework.

@sallyom
Copy link
Contributor

sallyom commented Aug 6, 2021

I'll work on porting kube-controller-manager let's see how far I get b4 PTO

@husky-parul
Copy link
Contributor

I will work on porting the kube-scheduler to the new service manager framework.

Oh I assigned that to myself. I will un-assign myself. Feel free to take it #199

@fzdarsky
Copy link
Contributor Author

fzdarsky commented Feb 3, 2022

Addressed by #199, #200, #201, #229, #239.

@fzdarsky fzdarsky closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants