Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the kubernetes.io/os selector too #46

Open
aleskandro opened this issue Feb 27, 2024 · 2 comments
Open

Add the kubernetes.io/os selector too #46

aleskandro opened this issue Feb 27, 2024 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@aleskandro
Copy link
Member

In the future, it might be good for us to include the OS matchExpression too.
it is a good piece of information that is also worth considering for the scheduler predicates.

For example, windows container images shouldn't "risk" landing into a linux node.

The current official recommendation (for OCP) is to leverage runtime classes that instruct the scheduler as a kind of 'side-effect'/additional feature, so it's just a "possible" future thing that we can onboard for free to consider better the platform information in the manifest list images we inspect

xref #44 (comment)

@Prashanth684
Copy link
Contributor

Prashanth684 commented Feb 29, 2024

As we do more additions like this, we should start thinking when we want to expose our features with opt-in flags or options in the CR rather than doing it implicitly under the covers, like something along the lines of:

affinitySelector:
     - architecture
     - osType
     - custom

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants