Changing the way external endpoint IP/Port being propagated

[aruniiird]

Previously external cluster's monitoring endpoints were attached to
Reconcile object's variables and passed to other parts of the code.

Now, we are retrieving the Monitoring endpoint details, directly from
the external cluster secret, while creating the CephCluster and do all
the verifications.

Signed-off-by: Arun Kumar Mohan amohan@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jarrpa after the PR has been reviewed.
You can assign the PR to them by writing /assign @jarrpa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @aruniiird. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aruniiird]

Removing the WIP. Tested the changes on the external cluster and the monitoring spec is propagated (from OCS Operator) to CephCluster CR.
@jarrpa , @umangachapagain please take a look.

[umangachapagain]

/ok-to-test

[umangachapagain]

@aruniiird What's the difference between this and #1286? Most changes look similar.

[jarrpa]

...I see what's going on, #1286 is based on this PR. @aruniiird can you confirm whether this is the case? If there's no way to split the dependency between these two PRs, let's close this one and focus on #1286.

[openshift-ci]

@aruniiird: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jarrpa]

For the sake of expediency, I'm going to close this PR in favor of #1286 which seems to include this PR's commit anyway. If separate PRs are really needed we can open this back up.