Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"odo service create" works in non-interactive mode without any context, app or project values #2051

Closed
dharmit opened this issue Aug 28, 2019 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo

Comments

@dharmit
Copy link
Member

dharmit commented Aug 28, 2019

[kind/bug]

What versions of software are you using?

  • Operating System: All
  • Output of odo version: master

How did you run odo exactly?

Actual behavior

  • Service gets created in the application app and project myproject as those are the default values

Expected behavior

  • To be discussed.

Any logs, error output, etc?

openshift-merge-robot pushed a commit that referenced this issue Aug 29, 2019
* Adds `--context` flag to `odo service create` command

* Adds tests for 'odo service --context'

* Adds `--context` flag to service list and delete commands

This was not a part of any issue or bug or feature request but just made
sense to add it since we're adding `--context` flag to `odo service
create` command.

* Modified tests for service create and added those for service list and delete

* Adds test for failure to create service using non-component directory with --context flag

* Changes as per Amit's feedback

#1997 (review)

* Remove the context flag from test for it to fail as expected

* Remove a test in favour of opening the issue #2051
@girishramnani girishramnani added area/service kind/bug Categorizes issue or PR as related to a bug. labels Dec 26, 2019
@dharmit
Copy link
Member Author

dharmit commented Jan 6, 2020

Closing this since it's a helpful side-effect. 😉

@dharmit dharmit closed this as completed Jan 6, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Development

No branches or pull requests

3 participants