Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo service create doesn't honor parameters #2069

Closed
VeerMuchandi opened this issue Aug 30, 2019 · 4 comments
Closed

odo service create doesn't honor parameters #2069

VeerMuchandi opened this issue Aug 30, 2019 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo

Comments

@VeerMuchandi
Copy link

[kind/bug]

What versions of software are you using?

  • Operating System:
  • Output of odo version:
$ odo version
odo v1.0.0-beta4 (d11517f1)

How did you run odo exactly?

odo service create mongodb-ephemeral mongodb -p DATABASE_SERVICE_NAME=mongodb -p MONGODB_USER=user -p MONGODB_PASSWORD=password -p MONGODB_DATABASE=todos -p MONGODB_ADMIN_PASSWORD=password

The result of the above command creates a database along with a secret mongodb. If you reveal the secret values they are different (only uses defaults and ignores supplied parameters). I also tried to use params comma separated. No difference.

Compare this with

oc new-app --template=mongodb-ephemeral \
--param=DATABASE_SERVICE_NAME=mongodb \
--param=MONGODB_USER=user \
--param=MONGODB_PASSWORD=password \
--param=MONGODB_DATABASE=todos \
--param=MONGODB_ADMIN_PASSWORD=password

which creates the secret mongodb with the values you want.

Actual behavior

odo not using the values supplied as parameters

Expected behavior

odo should create secret using parameters supplied

Any logs, error output, etc?

@kadel
Copy link
Member

kadel commented Sep 2, 2019

This looks like duplicate of #2033

@dharmit
Copy link
Member

dharmit commented Sep 4, 2019

I think it's not an exact dupe because the parameters will be accessible/visible under the "Environment" tab on OpenShift console and not stored as a secret as mentioned in "Expected behavior". AFAIK, this is true even when setting the parameters using interactive mode of odo service create.

@kadel
Copy link
Member

kadel commented Sep 4, 2019

@dharmit the Secret is created automatically by Service Broker. It doesn't matter if you call it using oc or odo. This is auto of clients control.

The problem was that odo didn't pass the parameters to ServiceInstance. This got fixed in #2040

You will be always able to read Secret values in OpenShift console.

@girishramnani girishramnani added area/service kind/bug Categorizes issue or PR as related to a bug. labels Dec 26, 2019
@girishramnani
Copy link
Contributor

as per @kadel comment it seems this is a duplicate. Closing

@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Development

No branches or pull requests

5 participants