Refactor machine output to use machineoutput/types.go

[cdrage]

[kind/Enhancement]

Which functionality do you think we should update/improve?

The below code:

    storageListResultMachineReadable := storage.GetMachineReadableFormatForList(storageListMachineReadable)
  
    if log.IsJSON() {
      out, err := json.Marshal(storageListResultMachineReadable)
      if err != nil {
        return err 
      }   
      fmt.Println(string(out))

Is used throughout odo (https://github.com/openshift/odo/search?q=json.Marshal&unscoped_q=json.Marshal).

This should instead use what we have within: https://github.com/openshift/odo/blob/master/pkg/machineoutput/types.go

Why is this needed?

Clean up / stability

[kadel]

This is not a good design. We already have structs representing most of the stuff that will be returned in machine-readable outputs. like components/types.go and url/types.go.

Odo should internally work with structures defined there, and the same structs should also be outputted as jsons.
The only exception should be if we need to return something that is not representations of odo object, like when the operation fails or deletion is successful.
If the operation is listing, or getting info about odo object (project, app, component..) it should always use structs in types.go inside the packages representing a given object.

[cdrage]

Bit confused @kadel

What I mean is removing the json.Marshal statements for:

https://github.com/openshift/odo/blob/master/pkg/machineoutput/types.go#L34

Which is simply a wrapper around json.Marshal instead of having to copy/paste json.Marshal code everwhere :)

[kadel]

OH, right. So you mean replacing every occurrence json.Marshal that is outside of machineoutput.OutputSuccess with machineoutput.OutputSuccess, right? That makes sense.

[cdrage]

@kadel Yup! Exactly.

[kadel]

/unassign @cdrage
/area json-output

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[cdrage]

I've refactored this as much as I could 👍 I think we can close this for now.