Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo url create for component ("odo url create --component") creates url for component in pwd #2174

Closed
dharmit opened this issue Sep 25, 2019 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo

Comments

@dharmit
Copy link
Member

dharmit commented Sep 25, 2019

[kind/bug]

What versions of software are you using?

  • Operating System: all
  • Output of odo version: master

How did you run odo exactly?

  1. Created two components and pushed them
    $ odo list
    APP     NAME       TYPE       SOURCE        STATE
    app     django     python     file://./     Pushed
    app     nodejs     nodejs     file://./     Pushed
  2. Created url for django component from the component directory of nodejs component
    $ odo url create --component django
     ✓  URL django-8080 created for component: django
    
    To create URL on the OpenShift Cluster, please use `odo push`
    
    $ odo url list
    Found the following URLs for component nodejs in application app:
    NAME            STATE          URL     PORT
    django-8080     Not Pushed     ://     8080
    
    There are local changes. Please run 'odo push'.
    
    $ pwd
    /home/dshah/src/nodejs-ex
  3. Upon doing odo push, the url create above redirects to the application in nodejs component.
  4. But using --context flag with odo url create --component produces expected results
    $ odo url create django-url --component django --context ~/src/django-ex
     ✓  URL django-url created for component: django
    
    To create URL on the OpenShift Cluster, please use `odo push`
    nodejs-ex - master! $ odo push --context ~/src/django-ex
    
    $ pwd
    /home/dshah/src/nodejs-ex

Actual behavior

Creating a url for a component while executing command from a directory belonging to different component yields a url for latter rather than former.

Expected behavior

  • odo url create -h should mention that --component needs a --context flag.
    OR
  • odo url create -h should mention that the component in pwd will be adhered to instead of the name provided to --component flag.

Any logs, error output, etc?

@girishramnani girishramnani added area/url kind/bug Categorizes issue or PR as related to a bug. and removed area/debug labels Dec 18, 2019
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2020
@dharmit
Copy link
Member Author

dharmit commented Apr 2, 2020

/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2020
@girishramnani
Copy link
Contributor

Is this issue still happening @dharmit ?

@dharmit
Copy link
Member Author

dharmit commented Apr 7, 2020

This now works as expected.

@dharmit dharmit closed this as completed Apr 7, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Development

No branches or pull requests

5 participants