Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the local config after component creation #2439

Closed
amitkrout opened this issue Dec 9, 2019 · 3 comments · Fixed by #2457
Closed

Verify the local config after component creation #2439

amitkrout opened this issue Dec 9, 2019 · 3 comments · Fixed by #2457
Assignees
@prietyc123
Labels
estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person
Projects
Sprint 177

Comments

@amitkrout
Copy link
Contributor

amitkrout commented Dec 9, 2019 •
edited

/kind bug

What versions of software are you using?

Operating System:
Supported
Output of odo version:
master

How did you run odo exactly?

No validation is done for local config file created by odo component create ... command. Part of #2256

NOTE: This is not same as validating the local config through odo config view command

Actual behavior

No yaml level validation is done for component local config

Expected behavior

The config.yaml created by odo create ... should be verified through a function let say func verifyLocalConfig (ConfigPath string, args ...string) bool {}

Any logs, error output, etc?
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 9, 2019
@amitkrout
Copy link
Contributor Author

/area testing

@openshift-ci-robot openshift-ci-robot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Dec 9, 2019
@amitkrout
Copy link
Contributor Author

/assign @prietyc123

@amitkrout amitkrout mentioned this issue Dec 9, 2019
Closed
@kadel
Copy link
Member

kadel commented Dec 10, 2019

/remove-kind bug
/unassign @prietyc123

@openshift-ci-robot openshift-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Dec 10, 2019
@prietyc123 prietyc123 mentioned this issue Dec 13, 2019
Merged
@kadel kadel added this to For consideration in Sprint 177 via automation Dec 16, 2019
@kadel kadel moved this from For consideration to Ready for review in Sprint 177 Dec 16, 2019
@kadel kadel moved this from Ready for review to In progress in Sprint 177 Dec 16, 2019
@kadel kadel added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Dec 18, 2019
@girishramnani girishramnani added area/config and removed area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Jan 3, 2020
@girishramnani girishramnani moved this from In progress to Ready for review in Sprint 177 Jan 6, 2020
Sprint 177 automation moved this from Ready for review to Done Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prietyc123 prietyc123

Labels
estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person
Projects
No open projects
Sprint 177
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify local config after component create prietyc123/odo
5 participants
@kadel @girishramnani @amitkrout @openshift-ci-robot @prietyc123