Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of platform specific file separator in tests #2523

Closed
girishramnani opened this issue Jan 21, 2020 · 1 comment · Fixed by #2524
Closed

Use of platform specific file separator in tests #2523

girishramnani opened this issue Jan 21, 2020 · 1 comment · Fixed by #2524
Assignees
@prietyc123
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug.

Comments

@girishramnani
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System: Fedora

Output of odo version: master

Description

It seems some of our tests are using platform specific file separator e.g. https://github.com/openshift/odo/blob/master/tests/integration/cmd_push_test.go#L48
https://github.com/openshift/odo/blob/master/tests/integration/cmd_push_test.go#L123 and more

We should resolve this to run these tests on windows someday
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 21, 2020
@girishramnani girishramnani added kind/test area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering and removed kind/test labels Jan 21, 2020
@girishramnani
Copy link
Contributor Author

this one too https://github.com/openshift/odo/blob/master/tests/integration/cmd_push_test.go#L228

@prietyc123 prietyc123 mentioned this issue Jan 21, 2020
Merged
@prietyc123 prietyc123 self-assigned this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prietyc123 prietyc123

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolved platfrom specific file separator in test prietyc123/odo
3 participants
@girishramnani @openshift-ci-robot @prietyc123