Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devfile support for odo delete #2591

Closed
4 tasks
elsony opened this issue Feb 11, 2020 · 8 comments · Fixed by #2763
Closed
4 tasks

devfile support for odo delete #2591

elsony opened this issue Feb 11, 2020 · 8 comments · Fixed by #2763
Assignees
@mik-dass
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind
Projects
Sprint 182

Comments

@elsony
Copy link

elsony commented Feb 11, 2020 •
edited

Related to #2470

User Story

As a user, I want to be able delete the devfile components that I have created before so that it will do all the necessary cleanup.

Acceptance Criteria

  • odo delete command should delete the devfile component that has been created before.
  • it should behave similar to the existing odo delete command
  • delete will do all the necessary clean up as needed, e.g. containers, etc.
  • this code path will only be triggered when EXPERIMENTAL flag has been enabled

/kind user-story
/area devfile
@openshift-ci-robot openshift-ci-robot added kind/user-story An issue of user-story kind area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Feb 11, 2020
@yangcao77
Copy link
Contributor

/assign

@girishramnani girishramnani added this to For consideration in Sprint 180 via automation Feb 12, 2020
@elsony elsony moved this from For consideration to To do in Sprint 180 Feb 14, 2020
@elsony elsony added this to For consideration in Sprint 181 via automation Mar 6, 2020
@elsony elsony removed this from To do in Sprint 180 Mar 6, 2020
@girishramnani girishramnani assigned mik-dass and unassigned yangcao77 Mar 12, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 181 Mar 12, 2020
@mik-dass
Copy link
Contributor

mik-dass commented Mar 18, 2020 •
edited

@elsony @kadel @girishramnani Should this command delete the env folder and the devfile itself? Or should it just delete the env folder and keep the devfile?

@girishramnani
Copy link
Contributor

girishramnani commented Mar 19, 2020 •
edited

I would suggest we follow the same as we do for odo delete now i.e. the cluster side resources on odo delete and odo delete --all should delete cluster resources + local resources like devfile and the env folder

@kadel
Copy link
Member

kadel commented Mar 19, 2020

I would suggest we follow the same process of delete the cluster side resources on odo delete and odo delete --all should delete local resources like devfile and the env folder

yes for env folder, that should be deleted with odo delete --all.
Not so sure about devfile :-( devfile.yaml could be created by something else than odo, and in that case, user won't expect that it will get deleted by odo command.

@girishramnani
Copy link
Contributor

well then lets keep devfile in its place and if someone requests for it be removed we can add a follow up PR

@elsony
Copy link
Author

elsony commented Mar 23, 2020 •
edited

+1 on keeping the devfile. I'd consider the devfile to be part of the user resource after it has been created. Therefore, we'll never delete that even on a odo delete --all.

@mik-dass mik-dass mentioned this issue Mar 26, 2020
Merged
@mik-dass mik-dass moved this from To do to In progress in Sprint 181 Mar 27, 2020
@mik-dass mik-dass moved this from In progress to For review in Sprint 181 Mar 27, 2020
@elsony
Copy link
Author

elsony commented Mar 27, 2020

@mik-dass This items has been marked for review but the corresponding PR #2763 is still marked as WIP. Do you think this story will be able to make Sprint 181?

@mik-dass
Copy link
Contributor

mik-dass commented Mar 30, 2020 •
edited

@mik-dass This items has been marked for review but the corresponding PR #2763 is still marked as WIP. Do you think this story will be able to make Sprint 181?

Yes it's ready for review. Once the CI is green and the integration tests are added, I will remove the WIP status.

@girishramnani girishramnani added this to For consideration in Sprint 182 via automation Mar 30, 2020
@girishramnani girishramnani removed this from For review in Sprint 181 Mar 30, 2020
@girishramnani girishramnani moved this from For consideration to For review in Sprint 182 Mar 30, 2020
@girishramnani girishramnani moved this from For review to In progress in Sprint 182 Mar 30, 2020
@mik-dass mik-dass moved this from In progress to For review in Sprint 182 Mar 31, 2020
Sprint 182 automation moved this from For review to Done Apr 8, 2020
@mik-dass mik-dass mentioned this issue May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mik-dass mik-dass

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind
Projects
No open projects
Sprint 182
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds delete function for devfiles support. mik-dass/odo
6 participants
@kadel @girishramnani @elsony @mik-dass @yangcao77 @openshift-ci-robot