Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--app information not included in generated non-interactive command #2696

Closed
jdob opened this issue Mar 10, 2020 · 1 comment · Fixed by #2708
Closed

--app information not included in generated non-interactive command #2696

jdob opened this issue Mar 10, 2020 · 1 comment · Fixed by #2708
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects

Comments

@jdob
Copy link

jdob commented Mar 10, 2020

/kind bug

What versions of software are you using?

Fedora 31
odo v1.1.0 (86c7e2c)
Server: https://api.crc.testing:6443
Kubernetes: v1.14.6+17b1cc6

How did you run odo exactly?

$ odo service create --app concessions
? Which kind of service do you wish to create database
? Which database service class should we use mongodb-ephemeral
? Enter a value for string property DATABASE_SERVICE_NAME (Database Service Name): mongodb
? Enter a value for string property MEMORY_LIMIT (Memory Limit): 512Mi
? Enter a value for string property MONGODB_DATABASE (MongoDB Database Name): sampledb
? Enter a value for string property MONGODB_VERSION (Version of MongoDB Image): 3.6
? Provide values for non-required properties No
? How should we name your service database
? Output the non-interactive version of the selected options Yes
? Wait for the service to be ready Yes
Deploying service database of type: mongodb-ephemeral
✓ Deploying service [27ms]
✓ Waiting for service to come up [1m]
✓ Service 'database' is ready for use
Optionally, link mongodb-ephemeral to your component by running: 'odo link '
Equivalent command:
odo service create mongodb-ephemeral database --plan default -p DATABASE_SERVICE_NAME=mongodb -p MEMORY_LIMIT=512Mi -p MONGODB_DATABASE=sampledb -p MONGODB_VERSION=3.6

Actual behavior

Outputted odo service command does not include the --app flag and won't recreate the service completely.

Expected behavior

The --app flag should be included in the equivalent command:

odo service create mongodb-ephemeral database --plan default -p DATABASE_SERVICE_NAME=mongodb -p MEMORY_LIMIT=512Mi -p MONGODB_DATABASE=sampledb -p MONGODB_VERSION=3.6 --app concessions

Any logs, error output, etc?

Nope

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 10, 2020
@girishramnani
Copy link
Contributor

it seems the --project is also not shown in the equivalent command when provided

@girishramnani girishramnani added this to For consideration in Sprint 181 via automation Mar 11, 2020
@girishramnani girishramnani self-assigned this Mar 12, 2020
@girishramnani girishramnani moved this from For consideration to For review in Sprint 181 Mar 12, 2020
Sprint 181 automation moved this from For review to Done Mar 17, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Sprint 181
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants