Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable CI run only for doc changes pr #2704

Closed
1 of 2 tasks
amitkrout opened this issue Mar 11, 2020 · 12 comments · Fixed by #2757 or openshift/release#14358
Closed
1 of 2 tasks

Disable CI run only for doc changes pr #2704

amitkrout opened this issue Mar 11, 2020 · 12 comments · Fixed by #2757 or openshift/release#14358
Assignees
@anandrkskd
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
Sprint 194

Comments

@amitkrout
Copy link
Contributor

amitkrout commented Mar 11, 2020 •
edited by anandrkskd

User Story

As a contributor i can send odo dev doc pr. I would expect CI should not run for doc as we are not building doc as part of CI run.

Acceptance Criteria

Doc pr should merge without involving the test run

Links

  • Feature Request: NA
  • Related issue: NA

/kind user-story
@openshift-ci-robot openshift-ci-robot added the kind/user-story An issue of user-story kind label Mar 11, 2020
@amitkrout amitkrout self-assigned this Mar 11, 2020
@amitkrout amitkrout added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Mar 11, 2020
@amitkrout amitkrout added this to For consideration in Sprint 181 via automation Mar 11, 2020
@girishramnani girishramnani added priority/Medium Nice to have issue. Getting it done before priority changes would be great. and removed priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Mar 11, 2020
@mohammedzee1000
Copy link
Contributor

For Travis https://docs.travis-ci.com/user/customizing-the-build/#skipping-a-build maybe?

cdrage added a commit to cdrage/odo that referenced this issue Mar 25, 2020
@cdrage
Add documentation to skip CI when pushing docs
225cdd2 
**What type of PR is this?**
/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

This improves pushing documentation changes by including `[skip ci]`
somewhere in the commit message in order to skip any Travis CI build
from running.

**Which issue(s) this PR fixes**:

Fixes redhat-developer#2704

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage mentioned this issue Mar 25, 2020
Merged
@cdrage cdrage assigned cdrage and unassigned amitkrout Mar 25, 2020
@cdrage cdrage moved this from For consideration to For review in Sprint 181 Mar 25, 2020
@girishramnani girishramnani removed this from For review in Sprint 181 Mar 30, 2020
@girishramnani girishramnani added this to For consideration in Sprint 182 via automation Mar 30, 2020
@girishramnani girishramnani moved this from For consideration to For review in Sprint 182 Mar 30, 2020
cdrage added a commit to cdrage/odo that referenced this issue Mar 30, 2020
@cdrage
Add documentation to skip CI when pushing docs
51530ba 
**What type of PR is this?**
/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

This improves pushing documentation changes by including `[skip ci]`
somewhere in the commit message in order to skip any Travis CI build
from running.

**Which issue(s) this PR fixes**:

Fixes redhat-developer#2704

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@girishramnani girishramnani added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Apr 1, 2020
@cdrage cdrage assigned amitkrout and unassigned cdrage Apr 6, 2020
Sprint 182 automation moved this from For review to Done Apr 9, 2020
openshift-merge-robot pushed a commit that referenced this issue Apr 9, 2020
@cdrage
Add documentation to skip CI when pushing docs (#2757)
04c5e50 
**What type of PR is this?**
/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

This improves pushing documentation changes by including `[skip ci]`
somewhere in the commit message in order to skip any Travis CI build
from running.

**Which issue(s) this PR fixes**:

Fixes #2704

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@amitkrout amitkrout reopened this May 14, 2020
@amitkrout
Copy link
Contributor Author

Skipping the test on OpenShift CI is still pending.

@amitkrout amitkrout added this to For consideration in Sprint 184 via automation May 14, 2020
@amitkrout amitkrout removed this from For consideration in Sprint 184 May 14, 2020
@amitkrout amitkrout added this to For consideration in Sprint 184 via automation May 14, 2020
@amitkrout amitkrout removed this from Done in Sprint 182 May 14, 2020
@amitkrout amitkrout moved this from For consideration to To do in Sprint 184 May 14, 2020
@amitkrout
Copy link
Contributor Author

amitkrout commented Jun 3, 2020 •
edited

@amitkrout please check the PRs where the docs change did trigger CI

#3218 and #3233 these are the two pr we recently hit the deviation.

ATM i am going to create a pr just for testing purpose to verify travis CI skip for doc changes only.

Now i found the issue why it was not working i mean CI skip in these above two examples because the [skip ci] message was added through the pr template not through the git commit message. Actually this looks counter intuitive as the user comes to know at the time of pr creation from the pr template. We should enforce it if pr has only doc changes in travis CI run.

In my test pr #3293 it works when i add [skip ci] through git commit message

Screen Shot 2020-06-03 at 9 39 32 PM

Screen Shot 2020-06-03 at 9 40 15 PM

@amitkrout amitkrout mentioned this issue Jun 3, 2020
Closed
@girishramnani girishramnani removed this from In progress in Sprint 185 Jun 22, 2020
@girishramnani girishramnani added this to For consideration in Sprint 186 via automation Jun 22, 2020
@girishramnani girishramnani moved this from For consideration to In progress in Sprint 186 Jun 22, 2020
@mohammedzee1000
Copy link
Contributor

I will be raising PR for using git commit shortly, to maintain uniform behavior

@mohammedzee1000 mohammedzee1000 moved this from In progress to To do in Sprint 186 Jul 9, 2020
@kadel kadel added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering and removed kind/test labels Jul 10, 2020
@girishramnani girishramnani removed this from To do in Sprint 186 Jul 13, 2020
@girishramnani girishramnani added this to For consideration in Sprint 187 via automation Jul 13, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 187 Jul 13, 2020
@girishramnani girishramnani removed this from To do in Sprint 187 Jul 13, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 26, 2020
@prietyc123 prietyc123 added this to For Consideration in Sprint 194 via automation Dec 4, 2020
@prietyc123 prietyc123 moved this from For Consideration to To Do in Sprint 194 Dec 4, 2020
@dharmit dharmit removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Dec 7, 2020
@anandrkskd
Copy link
Contributor

We can use run_if_changed, info about run_if_changed provided in doc.

For Prow we need use regex similar to provied here.

@anandrkskd anandrkskd mentioned this issue Dec 16, 2020
Merged
@anandrkskd anandrkskd moved this from To Do to In Progress in Sprint 194 Dec 23, 2020
Sprint 194 automation moved this from In Progress to Done Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anandrkskd anandrkskd

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
No open projects
Sprint 194
Done
Milestone
No milestone
9 participants
@kadel @dharmit @openshift-bot @cdrage @girishramnani @mohammedzee1000 @amitkrout @openshift-ci-robot @anandrkskd