[Devfile] odo catalog can't list components on non-OpenShift clusters

[johnmcollier]

/kind bug

What versions of software are you using?

odo from master

Operating System:
macOS

How did you run odo exactly?

1. Started Minikube
2. Enabled experimental mode
3. Ran odo catalog list components

odo reported the following error:

johns-mbp-3:odo johncollier$ ./odo catalog list components
 ✗  unable to list imagestreams: the server could not find the requested resource (get imagestreams.image.openshift.io).
unable to list imagestreams: the server could not find the requested resource (get imagestreams.image.openshift.io)

Now, this is happening since I'm not running on OpenShift and thus there are no imagestreams that can be retrieved. Since odo2 and its devfile support is Kube-generic, it should at least return the list of devfile components when running on a non-OpenShift cluster.

/kind bug
/area devfile

[johnmcollier]

This one's a little tricky:

• With experimental mode enabled, we can list both "odo classic" image stream components from OpenShift and devfile components,
• But we can only use devfile components when doing an odo push with experimental mode enabled.

So I think we've got at least a couple options:

1. Remove the error check from https://github.com/openshift/odo/blob/master/pkg/odo/cli/catalog/list/components.go#L45
   • A little risky if running on OpenShift and there's a legitimate issue getting the image streams
2. Only retrieve the devfile components when experimental mode is enabled, knowing that odo push with experimental mode currently only supports devfile components

[GeekArthur]

/assign