Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterHost is an incorrect parameter / term for url creation #2721

Closed
cdrage opened this issue Mar 13, 2020 · 4 comments · Fixed by #2762
Closed

ClusterHost is an incorrect parameter / term for url creation #2721

cdrage opened this issue Mar 13, 2020 · 4 comments · Fixed by #2762
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects

Comments

@cdrage
Copy link
Member

cdrage commented Mar 13, 2020

/kind feature

Which functionality do you think we should add?

--clusterHost should be --host for odo url create.

Why is this needed?

ClusterHost parameter for url creation is an incorrect parameter term.

The term Cluster Host in kubectl and oc is confusing because Cluster Host actually means Kubernetes / OpenShift "host".

It is confusing because we are specifying a domain name for url creation.. ex: odo url create --clusterHost example.domain.com

We should be using the correct term which would actually be host, which is exactly what OpenShift uses in the yaml creation for Route.

For example, the current code that is implemented looks like this:

				Host: ingressParam.IngressDomain,
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Mar 13, 2020
@cdrage
Copy link
Member Author

cdrage commented Mar 13, 2020

Ping @yangcao77 @kadel @GeekArthur

@yangcao77
Copy link
Contributor

/assign
/area devfile

@openshift-ci-robot openshift-ci-robot added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Mar 13, 2020
@yangcao77
Copy link
Contributor

yangcao77 commented Mar 18, 2020

The host we want user to specify is the cluster host, not the entire ingress domain.
If the ingress domain we want is example.domain.com, then the command should be
odo url create example --clusterHost domain.com
(ingressDomain = urlName.clusterHost)

If we don't want camel case in the command, the parameter can be simplified as host

@cdrage
Copy link
Member Author

cdrage commented Mar 18, 2020

"Cluster Host" is a different definition as "host" or ingress. "Cluster Host" is also not used at all within Kubernetes / OpenShift YAML.

If you want to define an ingress domain, it should just be host similar to Kubernetes / OpenShift YAML definitions.

I agree to switching it to just --host.

@elsony elsony added this to For consideration in Sprint 181 via automation Mar 27, 2020
@elsony elsony removed this from For consideration in Sprint 181 Mar 27, 2020
@elsony elsony added this to For consideration in Sprint 182 via automation Mar 27, 2020
@elsony elsony moved this from For consideration to For review in Sprint 182 Mar 31, 2020
Sprint 182 automation moved this from For review to Done Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
No open projects
Sprint 182
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants