Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo catalog list components should work without cluster #2740

Closed
kadel opened this issue Mar 20, 2020 · 5 comments · Fixed by #2749
Closed

odo catalog list components should work without cluster #2740

kadel opened this issue Mar 20, 2020 · 5 comments · Fixed by #2749
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. v2 Issue or PR that applies to the v2 of odo

Comments

@kadel
Copy link
Member

kadel commented Mar 20, 2020

It should be possible to list devfile components even if odo is not connected to the cluster

 export ODO_EXPERIMENTAL=true
▶ odo catalog list components
 ✗  unable to list imagestreams: Get "<url>": dial tcp <IP>:8443: connect: connection refused.
unable to list imagestreams: Get "<url>": dial tcp <IP>:8443: connect: connection refused

Instead of failing, odo can just show a warning that it can't connect to the cluster, and show just devfile components.

/kind bug
/priority low
/area devfile
/area catalog

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/catalog labels Mar 20, 2020
@johnmcollier
Copy link
Member

johnmcollier commented Mar 20, 2020

@kadel Agreed, we'll need this for Docker support in odo too.

@GeekArthur Your work for #2706 should fix this right?

@GeekArthur
Copy link
Contributor

@johnmcollier Yes, this issue is duplicate issue of #2706, and @kadel 's suggestion is same as my fix plan, we all good for this 🚀

@johnmcollier
Copy link
Member

One thing that I would add to this issue, is if PushTarget is set to Docker, maybe omit the message about not being able to connect to the cluster?

@GeekArthur
Copy link
Contributor

This is a comment from another issue

Only retrieve the devfile components when experimental mode is enabled, knowing that odo push with experimental mode currently only supports devfile components

If that's still the case, we can only list devfile components when we turn on Experimental flag since odo push with experimental mode currently only supports devfile components, that would make the devfile support features more consistent and avoid the generic error of connecting to the cluster including #2740 (comment)

@GeekArthur
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
5 participants