push failed with devfile without endpoinds

[kadel]

apiVersion: 1.0.0
metadata:
  name: java
components:
  - type: dockerimage
    alias: tools
    image: quay.io/eclipse/che-java11-maven:nightly
    memoryLimit: 512Mi
    mountSources: true
    volumes:
      - name: m2
        containerPath: /home/user/.m2
commands:
  - name: devBuild
    actions:
      - type: exec
        component: tools
        command: "mvn package"
  - name: devRun
    actions:
      - type: exec
        component: tools
        command: "java -jar target/*.jar"

▶ odo push
 •  Push devfile component demo-backend  ...
 ✗  Failed to start component with name demo-backend.
Error: Failed to create the component: unable to create or update component: unable to create Service for demo-backend: Service "demo-backend" is invalid: spec.ports: Required value

/kind bug
/priority high
/area devfile

[kadel]

ping @yangcao77

[johnmcollier]

I'm wondering... maybe if no endpoint is specified in the devfile, we should:

• Allow the user to specify a port during odo create via the existing --port flag (although we should support this even if there's an endpoint specified, so the user can override)
• Default to some default value otherwise (and warn the user?)

Thoughts?

[kadel]

I don't think that we need to do any of this. Devfile without endpoint is perfectly valid devfile, not every application need to have ports exposed.

[yangcao77]

/assign