Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning message gets printed multiple times #2782

Closed
mik-dass opened this issue Mar 31, 2020 · 4 comments · Fixed by #2836
Closed

Warning message gets printed multiple times #2782

mik-dass opened this issue Mar 31, 2020 · 4 comments · Fixed by #2836
Assignees
@cdrage
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Sprint 182

Comments

@mik-dass
Copy link
Contributor

/kind bug

How did you run odo exactly?

odo push

Actual behavior

[mrinaldas@localhost nodejs-ex]$ odo push
Validation
 ✓  Checking component [1s]

Configuration changes
 ✓  Initializing component
 ✓  Creating component [5s]

Pushing to component nodejs-nodejs-ex-nyyg of type local
 ✓  Checking files for pushing [715424ns]
 ◐  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◓  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◑  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◒  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◐  Waiting for component to start [⚠ WARNING x5: BackOff, use `-v` for more inf ◓  
^C

Waiting for component to start [⚠ WARNING x5: BackOff, use -vfor more inf ◓ gets printed again and again.

Expected behavior

Waiting for component to start [⚠ WARNING x5: BackOff, use -vfor more inf to be printed once
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 31, 2020
@cdrage cdrage self-assigned this Mar 31, 2020
@cdrage
Copy link
Member

cdrage commented Mar 31, 2020 •
edited

@mik-dass Is your terminal display really small? This is what may be causing the issue.. I may have to shorten the info / output). Can you re-run it with your terminal display wider?

@mik-dass
Copy link
Contributor Author

mik-dass commented Apr 1, 2020

@mik-dass Is your terminal display really small? This is what may be causing the issue.. I may have to shorten the info / output). Can you re-run it with your terminal display wider?

yes on a wider terminal, the duplication seems to be gone.

@girishramnani girishramnani added this to For consideration in Sprint 182 via automation Apr 2, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 182 Apr 2, 2020
@cdrage
Copy link
Member

cdrage commented Apr 6, 2020

@mik-dass Yup. That's normal. It's the terminal doing it's thing with regards to the spinner.

I do realize that the warning message is actually quite long, I'm going to push a PR to reduce the size to hopefully we don't have this occur again on smaller terminals.

@mik-dass
Copy link
Contributor Author

mik-dass commented Apr 7, 2020

I do realize that the warning message is actually quite long, I'm going to push a PR to reduce the size to hopefully we don't have this occur again on smaller terminals.

OK 👍

cdrage added a commit to cdrage/odo that referenced this issue Apr 7, 2020
@cdrage
Shortens warning output for event information
f04db38 
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind code-refactoring

**What does does this PR do / why we need it**:

Updates the warning output to have less information (remove the part
about using `-v` for more information).

This is needed in order to reduce the width of text so we don't run into
any issues with output being resized due to small terminals.

**Which issue(s) this PR fixes**:

Fixes redhat-developer#2782

**How to test changes / Special notes to the reviewer**:

Run it :)

```sh

git clone https://github.com/openshift/nodejs-ex
odo create node js
odo preference set PushTimeout

watch -n 1 oc delete pvc --all

odo push -f
```

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage mentioned this issue Apr 7, 2020
Merged
Sprint 182 automation moved this from To do to Done Apr 8, 2020
openshift-merge-robot pushed a commit that referenced this issue Apr 8, 2020
@cdrage
Shortens warning output for event information (#2836)
72bfc94 
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind code-refactoring

**What does does this PR do / why we need it**:

Updates the warning output to have less information (remove the part
about using `-v` for more information).

This is needed in order to reduce the width of text so we don't run into
any issues with output being resized due to small terminals.

**Which issue(s) this PR fixes**:

Fixes #2782

**How to test changes / Special notes to the reviewer**:

Run it :)

```sh

git clone https://github.com/openshift/nodejs-ex
odo create node js
odo preference set PushTimeout

watch -n 1 oc delete pvc --all

odo push -f
```

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Sprint 182
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shortens warning output for event information cdrage/odo
3 participants
@cdrage @mik-dass @openshift-ci-robot