Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --now flag in url delete for devfile component #2804

Closed
yangcao77 opened this issue Apr 2, 2020 · 1 comment · Fixed by #3139
Closed

Support --now flag in url delete for devfile component #2804

yangcao77 opened this issue Apr 2, 2020 · 1 comment · Fixed by #3139
Assignees
@mohammedzee1000
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
Sprint 185

Comments

@yangcao77
Copy link
Contributor

/kind feature

Which functionality do you think we should add?

--now flag is currently implement in url create in PR: #2762
However, it is still missing in url delete

If the now flag in provided in url delete, it should execute devfile push.

Why is this needed?

As suggested by #2762 (comment), create a separate issue to work on the now flag for url delete.
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Apr 2, 2020
@yangcao77 yangcao77 mentioned this issue Apr 2, 2020
Merged
@yangcao77
Copy link
Contributor Author

/area devfile

@openshift-ci-robot openshift-ci-robot added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Apr 2, 2020
@elsony elsony added this to For consideration in Sprint 182 via automation Apr 7, 2020
@elsony elsony added this to For consideration in Sprint 183 via automation Apr 17, 2020
@elsony elsony removed this from For consideration in Sprint 182 Apr 17, 2020
@girishramnani girishramnani added triage/needs-information Indicates an issue needs more information in order to work on it. points/3 labels Apr 20, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 183 Apr 23, 2020
@girishramnani girishramnani removed this from To do in Sprint 183 May 11, 2020
@girishramnani girishramnani added this to For consideration in Sprint 184 via automation May 11, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 184 May 11, 2020
@mohammedzee1000 mohammedzee1000 mentioned this issue May 11, 2020
Merged
@girishramnani girishramnani moved this from To do to In progress in Sprint 184 May 11, 2020
@mohammedzee1000 mohammedzee1000 added triage/ready and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels May 11, 2020
@mohammedzee1000 mohammedzee1000 moved this from In progress to For review in Sprint 184 May 28, 2020
@girishramnani girishramnani added this to For consideration in Sprint 185 via automation Jun 1, 2020
@girishramnani girishramnani removed this from For review in Sprint 184 Jun 1, 2020
@girishramnani girishramnani moved this from For consideration to For review in Sprint 185 Jun 1, 2020
Sprint 185 automation moved this from For review to Done Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohammedzee1000 mohammedzee1000

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
No open projects
Sprint 185
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating url delete to apply --now on devfile mohammedzee1000/odo
4 participants
@girishramnani @mohammedzee1000 @yangcao77 @openshift-ci-robot