We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/kind bug /area url
create a secured url and run odo push run odo push again
odo push
The url get re-created even with no changes to it
Applying URL changes ✓ URL ingressurl2 successfully deleted ✓ URL ingressurl2: https://ingressurl2.1.2.3.4.com created
Applying URL changes ✓ URLs are synced with the cluster, no changes are required.
This is because the secure value is missing when combining routes and ingresses into a single list: https://github.com/openshift/odo/blob/ddc2a204674e0e1ef0749802e5e6b3c5ee04abfd/pkg/url/url.go#L867-L872 https://github.com/openshift/odo/blob/ddc2a204674e0e1ef0749802e5e6b3c5ee04abfd/pkg/url/url.go#L883-L887
secure
Which result in the spec difference, so the code think the config has been changed.
val.Specs: {ingressurl2.1.2.3.4.com 3000 true ingress 0} urlSpec.Spec: {ingressurl2.1.2.3.4.com 3000 false ingress 0} ✓
The text was updated successfully, but these errors were encountered:
/assign
Sorry, something went wrong.
yangcao77
Successfully merging a pull request may close this issue.
/kind bug
/area url
How did you run odo exactly?
create a secured url and run
odo push
run
odo push
againActual behavior
The url get re-created even with no changes to it
Expected behavior
This is because the
secure
value is missing when combining routes and ingresses into a single list:https://github.com/openshift/odo/blob/ddc2a204674e0e1ef0749802e5e6b3c5ee04abfd/pkg/url/url.go#L867-L872
https://github.com/openshift/odo/blob/ddc2a204674e0e1ef0749802e5e6b3c5ee04abfd/pkg/url/url.go#L883-L887
Which result in the spec difference, so the code think the config has been changed.
The text was updated successfully, but these errors were encountered: