Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secured odo url get re-created during push even with no changes to it #3304

Closed
yangcao77 opened this issue Jun 4, 2020 · 1 comment · Fixed by #3305
Closed

secured odo url get re-created during push even with no changes to it #3304

yangcao77 opened this issue Jun 4, 2020 · 1 comment · Fixed by #3305
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects

Comments

@yangcao77
Copy link
Contributor

/kind bug
/area url

How did you run odo exactly?

create a secured url and run odo push
run odo push again

Actual behavior

The url get re-created even with no changes to it

Applying URL changes
 ✓  URL ingressurl2 successfully deleted
 ✓  URL ingressurl2: https://ingressurl2.1.2.3.4.com created

Expected behavior

Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.

This is because the secure value is missing when combining routes and ingresses into a single list:
https://github.com/openshift/odo/blob/ddc2a204674e0e1ef0749802e5e6b3c5ee04abfd/pkg/url/url.go#L867-L872
https://github.com/openshift/odo/blob/ddc2a204674e0e1ef0749802e5e6b3c5ee04abfd/pkg/url/url.go#L883-L887

Which result in the spec difference, so the code think the config has been changed.

val.Specs: {ingressurl2.1.2.3.4.com  3000 true ingress  0}
urlSpec.Spec: {ingressurl2.1.2.3.4.com  3000 false ingress  0} ✓
@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/url labels Jun 4, 2020
@yangcao77
Copy link
Contributor Author

/assign

@elsony elsony added this to For consideration in Sprint 185 via automation Jun 4, 2020
@elsony elsony moved this from For consideration to To do in Sprint 185 Jun 4, 2020
@elsony elsony moved this from To do to In progress in Sprint 185 Jun 4, 2020
@elsony elsony moved this from In progress to For review in Sprint 185 Jun 9, 2020
Sprint 185 automation moved this from For review to Done Jun 17, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Sprint 185
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants