Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.odo/env is not in .gitignore #3386

Closed
kadel opened this issue Jun 18, 2020 · 1 comment · Fixed by #3391
Closed

.odo/env is not in .gitignore #3386

kadel opened this issue Jun 18, 2020 · 1 comment · Fixed by #3391
Assignees
@girishramnani
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kadel
Copy link
Member

kadel commented Jun 18, 2020

/kind bug

How did you run odo exactly?

odo create maven

cat .gitignore
# git ignore contains just line with 
# .odo/odo-file-index.json

Expected behavior

in addition to .odo/odo-file-index.json odo should also populate .gitingore with .odo/env as this is an environment-specific configuration that shouldn't get to git repository.
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 18, 2020
@girishramnani
Copy link
Contributor

I can work on this

@girishramnani girishramnani self-assigned this Jun 19, 2020
@girishramnani girishramnani mentioned this issue Jun 19, 2020
Merged
@scottkurz scottkurz mentioned this issue Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishramnani girishramnani

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore .odo/env folder for devfile girishramnani/odo
3 participants
@kadel @girishramnani @openshift-ci-robot