Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsupported git component info in watch command help UX #3447

Closed
amitkrout opened this issue Jun 30, 2020 · 1 comment · Fixed by #3448
Closed

Add unsupported git component info in watch command help UX #3447

amitkrout opened this issue Jun 30, 2020 · 1 comment · Fixed by #3448
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@amitkrout
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System:
Supported
Output of odo version:
master

How did you run odo exactly?

$ odo watch -h
Watch for changes, update component on change.

Usage:
  odo watch [flags]

Examples:
  # Watch for changes in directory for current component
  odo watch

Flags:
      --app string       Application, defaults to active application
      --context string   Use given context directory as a source for component settings
      --delay int        Time in seconds between a detection of code change and push.delay=0 means changes will be pushed as soon as they are detected which can cause performance issues (default 1)
  -h, --help             Help for watch
      --ignore strings   Files or folders to be ignored via glob expressions.
      --project string   Project, defaults to active project
      --show-log         If enabled, logs will be shown when built

Additional Flags:
      --add_dir_header           If true, adds the file directory to the header
      --log_file string          If non-empty, use this log file
      --log_file_max_size uint   Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --skip_headers             If true, avoid header prefixes in the log messages
      --skip_log_headers         If true, avoid headers when opening log files
  -v, --v Level                  Number for the log level verbosity. Level varies from 0 to 9 (default 0).
      --vmodule moduleSpec       Comma-separated list of pattern=N settings for file-filtered logging

Actual behavior

No message is added for unsupported git component

Expected behavior

UX should contain the unsupported git component message

Any logs, error output, etc?

@amitkrout amitkrout added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Jun 30, 2020
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 30, 2020
@girishramnani
Copy link
Contributor

This doesn't seem like high priority to me. Any reason to put high priority
/remove-priority high
/priority medium

@openshift-ci-robot openshift-ci-robot added priority/Medium Nice to have issue. Getting it done before priority changes would be great. and removed priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants