Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Understanding odo" documentation to correspond to officially supported Devfiles #3517

Closed
cdrage opened this issue Jul 8, 2020 · 0 comments · Fixed by #3519
Closed
Assignees
Projects

Comments

@cdrage
Copy link
Member

cdrage commented Jul 8, 2020

/kind documentation

What mistake did you find / what is missing in the documentation?

See:

https://odo.dev/docs/understanding-odo/#officially-supported-languages-and-corresponding-container-images

and the corresponding documentation "downstream"

https://github.com/openshift/openshift-docs/blob/ad655a7d0a3b69ab89f7516c593130a6ebbdbc43/cli_reference/developer_cli_odo/understanding-odo.adoc

We must create out own "understanding odo" documentation that corresponds to Devfile rather than S2I.

What is the relevance of it?

Needed for Devfile.

@cdrage cdrage self-assigned this Jul 8, 2020
@cdrage cdrage added this to For consideration in Sprint 186 via automation Jul 8, 2020
@cdrage cdrage moved this from For consideration to In progress in Sprint 186 Jul 8, 2020
cdrage added a commit to cdrage/odo that referenced this issue Jul 8, 2020
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

Since we are doing a future Devfile release of odo that uses Devfile, we
require our "Understanding odo" guide to be located upstream rather than
downstream (from github.com/openshift/openshift-docs).

This adds that documentation.

**Which issue(s) this PR fixes**:

Closes redhat-developer#3517

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/odo that referenced this issue Jul 9, 2020
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

Since we are doing a future Devfile release of odo that uses Devfile, we
require our "Understanding odo" guide to be located upstream rather than
downstream (from github.com/openshift/openshift-docs).

This adds that documentation.

**Which issue(s) this PR fixes**:

Closes redhat-developer#3517

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/odo that referenced this issue Jul 9, 2020
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

Since we are doing a future Devfile release of odo that uses Devfile, we
require our "Understanding odo" guide to be located upstream rather than
downstream (from github.com/openshift/openshift-docs).

This adds that documentation.

**Which issue(s) this PR fixes**:

Closes redhat-developer#3517

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sprint 186 automation moved this from In progress to Done Jul 10, 2020
cdrage added a commit that referenced this issue Jul 10, 2020
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

Since we are doing a future Devfile release of odo that uses Devfile, we
require our "Understanding odo" guide to be located upstream rather than
downstream (from github.com/openshift/openshift-docs).

This adds that documentation.

**Which issue(s) this PR fixes**:

Closes #3517

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint 186
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants