-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url create
should validate host format
#3589
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
openshift-ci-robot
added
the
kind/bug
Categorizes issue or PR as related to a bug.
label
Jul 16, 2020
metacosm
added a commit
to metacosm/odo
that referenced
this issue
Jul 16, 2020
- Avoid checking for devfile / docker / experimental all the time - Aggregate validation errors so that all are reported at once - Fixes redhat-developer#3589
metacosm
added a commit
to metacosm/odo
that referenced
this issue
Jul 16, 2020
- Avoid checking for devfile / docker / experimental all the time - Aggregate validation errors so that all are reported at once - Fixes redhat-developer#3589
3 tasks
metacosm
added a commit
to metacosm/odo
that referenced
this issue
Jul 21, 2020
- Avoid checking for devfile / docker / experimental all the time - Aggregate validation errors so that all are reported at once - Fixes redhat-developer#3589
openshift-merge-robot
pushed a commit
that referenced
this issue
Jul 22, 2020
* feat: add ValidateHost function * feat: optimize validation of URLs before creation - Avoid checking for devfile / docker / experimental all the time - Aggregate validation errors so that all are reported at once - Fixes #3589 * fix: also check tls-secret in validate and report error if needed * chore: add tests, in particular to check compound errors * fix: comment out tests that only pass in experimental mode * fix: move URL tests to appropriate location * fix: adjust test for error format change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/kind bug
What versions of software are you using?
Operating System:
macOS
Output of
odo version
:odo v1.2.3 (9be483f)
How did you run odo exactly?
odo url create --host https://127.0.0.1:60104 --ingress
Actual behavior
URL was accepted
Expected behavior
URL should report an error that the format is not appropriate similar to what happens during
push
Any logs, error output, etc?
No, though subsequent
odo push
fail with:The text was updated successfully, but these errors were encountered: