Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odo catalog list components format #2736

Merged
merged 8 commits into from
Mar 27, 2020
Merged

Odo catalog list components format #2736

merged 8 commits into from
Mar 27, 2020

Conversation

GeekArthur
Copy link
Contributor

Signed-off-by: jingfu wang jingfu.j.wang@ibm.com

What type of PR is this?
/kind feature

What does does this PR do / why we need it:
The number of supported and unsupported tables is doubled as we add devfile support for odo catalog list components. In order to make the output format clean and more user friendly, we decide to combine the supported and unsupported tables. Below is the new output format:

Odo OpenShift Components:
NAME          PROJECT       TAGS                                        SUPPORTED
nodejs        openshift     10,8,8-RHOAR,latest                         YES
openjdk18     openshift     latest                                      YES
dotnet        openshift     2.0,latest                                  NO
httpd         openshift     2.4,latest                                  NO
nginx         openshift     1.10,1.12,1.8,latest                        NO
nodejs        openshift     6                                           NO
perl          openshift     5.24,5.26,latest                            NO
php           openshift     7.0,7.1,latest                              NO
python        openshift     2.7,3.5,3.6,latest                          NO
ruby          openshift     2.3,2.4,2.5,latest                          NO
wildfly       openshift     10.0,10.1,11.0,12.0,13.0,8.1,9.0,latest     NO

Odo Devfile Components:
NAME                 DESCRIPTION                           SUPPORTED
java-spring-boot     Spring Boot® using IBM Java           YES
openLiberty          Open Liberty microservice in Java     YES

Which issue(s) this PR fixes:

Fixes #2608

How to test changes / Special notes to the reviewer:

@GeekArthur
Odo catalog list components format
42e2056 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Mar 19, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @GeekArthur. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GeekArthur
Copy link
Contributor Author

/assign

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Mar 19, 2020
@GeekArthur
Copy link
Contributor Author

@cdrage Can you please review this PR? Thanks!

@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited

Codecov Report

Merging #2736 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
- Coverage   43.58%   43.56%   -0.03%     
==========================================
  Files          91       91              
  Lines        8266     8266              
==========================================
- Hits         3603     3601       -2     
- Misses       4314     4315       +1     
- Partials      349      350       +1
Impacted Files Coverage Δ
pkg/component/watch.go 72.66% <0%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6c2cd...d0ef71a. Read the comment docs.

@kadel
Copy link
Member

kadel commented Mar 20, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Mar 20, 2020
@GeekArthur
Copy link
Contributor Author

/retest

1 similar comment
@GeekArthur
Copy link
Contributor Author

/retest

@GeekArthur
Update integration tests
884e393 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
cdrage
cdrage approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Thanks for implementing the tests good. Implementation works well too.

Once tests are all green, LGTM from me.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 20, 2020
@cdrage
Copy link
Member

cdrage commented Mar 20, 2020 

github.com/openshift/odo  pr_2736 ✔                                                                                                                                                                                                                                         45m  
▶ odo catalog list components
Odo OpenShift Components:
NAME        PROJECT       TAGS                                        SUPPORTED
nodejs      openshift     10,8,8-RHOAR,latest                         YES
dotnet      openshift     2.0,latest                                  NO
httpd       openshift     2.4,latest                                  NO
nginx       openshift     1.10,1.12,1.8,latest                        NO
nodejs      openshift     6                                           NO
perl        openshift     5.24,5.26,latest                            NO
php         openshift     7.0,7.1,latest                              NO
python      openshift     2.7,3.5,3.6,latest                          NO
ruby        openshift     2.3,2.4,2.5,latest                          NO
wildfly     openshift     10.0,10.1,11.0,12.0,13.0,8.1,9.0,latest     NO

Odo Devfile Components:
NAME                 DESCRIPTION                           SUPPORTED
java-spring-boot     Spring Boot® using IBM Java           YES
openLiberty          Open Liberty microservice in Java     YES

Looks awesome!

@GeekArthur
Copy link
Contributor Author

@amitkrout Tests are updated, please review again, thanks!

@GeekArthur
Copy link
Contributor Author

/retest

2 similar comments
@GeekArthur
Copy link
Contributor Author

/retest

@GeekArthur
Copy link
Contributor Author

/retest

@GeekArthur
Copy link
Contributor Author

@kadel Please review this PR, thanks!

@GeekArthur
Enable integration tests
66c0c85 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 23, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 26, 2020
rajivnathan
rajivnathan approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the lgtm back

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2020
@rajivnathan
Copy link
Contributor

/lgtm cancel we'd like to wait for #2699 to go in before this

@elsony elsony removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2020
@GeekArthur
Merge branch 'master' of github.com:openshift/odo into issue-2608-cat…
d0ef71a 
…alogFormat

Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
rajivnathan
rajivnathan approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding lgtm back since #2699 is now merged

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2020
@GeekArthur
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@amitkrout
Copy link
Contributor

amitkrout commented Mar 27, 2020 •
edited

pr #2767 will fix travis flake.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a8a5eca into redhat-developer:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout amitkrout requested changes

@cdrage cdrage cdrage approved these changes

@rajivnathan rajivnathan rajivnathan approved these changes

@elsony elsony Awaiting requested review from elsony

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@cdrage cdrage

@GeekArthur GeekArthur

@amitkrout amitkrout

@rajivnathan rajivnathan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo catalog list components command output improvement
9 participants
@GeekArthur @openshift-ci-robot @kadel @cdrage @rajivnathan @openshift-bot @amitkrout @elsony @openshift-merge-robot