/
loadbalancers.go
1099 lines (976 loc) · 50.9 KB
/
loadbalancers.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package openstack
import (
"context"
"crypto/tls"
"fmt"
"io"
"net"
"net/http"
"os"
"regexp"
"strconv"
"strings"
"time"
"github.com/gophercloud/gophercloud/v2"
"github.com/gophercloud/gophercloud/v2/openstack"
octavialisteners "github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/listeners"
octavialoadbalancers "github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/loadbalancers"
octaviamonitors "github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/monitors"
"github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/pools"
"github.com/gophercloud/gophercloud/v2/openstack/networking/v2/extensions/layer3/floatingips"
"github.com/gophercloud/gophercloud/v2/openstack/networking/v2/subnets"
g "github.com/onsi/ginkgo/v2"
o "github.com/onsi/gomega"
operatorv1 "github.com/openshift/api/operator/v1"
"github.com/openshift/openstack-test/test/extended/openstack/client"
exutil "github.com/openshift/origin/test/extended/util"
ini "gopkg.in/ini.v1"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/fields"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/apimachinery/pkg/util/uuid"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/kubernetes"
e2e "k8s.io/kubernetes/test/e2e/framework"
e2edeployment "k8s.io/kubernetes/test/e2e/framework/deployment"
e2eevents "k8s.io/kubernetes/test/e2e/framework/events"
e2eservice "k8s.io/kubernetes/test/e2e/framework/service"
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
)
var _ = g.Describe("[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform", func() {
oc := exutil.NewCLI("openstack")
var loadBalancerClient *gophercloud.ServiceClient
var networkClient *gophercloud.ServiceClient
var clientSet *kubernetes.Clientset
var cloudProviderConfig *ini.File
var loadBalancerServiceTimeout = 10 * time.Minute
availableLbProvidersUnderTests := [2]string{"Amphora", "OVN"}
availableProtocolsUnderTests := [2]v1.Protocol{v1.ProtocolTCP, v1.ProtocolUDP}
lbMethodsWithETPGlobal := map[string]string{
"OVN": "source_ip_port",
"Amphora": "round_robin",
}
g.BeforeEach(func(ctx g.SpecContext) {
network, err := oc.AdminConfigClient().ConfigV1().Networks().Get(ctx, "cluster", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
if network.Status.NetworkType == "Kuryr" {
e2eskipper.Skipf("Test not applicable for Kuryr NetworkType")
}
// TODO revert once https://issues.redhat.com/browse/OSASINFRA-3079 is resolved
// For now, LoadBalancer tests are not applicable when the cluster is running behind a proxy.
proxy, err := oc.AdminConfigClient().ConfigV1().Proxies().Get(ctx, "cluster", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
if os.Getenv("HTTP_PROXY") != "" || os.Getenv("HTTPS_PROXY") != "" || proxy.Status.HTTPProxy != "" {
e2eskipper.Skipf("Test not applicable for proxy setup")
}
g.By("preparing the openstack client")
networkClient, err = client.GetServiceClient(ctx, openstack.NewNetworkV2)
o.Expect(err).NotTo(o.HaveOccurred(), "Failed to build the OpenStack client")
loadBalancerClient, err = client.GetServiceClient(ctx, openstack.NewLoadBalancerV2)
o.Expect(err).NotTo(o.HaveOccurred(), "Failed to build the OpenStack client")
g.By("preparing openshift dynamic client")
clientSet, err = e2e.LoadClientset()
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Gathering cloud-provider-config")
cloudProviderConfig, err = getConfig(ctx,
oc.AdminKubeClient(),
"openshift-cloud-controller-manager",
"cloud-conf",
"cloud.conf")
o.Expect(err).NotTo(o.HaveOccurred())
})
for _, i := range availableLbProvidersUnderTests {
lbProviderUnderTest := i
for _, j := range availableProtocolsUnderTests {
protocolUnderTest := j
// https://issues.redhat.com/browse/OSASINFRA-2753
// https://issues.redhat.com/browse/OSASINFRA-2412
g.It(fmt.Sprintf("should create a %s %s LoadBalancer when a %s svc with type:LoadBalancer is created on Openshift", protocolUnderTest, lbProviderUnderTest, protocolUnderTest), func(ctx g.SpecContext) {
skipIfNotLbProvider(lbProviderUnderTest, cloudProviderConfig)
g.By("Creating Openshift deployment")
labels := map[string]string{"app": "lb-default-dep"}
testDeployment := createTestDeployment(deploymentOpts{
Name: "lb-default-dep",
Labels: labels,
Replicas: 2,
Protocol: protocolUnderTest,
Port: 8081,
})
deployment, err := clientSet.AppsV1().Deployments(oc.Namespace()).Create(ctx,
testDeployment, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
err = e2edeployment.WaitForDeploymentComplete(clientSet, deployment)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Creating Openshift LoadBalancer Service")
svcName := "lb-default-svc"
svcPort := int32(8082)
jig := e2eservice.NewTestJig(clientSet, oc.Namespace(), svcName)
jig.Labels = labels
svc, err := jig.CreateLoadBalancerService(ctx, loadBalancerServiceTimeout, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: protocolUnderTest, Port: svcPort, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
})
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Checks from openshift perspective")
loadBalancerId := svc.GetAnnotations()["loadbalancer.openstack.org/load-balancer-id"]
o.Expect(loadBalancerId).ShouldNot(o.BeEmpty(), "load-balancer-id annotation missing")
o.Expect(svc.Status.LoadBalancer.Ingress).ShouldNot(o.BeEmpty(), "svc.Status.LoadBalancer.Ingress should not be empty")
svcIp := svc.Status.LoadBalancer.Ingress[0].IP
o.Expect(svcIp).ShouldNot(o.BeEmpty(), "Ingress IP missing on svc Status")
o.Expect(svc.Spec.ExternalTrafficPolicy).Should(o.Equal(v1.ServiceExternalTrafficPolicyTypeCluster),
"Unexpected ExternalTrafficPolicy on svc specs")
g.By("Checks from openstack perspective")
lb, err := octavialoadbalancers.Get(ctx, loadBalancerClient, loadBalancerId).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(lb.Provider).Should(o.Equal(strings.ToLower(lbProviderUnderTest)), "Unexpected provider in the Openstack LoadBalancer")
if isIpv4(lb.VipAddress) { // No FIP assignment on ipv6
fip, err := getFipbyFixedIP(ctx, networkClient, lb.VipAddress)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(fip.FloatingIP).Should(o.Equal(svcIp), "Unexpected floatingIp in the Openstack LoadBalancer")
}
o.Expect(lb.Pools).Should(o.HaveLen(1), "Unexpected number of pools on Openstack LoadBalancer %q", lb.Name)
pool, err := pools.Get(ctx, loadBalancerClient, lb.Pools[0].ID).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(pool.Protocol).Should(o.Equal(string(protocolUnderTest)), "Unexpected protocol on Openstack LoadBalancer Pool: %q", pool.Name)
//Set as OFFLINE in vexxhost despite the lb is operative
//o.Expect(pool.OperatingStatus).Should(o.Equal("ONLINE"), "Unexpected Operating Status on Openstack Pool: %q", pool.Name)
lbMethod, err := getClusterLoadBalancerSetting("lb-method", cloudProviderConfig)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(strings.ToLower(pool.LBMethod)).Should(o.Equal(lbMethod), "Unexpected LBMethod on Openstack Pool: %q", strings.ToLower(pool.LBMethod))
nodeList, err := clientSet.CoreV1().Nodes().List(ctx, metav1.ListOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
expectedNumberOfMembers := len(nodeList.Items)
o.Expect(waitUntilNmembersReady(ctx, loadBalancerClient, pool, expectedNumberOfMembers, "NO_MONITOR|ONLINE")).NotTo(o.HaveOccurred(),
"Error waiting for %d members with NO_MONITOR or ONLINE OperatingStatus", len(nodeList.Items))
g.By("accessing the service 100 times from outside and storing the name of the pods answering")
results := make(map[string]int)
for i := 0; i < 100; i++ {
// https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/README.md#netexec
podName, err := getPodNameThroughLb(svcIp, fmt.Sprintf("%d", svcPort), protocolUnderTest, "hostname")
if err != nil {
e2e.Logf("Error detected while accessing the LoadBalancer service on try %d: %q", i, err)
} else {
results[podName]++
}
}
e2e.Logf("Pods accessed after 100 requests:\n%v\n", results)
pods, err := oc.KubeClient().CoreV1().Pods(oc.Namespace()).List(ctx, metav1.ListOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
// ETP:Local not configured so the defined lbMethod is not applied, but the one on 'lbMethodsWithETPGlobal' var.
// https://issues.redhat.com/browse/OCPBUGS-2350
o.Expect(isLbMethodApplied(lbMethodsWithETPGlobal[lbProviderUnderTest], results, pods)).Should(o.BeTrue(), "%q lb-method not applied after 100 queries:\n%v\n", lbMethod, results)
})
}
// https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/openstack-cloud-controller-manager/expose-applications-using-loadbalancer-type-service.md#sharing-load-balancer-with-multiple-services
g.It(fmt.Sprintf("should re-use an existing UDP %s LoadBalancer when new svc is created on Openshift with the proper annotation", lbProviderUnderTest), func(ctx g.SpecContext) {
skipIfNotLbProvider(lbProviderUnderTest, cloudProviderConfig)
g.By("Checking cluster configuration")
setting, err := getClusterLoadBalancerSetting("max-shared-lb", cloudProviderConfig)
o.Expect(err).NotTo(o.HaveOccurred())
maxSharedLb, err := strconv.Atoi(setting)
o.Expect(err).NotTo(o.HaveOccurred())
if maxSharedLb < 2 {
e2eskipper.Skipf("Test not applicable when max-shared-lb is lower than 2 and it is %d", maxSharedLb)
}
g.By("Creating Openshift deployment")
labels := map[string]string{"app": "udp-lb-shared-dep"}
testDeployment := createTestDeployment(deploymentOpts{
Name: "udp-lb-shared-dep",
Labels: labels,
Replicas: 2,
Protocol: v1.ProtocolUDP,
Port: 8081,
})
deployment, err := clientSet.AppsV1().Deployments(oc.Namespace()).Create(ctx,
testDeployment, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
err = e2edeployment.WaitForDeploymentComplete(clientSet, deployment)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Creating first Openshift service")
svcName1 := "udp-lb-shared1-svc"
svcPort1 := int32(8082)
jig := e2eservice.NewTestJig(clientSet, oc.Namespace(), svcName1)
jig.Labels = labels
svc1, err := jig.CreateLoadBalancerService(ctx, loadBalancerServiceTimeout, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: v1.ProtocolUDP, Port: svcPort1, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
})
o.Expect(err).NotTo(o.HaveOccurred())
loadBalancerId := svc1.GetAnnotations()["loadbalancer.openstack.org/load-balancer-id"]
o.Expect(loadBalancerId).ShouldNot(o.BeEmpty(), "load-balancer-id annotation missing")
e2e.Logf("detected loadbalancer id is %q", loadBalancerId)
g.By(fmt.Sprintf("Creating second Openshift service using the existing Openstack loadbalancer %s", loadBalancerId))
svcName2 := "udp-lb-shared2-svc"
svcPort2 := int32(8083)
jig = e2eservice.NewTestJig(clientSet, oc.Namespace(), svcName2)
jig.Labels = labels
svc2, err := jig.CreateLoadBalancerService(ctx, loadBalancerServiceTimeout, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: v1.ProtocolUDP, Port: svcPort2, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
svc.SetAnnotations(map[string]string{"loadbalancer.openstack.org/load-balancer-id": loadBalancerId})
})
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Checks from openstack perspective")
lb, err := octavialoadbalancers.Get(ctx, loadBalancerClient, loadBalancerId).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(lb.Pools).Should(o.HaveLen(2), "Unexpected number of pools on Openstack LoadBalancer %q", lb.Name)
g.By("Connectivity checks")
o.Expect(svc1.Status.LoadBalancer.Ingress).ShouldNot(o.BeEmpty(), "svc1.Status.LoadBalancer.Ingress should not be empty")
o.Expect(svc2.Status.LoadBalancer.Ingress).ShouldNot(o.BeEmpty(), "svc2.Status.LoadBalancer.Ingress should not be empty")
o.Expect(svc1.Status.LoadBalancer.Ingress[0].IP).Should(o.Equal(svc2.Status.LoadBalancer.Ingress[0].IP),
"Unexpected external IP for svcs sharing the loadbalancer")
fip := svc1.Status.LoadBalancer.Ingress[0].IP
podNames, err := exutil.GetPodNamesByFilter(oc.KubeClient().CoreV1().Pods(oc.Namespace()),
exutil.ParseLabelsOrDie(""), func(v1.Pod) bool { return true })
o.Expect(err).NotTo(o.HaveOccurred())
maxAttempts := 100
podName := ""
for _, svcPort := range [2]int32{svcPort1, svcPort2} {
for count := 0; count < maxAttempts; count++ {
podName, err = getPodNameThroughLb(fip, fmt.Sprintf("%d", svcPort), v1.ProtocolUDP, "hostname")
if err == nil {
break
}
}
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(podName).Should(o.BeElementOf(podNames))
e2e.Logf("Pod %s successfully accessed through svc loadbalancer on ip %s and port %d", podName, fip, svcPort)
}
})
// https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/openstack-cloud-controller-manager/expose-applications-using-loadbalancer-type-service.md#sharing-load-balancer-with-multiple-services
// In order to prevent accidental exposure internal Services cannot share a load balancer with any other Service.
g.It(fmt.Sprintf("should not re-use an existing UDP %s LoadBalancer if shared internal svc is created", lbProviderUnderTest), func(ctx g.SpecContext) {
skipIfNotLbProvider(lbProviderUnderTest, cloudProviderConfig)
g.By("Checking cluster configuration")
setting, err := getClusterLoadBalancerSetting("max-shared-lb", cloudProviderConfig)
o.Expect(err).NotTo(o.HaveOccurred())
maxSharedLb, err := strconv.Atoi(setting)
o.Expect(err).NotTo(o.HaveOccurred())
if maxSharedLb < 2 {
e2eskipper.Skipf("Test not applicable when max-shared-lb is lower than 2 and it is %d", maxSharedLb)
}
g.By("Creating Openshift deployment")
labels := map[string]string{"app": "udp-lb-shared-dep"}
testDeployment := createTestDeployment(deploymentOpts{
Name: "udp-lb-shared-dep",
Labels: labels,
Replicas: 2,
Protocol: v1.ProtocolUDP,
Port: 8081,
})
deployment, err := clientSet.AppsV1().Deployments(oc.Namespace()).Create(ctx,
testDeployment, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
err = e2edeployment.WaitForDeploymentComplete(clientSet, deployment)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Creating first Openshift service")
svcName1 := "udp-lb-shared1-svc"
svcPort1 := int32(8082)
jig := e2eservice.NewTestJig(clientSet, oc.Namespace(), svcName1)
jig.Labels = labels
svc1, err := jig.CreateLoadBalancerService(ctx, loadBalancerServiceTimeout, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: v1.ProtocolUDP, Port: svcPort1, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
})
o.Expect(err).NotTo(o.HaveOccurred())
loadBalancerId := svc1.GetAnnotations()["loadbalancer.openstack.org/load-balancer-id"]
o.Expect(loadBalancerId).ShouldNot(o.BeEmpty(), "load-balancer-id annotation missing")
e2e.Logf("detected loadbalancer id is %q", loadBalancerId)
g.By(fmt.Sprintf("Creating internal Openshift service using the existing Openstack loadbalancer %s -"+
"This should not be allowed.", loadBalancerId))
svcName2 := "udp-lb-shared2-internal-svc"
svcPort2 := int32(8083)
jig = e2eservice.NewTestJig(clientSet, oc.Namespace(), svcName2)
jig.Labels = labels
svc2, err := jig.CreateLoadBalancerService(ctx, 1*time.Second, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: v1.ProtocolUDP, Port: svcPort2, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
svc.SetAnnotations(map[string]string{"loadbalancer.openstack.org/load-balancer-id": loadBalancerId,
"service.beta.kubernetes.io/openstack-internal-load-balancer": "true"})
})
o.Expect(err).To(o.HaveOccurred()) //Error is expected
o.Expect(svc2).To(o.BeNil())
g.By("Waiting for event reporting the error creating the internal lb")
eventSelector := fields.Set{
"involvedObject.kind": "Service",
"involvedObject.name": svcName2,
"involvedObject.namespace": oc.Namespace(),
"reason": "SyncLoadBalancerFailed",
}.AsSelector().String()
msg := "internal Service cannot share a load balancer"
err = e2eevents.WaitTimeoutForEvent(ctx, clientSet, oc.Namespace(), eventSelector, msg, 100*time.Second)
o.Expect(err).NotTo(o.HaveOccurred(), "Expected event not found.")
e2e.Logf("Expected event found.")
g.By("Checks from openstack perspective that there is still only one pool for the lb")
lb, err := octavialoadbalancers.Get(ctx, loadBalancerClient, loadBalancerId).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(lb.Pools).Should(o.HaveLen(1), "Unexpected number of pools on Openstack LoadBalancer %q", lb.Name)
e2e.Logf("Expected number of pools found on the openstack loadbalancer.")
})
for _, j := range availableProtocolsUnderTests {
protocolUnderTest := j
// https://issues.redhat.com/browse/OCPBUGS-2350
g.It(fmt.Sprintf("should apply lb-method on %s %s LoadBalancer when a %s svc with monitors and ETP:Local is created on Openshift", protocolUnderTest, lbProviderUnderTest, protocolUnderTest), func(ctx g.SpecContext) {
skipIfNotLbProvider(lbProviderUnderTest, cloudProviderConfig)
// Skip for OpenshiftSDN and Octavia version < 2.16 as Octavia UDP-CONNECT type health monitors
// don't work with OpenShiftSDN (it incorrectly marks the nodes without local endpoints as ONLINE)
// https://issues.redhat.com/browse/OCPBUGS-7229
octaviaMinVersion := "v2.16"
networkType, err := getNetworkType(ctx, oc)
o.Expect(err).NotTo(o.HaveOccurred())
octaviaGreaterOrEqualV2_16, err := IsOctaviaVersionGreaterThanOrEqual(ctx, loadBalancerClient, octaviaMinVersion)
o.Expect(err).NotTo(o.HaveOccurred())
if networkType == NetworkTypeOpenShiftSDN && !octaviaGreaterOrEqualV2_16 && protocolUnderTest == v1.ProtocolUDP {
e2eskipper.Skipf("Test not applicable for %s network type when the Octavia version < %s", NetworkTypeOpenShiftSDN, octaviaMinVersion)
}
g.By("Creating Openshift deployment")
labels := map[string]string{"app": "lb-etplocal-dep"}
workerNodeList, err := clientSet.CoreV1().Nodes().List(ctx, metav1.ListOptions{
LabelSelector: "node-role.kubernetes.io/worker",
})
o.Expect(err).NotTo(o.HaveOccurred())
replicas := len(workerNodeList.Items)
testDeployment := createTestDeployment(deploymentOpts{
Name: "lb-etplocal-dep",
Labels: labels,
Replicas: int32(replicas),
Protocol: protocolUnderTest,
Port: 8081,
})
testDeployment.Spec.Template.Spec.Affinity = &v1.Affinity{
PodAntiAffinity: &v1.PodAntiAffinity{
RequiredDuringSchedulingIgnoredDuringExecution: []v1.PodAffinityTerm{{
TopologyKey: "kubernetes.io/hostname",
LabelSelector: &metav1.LabelSelector{
MatchExpressions: []metav1.LabelSelectorRequirement{
{
Key: "app",
Operator: metav1.LabelSelectorOpIn,
Values: []string{"lb-etplocal-dep"},
},
},
}}}}}
deployment, err := clientSet.AppsV1().Deployments(oc.Namespace()).Create(ctx,
testDeployment, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
err = e2edeployment.WaitForDeploymentComplete(clientSet, deployment)
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Creating Openshift LoadBalancer Service with monitors and ETP:Local")
svcName := "lb-etplocal-svc"
svcPort := int32(8082)
monitorDelay := 5
monitorTimeout := 5
monitorMaxRetries := 2
jig := e2eservice.NewTestJig(clientSet, oc.Namespace(), svcName)
jig.Labels = labels
svc, err := jig.CreateLoadBalancerService(ctx, loadBalancerServiceTimeout, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: protocolUnderTest, Port: svcPort, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
svc.SetAnnotations(map[string]string{
"loadbalancer.openstack.org/enable-health-monitor": "true",
"loadbalancer.openstack.org/health-monitor-delay": fmt.Sprintf("%d", monitorDelay),
"loadbalancer.openstack.org/health-monitor-timeout": fmt.Sprintf("%d", monitorTimeout),
"loadbalancer.openstack.org/health-monitor-max-retries": fmt.Sprintf("%d", monitorMaxRetries),
})
svc.Spec.ExternalTrafficPolicy = v1.ServiceExternalTrafficPolicyTypeLocal
})
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Checks from openshift perspective")
loadBalancerId := svc.GetAnnotations()["loadbalancer.openstack.org/load-balancer-id"]
o.Expect(loadBalancerId).ShouldNot(o.BeEmpty(), "load-balancer-id annotation missing")
svcIp := svc.Status.LoadBalancer.Ingress[0].IP
o.Expect(svcIp).ShouldNot(o.BeEmpty(), "Ingress IP missing on svc Status")
o.Expect(svc.Spec.ExternalTrafficPolicy).Should(o.Equal(v1.ServiceExternalTrafficPolicyTypeLocal),
"Unexpected ExternalTrafficPolicy on svc specs")
g.By("Checks from openstack perspective")
lb, err := octavialoadbalancers.Get(ctx, loadBalancerClient, loadBalancerId).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(lb.Provider).Should(o.Equal(strings.ToLower(lbProviderUnderTest)), "Unexpected provider in the Openstack LoadBalancer")
pool, err := pools.Get(ctx, loadBalancerClient, lb.Pools[0].ID).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(pool.Protocol).Should(o.Equal(string(protocolUnderTest)), "Unexpected protocol on Openstack LoadBalancer Pool: %q", pool.Name)
monitor, err := octaviamonitors.Get(ctx, loadBalancerClient, pool.MonitorID).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(monitor.AdminStateUp).Should(o.BeTrue(), "Unexpected healthmonitor adminStateUp on Openstack LoadBalancer Pool: %q", pool.Name)
o.Expect(monitor.Delay).Should(o.Equal(monitorDelay), "Unexpected healthmonitor delay on Openstack LoadBalancer Pool: %q", pool.Name)
o.Expect(monitor.Timeout).Should(o.Equal(monitorTimeout), "Unexpected healthmonitor timeout on Openstack LoadBalancer Pool: %q", pool.Name)
o.Expect(monitor.MaxRetries).Should(o.Equal(monitorMaxRetries), "Unexpected healthmonitor MaxRetries on Openstack LoadBalancer Pool: %q", pool.Name)
lbMethod, err := getClusterLoadBalancerSetting("lb-method", cloudProviderConfig)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(strings.ToLower(pool.LBMethod)).Should(o.Equal(lbMethod), "Unexpected LBMethod on Openstack Pool: %q", pool.LBMethod)
if monitor.Type == "UDP-CONNECT" {
o.Expect(waitUntilNmembersReady(ctx, loadBalancerClient, pool, int(replicas), "ONLINE")).NotTo(o.HaveOccurred(),
"Error waiting for %d members with ONLINE OperatingStatus", replicas)
} else if monitor.Type == "HTTP" {
// vexxhost uses HTTP healthmonitor and the OperatingStatus is not updated in that case.
// Therefore, the test cannot know when the the members are ready, so waiting 30 seconds for stability
e2e.Logf("monitor type is HTTP - Giving 30 seconds to let it calculate the ONLINE members")
time.Sleep(30 * time.Second)
}
g.By("accessing the service 100 times from outside and storing the name of the pods answering")
results := make(map[string]int)
for i := 0; i < 100; i++ {
// https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/README.md#netexec
podName, err := getPodNameThroughLb(svcIp, fmt.Sprintf("%d", svcPort), protocolUnderTest, "hostname")
if err != nil {
e2e.Logf("Error detected while accessing the LoadBalancer service on try %d: %q", i, err)
} else {
results[podName]++
}
}
e2e.Logf("Pods accessed after 100 %s requests:\n%v\n", protocolUnderTest, results)
pods, err := oc.KubeClient().CoreV1().Pods(oc.Namespace()).List(ctx, metav1.ListOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
//lbMethod can be something different to ROUND_ROBIN as monitors && ETP:Local are enabled on this test:
o.Expect(isLbMethodApplied(lbMethod, results, pods)).Should(o.BeTrue(), "%q lb-method not applied after 100 queries:\n%v\n", lbMethod, results)
})
}
// https://bugzilla.redhat.com/show_bug.cgi?id=1997704
g.It(fmt.Sprintf("should create an UDP %s LoadBalancer using a pre-created FIP when an UDP LoadBalancer svc setting the LoadBalancerIP spec is created on Openshift", lbProviderUnderTest), func(ctx g.SpecContext) {
skipIfNotLbProvider(lbProviderUnderTest, cloudProviderConfig)
var err error
dualstackIpv6Primary, err := isIpv6primaryDualStackCluster(ctx, oc)
o.Expect(err).NotTo(o.HaveOccurred())
if dualstackIpv6Primary { //This test is covering and scenario that has no sense with ipv6 as there is no FIP/VIP association.
e2eskipper.Skipf("Test not applicable for ipv6primary dualstack environments")
}
g.By("Create FIP to be used on the subsequent LoadBalancer Service")
var fip *floatingips.FloatingIP
// Use network configured on cloud-provider-config if any
configuredNetworkId, _ := getClusterLoadBalancerSetting("floating-network-id", cloudProviderConfig)
configuredSubnetId, _ := getClusterLoadBalancerSetting("floating-subnet-id", cloudProviderConfig)
if configuredNetworkId != "" {
fip, err = floatingips.Create(ctx, networkClient, floatingips.CreateOpts{FloatingNetworkID: configuredNetworkId, SubnetID: configuredSubnetId}).Extract()
o.Expect(err).NotTo(o.HaveOccurred(), "error creating FIP using IDs configured on the OCP cluster. Network-id: %s. Subnet-id: %s", configuredNetworkId, configuredSubnetId)
} else {
// If not, discover the first FloatingNetwork existing on OSP
foundNetworkId, err := GetFloatingNetworkID(ctx, networkClient)
o.Expect(err).NotTo(o.HaveOccurred())
fip, err = floatingips.Create(ctx, networkClient, floatingips.CreateOpts{FloatingNetworkID: foundNetworkId}).Extract()
o.Expect(err).NotTo(o.HaveOccurred(), "error creating FIP using discovered floatingNetwork ID %s", foundNetworkId)
}
g.By(fmt.Sprintf("FIP created: %s", fip.FloatingIP))
defer floatingips.Delete(ctx, networkClient, fip.ID)
g.By("Creating Openshift deployment")
depName := "udp-lb-precreatedfip-dep"
svcName := "udp-lb-precreatedfip-svc"
svcPort := int32(8022)
labels := map[string]string{"app": depName}
testDeployment := createTestDeployment(deploymentOpts{
Name: depName,
Labels: labels,
Replicas: 2,
Protocol: v1.ProtocolUDP,
Port: 8081,
})
deployment, err := clientSet.AppsV1().Deployments(oc.Namespace()).Create(ctx,
testDeployment, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
err = e2edeployment.WaitForDeploymentComplete(clientSet, deployment)
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("Creating Openshift LoadBalancer Service using the FIP %s on network %s", fip.FloatingIP, fip.FloatingNetworkID))
jig := e2eservice.NewTestJig(clientSet, oc.Namespace(), svcName)
jig.Labels = labels
svc, err := jig.CreateLoadBalancerService(ctx, loadBalancerServiceTimeout, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: v1.ProtocolUDP, Port: svcPort, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
svc.Spec.LoadBalancerIP = fip.FloatingIP
})
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Checks from openshift perspective")
o.Expect(svc.Status.LoadBalancer.Ingress[0].IP).Should(o.Equal(fip.FloatingIP))
g.By("Connectivity checks")
podNames, err := exutil.GetPodNamesByFilter(oc.KubeClient().CoreV1().Pods(oc.Namespace()),
exutil.ParseLabelsOrDie(""), func(v1.Pod) bool { return true })
o.Expect(err).NotTo(o.HaveOccurred())
maxAttempts := 100 // Multiple connection attempts to stabilize the test in vexxhost
var podName string
for count := 0; count < maxAttempts; count++ {
podName, err = getPodNameThroughLb(fip.FloatingIP, fmt.Sprintf("%d", svcPort), v1.ProtocolUDP, "hostname")
if err == nil {
count = maxAttempts
}
}
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(podName).Should(o.BeElementOf(podNames))
e2e.Logf("Pod %s successfully accessed through svc loadbalancer on ip %s and port %d", podName, fip.FloatingIP, svcPort)
})
// https://issues.redhat.com/browse/OSASINFRA-2412
g.It(fmt.Sprintf("should create a TCP %s LoadBalancer when LoadBalancerService ingressController is created on Openshift", lbProviderUnderTest), func(ctx g.SpecContext) {
skipIfNotLbProvider(lbProviderUnderTest, cloudProviderConfig)
g.By("Creating ingresscontroller for sharding the OCP in-built canary service")
name := "shard-" + string(uuid.NewUUID())
domain := "sharding-test.apps.shiftstack.com"
shardIngressCtrl, err := deployLbIngressController(ctx, oc, 10*time.Minute, name, domain, map[string]string{"ingress.openshift.io/canary": "canary_controller"})
defer func() {
err := oc.AdminOperatorClient().OperatorV1().IngressControllers(shardIngressCtrl.Namespace).Delete(ctx, shardIngressCtrl.Name, metav1.DeleteOptions{})
o.Expect(err).NotTo(o.HaveOccurred(), "error destroying ingress-controller created during the test")
}()
o.Expect(err).NotTo(o.HaveOccurred(), "new ingresscontroller did not rollout")
g.By("Checks from openshift perspective")
svc, err := oc.AdminKubeClient().CoreV1().Services("openshift-ingress").Get(ctx, "router-"+name, metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred(), "router-%q not found in openshift-ingress namespace", name)
o.Expect(svc.Spec.Type).Should(o.Equal(v1.ServiceTypeLoadBalancer), "Unexpected svc Type: %q", svc.Spec.Type)
loadBalancerId := svc.GetAnnotations()["loadbalancer.openstack.org/load-balancer-id"]
o.Expect(loadBalancerId).ShouldNot(o.BeEmpty(), "load-balancer-id annotation missing")
o.Expect(svc.Status.LoadBalancer.Ingress).ShouldNot(o.BeEmpty(), "svc.Status.LoadBalancer.Ingress should not be empty")
svcIp := svc.Status.LoadBalancer.Ingress[0].IP
o.Expect(svcIp).ShouldNot(o.BeEmpty(), "Ingress IP missing on svc Status")
o.Expect(svc.Spec.ExternalTrafficPolicy).Should(o.Equal(v1.ServiceExternalTrafficPolicyTypeLocal),
"Unexpected ExternalTrafficPolicy on svc specs")
e2e.Logf("Service with LoadBalancerType exists with public ip %q and it is pointing to openstack loadbalancer with id %q", svcIp, loadBalancerId)
g.By("Checks from openstack perspective")
lb, err := octavialoadbalancers.Get(ctx, loadBalancerClient, loadBalancerId).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(lb.Provider).Should(o.Equal(strings.ToLower(lbProviderUnderTest)), "Unexpected provider in the Openstack LoadBalancer")
//In canary, two pools are created: ports 80 and 443. Checking all existing pools:
for i := 0; i < len(svc.Spec.Ports); i++ {
poolId := lb.Pools[i].ID
pool, err := pools.Get(ctx, loadBalancerClient, poolId).Extract()
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(pool.Protocol).Should(o.Equal("TCP"), "Unexpected protocol on Openstack LoadBalancer Pool: %q", pool.Name)
}
g.By("Test that the canary service is accessible through new ingressController")
route, err := oc.AdminRouteClient().RouteV1().Routes("openshift-ingress-canary").Get(ctx, "canary", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred(), "canary route not found")
host := ""
for _, ingress := range route.Status.Ingress {
if strings.HasSuffix(ingress.Host, domain) {
host = ingress.Host
}
}
o.Expect(host).ShouldNot(o.Equal(""), "Host not found in route")
for i := 0; i < 100; i++ {
e2e.Logf("Attempting to connect using host: %q", host)
resp, err := httpsGetWithCustomLookup(host, svcIp)
o.Expect(err).NotTo(o.HaveOccurred())
defer resp.Body.Close()
o.Expect(resp.Status).Should(o.Equal("200 OK"), "Unexpected response on try #%d", i)
body, err := io.ReadAll(resp.Body)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(string(body)).Should(o.Equal("Healthcheck requested\n"), "Unexpected response on try #%d", i)
o.Expect(fmt.Sprintf("%q", resp.TLS.PeerCertificates[0].Subject)).Should(o.Equal("\"CN=*."+domain+"\""), "Unexpected response on try #%d", i)
}
e2e.Logf("Canary service successfully accessed through new ingressController")
})
g.It(fmt.Sprintf("should limit service access on an UDP %s LoadBalancer when an UDP LoadBalancer svc setting the loadBalancerSourceRanges spec is created on Openshift", lbProviderUnderTest), func(ctx g.SpecContext) {
skipIfNotLbProvider(lbProviderUnderTest, cloudProviderConfig)
g.By("Creating Openshift deployment")
depName := "udp-lb-sourceranges-dep"
svcPort := int32(8082)
labels := map[string]string{"app": depName}
allowed_sourcerange := "9.9.9.9/32"
ipv6PrimaryDualStack, err := isIpv6primaryDualStackCluster(ctx, oc)
o.Expect(err).NotTo(o.HaveOccurred())
if ipv6PrimaryDualStack {
allowed_sourcerange = "2001:db8:2222:5555::/64"
}
testDeployment := createTestDeployment(deploymentOpts{
Name: depName,
Labels: labels,
Replicas: 2,
Protocol: v1.ProtocolUDP,
Port: 8081,
})
deployment, err := clientSet.AppsV1().Deployments(oc.Namespace()).Create(ctx,
testDeployment, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
err = e2edeployment.WaitForDeploymentComplete(clientSet, deployment)
o.Expect(err).NotTo(o.HaveOccurred())
g.By(fmt.Sprintf("Creating Openshift LoadBalancer Service with loadBalancerSourceRanges: '%s'", allowed_sourcerange))
jig := e2eservice.NewTestJig(clientSet, oc.Namespace(), "udp-lb-sourceranges-svc")
jig.Labels = labels
svc, err := jig.CreateLoadBalancerService(ctx, loadBalancerServiceTimeout, func(svc *v1.Service) {
svc.Spec.Ports = []v1.ServicePort{{Protocol: v1.ProtocolUDP, Port: svcPort, TargetPort: intstr.FromInt(8081)}}
svc.Spec.Selector = labels
svc.Spec.LoadBalancerSourceRanges = []string{allowed_sourcerange}
})
o.Expect(err).NotTo(o.HaveOccurred())
g.By("Checks from openshift perspective")
loadBalancerId := svc.GetAnnotations()["loadbalancer.openstack.org/load-balancer-id"]
o.Expect(loadBalancerId).ShouldNot(o.BeEmpty(), "load-balancer-id annotation missing")
e2e.Logf("LB ID: %s", loadBalancerId)
svcIp := svc.Status.LoadBalancer.Ingress[0].IP
o.Expect(svcIp).ShouldNot(o.BeEmpty(), "Ingress IP missing on svc Status")
e2e.Logf("Service IP: %s", svcIp)
g.By("Checks from openstack perspective")
allPages, err := octavialisteners.List(loadBalancerClient, octavialisteners.ListOpts{LoadbalancerID: loadBalancerId}).AllPages(ctx)
o.Expect(err).NotTo(o.HaveOccurred())
listeners, err := octavialisteners.ExtractListeners(allPages)
o.Expect(err).NotTo(o.HaveOccurred())
// Check there is only one listener in the LB
o.Expect(listeners).Should(o.HaveLen(1), "Unexpected number of listeners for LB '%s'", loadBalancerId)
listenerId := listeners[0].ID
e2e.Logf("LB listener ID: %s", listenerId)
// Check allowed_cidrs in the LB listener matches with the svc spec
if lbProviderUnderTest == "amphora" { // it only makes sense with Amphora
o.Expect(listeners[0].AllowedCIDRs).Should(o.ConsistOf([]string{allowed_sourcerange}), "Unexpected allowed_cidrs in Openstack LoadBalancer Listener '%s'", listenerId)
e2e.Logf("Found expected allowed_cidrs '%v' in Openstack LoadBalancer Listener '%s'", listeners[0].AllowedCIDRs, listenerId)
}
// Check there is no connectivity
g.By("Connectivity checks - there should be no connectivity")
var connNumber int = 5
g.By(fmt.Sprintf("Trying to access the service %d times from outside and storing the name of the pods answering", connNumber))
results := make(map[string]int)
for i := 0; i < connNumber; i++ {
// https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/README.md#netexec
podName, err := getPodNameThroughLb(svcIp, fmt.Sprintf("%d", svcPort), v1.ProtocolUDP, "hostname")
if err != nil {
e2e.Logf("No connectivity (as expected) while accessing the LoadBalancer service on try %d: %q", i, err)
} else {
results[podName]++
}
}
e2e.Logf("Pods accessed after '%d' UDP requests: '%v'", connNumber, results)
o.Expect(len(results)).Should(o.Equal(0), "There is connectivity to svc pods when it shouldn't: '%v'", results)
e2e.Logf("No connectivity to the service as expected")
// Remove the LoadBalancerSourceRanges spec from the service
_, err = jig.UpdateService(ctx, func(svc *v1.Service) {
svc.Spec.LoadBalancerSourceRanges = nil
})
o.Expect(err).NotTo(o.HaveOccurred())
e2e.Logf("Removed LoadBalancerSourceRanges spec from the service")
// Wait until allowed_cidrs in the LB listener is updated to 0.0.0.0/0 (all traffic allowed)
if lbProviderUnderTest == "amphora" { // it only makes sense with Amphora
allowAllAllowedCidrs := []string{"0.0.0.0/0"}
e2e.Logf("Expected allowed_cidrs: '%v'", allowAllAllowedCidrs)
o.Eventually(func() []string {
lbListener, err := octavialisteners.Get(ctx, loadBalancerClient, listenerId).Extract()
if err != nil {
e2e.Logf("Error ocurred: %v, trying next iteration", err)
return []string{}
}
e2e.Logf("Found AllowedCIDRs: %v", lbListener.AllowedCIDRs)
return lbListener.AllowedCIDRs
}, "60s", "1s").Should(o.ConsistOf(allowAllAllowedCidrs), "Didn't find the expected allowed_cidrs '%v'", allowAllAllowedCidrs)
e2e.Logf("Found expected allowed_cidrs '%v' in Openstack LoadBalancer Listener '%s'", allowAllAllowedCidrs, listenerId)
} else {
// It should be fast with OVN, but no good way to check it, let's just sleep.
time.Sleep(30 * time.Second)
}
// Wait until ProvisioningStatus in the LB listener is back to ACTIVE after it's been updated
activeProvisioningStatus := "ACTIVE"
e2e.Logf("Expected ProvisioningStatus: '%s'", activeProvisioningStatus)
o.Eventually(func() string {
lbListener, err := octavialisteners.Get(ctx, loadBalancerClient, listenerId).Extract()
if err != nil {
e2e.Logf("Error ocurred: %v, trying next iteration", err)
return ""
}
e2e.Logf("Found ProvisioningStatus: %s", lbListener.ProvisioningStatus)
return lbListener.ProvisioningStatus
}, "30s", "1s").Should(o.Equal(activeProvisioningStatus), "Didn't find the expected ProvisioningStatus '%s'", activeProvisioningStatus)
e2e.Logf("Found expected ProvisioningStatus '%s' in Openstack LoadBalancer Listener '%s'", activeProvisioningStatus, listenerId)
// Check there is still only one listener in the LB and that the Id matches with the previously stored one
allPages, err = octavialisteners.List(loadBalancerClient, octavialisteners.ListOpts{LoadbalancerID: loadBalancerId}).AllPages(ctx)
o.Expect(err).NotTo(o.HaveOccurred())
listeners, err = octavialisteners.ExtractListeners(allPages)
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect(listeners).Should(o.HaveLen(1), "Unexpected number of listeners for LB '%s'", loadBalancerId)
o.Expect(listeners[0].ID).Should((o.Equal(listenerId)), "Listener ID for LB '%s' has changed", loadBalancerId)
// Check connectivity to the service
connNumber = 10
g.By(fmt.Sprintf("accessing the service %d times from outside and storing the name of the pods answering", connNumber))
results = make(map[string]int)
for i := 0; i < connNumber; i++ {
// https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/README.md#netexec
podName, err := getPodNameThroughLb(svcIp, fmt.Sprintf("%d", svcPort), v1.ProtocolUDP, "hostname")
if err != nil {
e2e.Logf("Error detected while accessing the LoadBalancer service on try %d: %q", i, err)
} else {
results[podName]++
}
}
e2e.Logf("Pods accessed after '%d' UDP requests: '%v'", connNumber, results)
var successConnCount int
for podName, connPerPod := range results {
e2e.Logf("Pod '%s' has been accessed '%d' times", podName, connPerPod)
successConnCount += connPerPod
}
// Check the number of successful connections with some margin (80%) to avoid flakes
var connMargin float32 = 0.8
minSuccessConn := int(float32(connNumber) * connMargin)
o.Expect(successConnCount >= minSuccessConn).To(o.BeTrue(), "Found less successful connections (%d) than the minimum expected of '%d'", successConnCount, minSuccessConn)
e2e.Logf("Found expected number of successfull connections: '%d'", connNumber)
})
}
})
// Check ini.File from cloudProviderConfig and skip the tests if lb-provider is not matching the expected value
func skipIfNotLbProvider(expectedLbProvider string, ini *ini.File) {
foundLbProvider, err := getClusterLoadBalancerSetting("lb-provider", ini)
o.Expect(err).NotTo(o.HaveOccurred())
if foundLbProvider != strings.ToLower(expectedLbProvider) {
e2eskipper.Skipf("Test not applicable for LoadBalancer provider different than %s. Cluster is configured with %q", expectedLbProvider, foundLbProvider)
}
}
// get the LoadBalancer setting based on the provided CloudProviderConfig INI file and the default values
func getClusterLoadBalancerSetting(setting string, config *ini.File) (string, error) {
defaultLoadBalancerSettings := map[string]string{
"lb-provider": "amphora",
"lb-method": "round_robin",
"max-shared-lb": "2",
}
result, err := getPropertyValue("LoadBalancer", setting, config)
if err != nil || result == "#UNDEFINED#" {
if _, ok := defaultLoadBalancerSettings[setting]; !ok {
return "", fmt.Errorf("%q setting value not found and default is unknown", setting)
}
result = defaultLoadBalancerSettings[setting]
e2e.Logf("%q is not set on LoadBalancer section in cloud-provider-config, considering default value %q", setting, result)
}
return strings.ToLower(result), nil
}
// Return the FloatingIP assigned to a provided IP and return error if it is not found.
func getFipbyFixedIP(ctx context.Context, client *gophercloud.ServiceClient, vip string) (floatingips.FloatingIP, error) {
var result floatingips.FloatingIP
allPages, err := floatingips.List(client, floatingips.ListOpts{}).AllPages(ctx)
if err != nil {
return result, err
}
allFIP, err := floatingips.ExtractFloatingIPs(allPages)
if err != nil {
return result, err
}
for _, fip := range allFIP {
if fip.FixedIP == vip {
return fip, nil
}
}
return result, fmt.Errorf("FIP not found for VIP %q", vip)
}
func getPodNameThroughLb(ip string, port string, protocol v1.Protocol, message string) (string, error) {
if net.ParseIP(ip) == nil {
return "", fmt.Errorf("invalid ip %q", ip)
}
if isIpv6(ip) {
ip = "[" + ip + "]"
}
if protocol == v1.ProtocolUDP {
// Send message on provided ip and UDP port and return the answer.
// Error if there is no answer or cannot access the port after 5 seconds.
service := ip + ":" + port
RemoteAddr, err := net.ResolveUDPAddr("udp", service)
if err != nil {
return "", err
}
conn, err := net.DialUDP("udp", nil, RemoteAddr)
if err != nil {
return "", err
}
conn.SetDeadline(time.Now().Add(time.Second * 5))
defer conn.Close()
msg := []byte(message)
_, err = conn.Write(msg)
if err != nil {
return "", err
}
// receive message from server
buffer := make([]byte, 1024)
n, _, err := conn.ReadFrom(buffer)
if err != nil {
return "", err
}
return string(buffer[:n]), nil
} else if protocol == v1.ProtocolTCP {
// Send message on top of HTTP GET on provided ip and TCP port and return the answer.
// Error if there is no answer or cannot access the port after 5 seconds.
client := http.Client{
Timeout: 5 * time.Second,
}
defer client.CloseIdleConnections()
req, err := http.NewRequest("GET", "http://"+ip+":"+port+"/"+message, nil)
if err != nil {
return "", err
}
resp, err := client.Do(req)
if err != nil {
return "", err
}
defer resp.Body.Close()
body, err := io.ReadAll(resp.Body)
if err != nil {
return "", err
}
return string(body), nil
} else {
return "", fmt.Errorf("unsupported protocol %q", protocol)
}
}
// Check if the provided lbMethod is applied considering the
// result map (<pod name>: <number of accesses>) and the list of pods provided.
func isLbMethodApplied(lbMethod string, results map[string]int, pods *v1.PodList) bool {
safeguard := 20
// https://github.com/openstack/octavia/blob/master/releasenotes/notes/add-lb-algorithm-source-ip-port-ff86433143e43136.yaml
if lbMethod == "round_robin" || lbMethod == "source_ip_port" {
minAccesses := int(100/len(pods.Items) - safeguard)
for _, pod := range pods.Items {
e2e.Logf("Checking if pod %q has been accessed at least %v number of times...", pod.Name, minAccesses)
val, ok := results[pod.Name]
if !ok || val < minAccesses {
return false
}
}
return true
} else if lbMethod == "source_ip" || lbMethod == "least_connections" {
minAccesses := 100 - safeguard
for _, pod := range pods.Items {
val, ok := results[pod.Name]
if ok && val > minAccesses && len(results) == 1 {
e2e.Logf("%q algorithm successfully applied - Unique pod %q has been accessed %d times.", lbMethod, pod.Name, val)
return true
}
}
return false
} else {
e2e.Logf("LB-Method check not implemented for %q", lbMethod)
return true
}
}
// getSubnet checks if a Subnet is present in the list of Subnets the tenant has access to and returns it
func getSubnet(networkSubnet string, subnetList []subnets.Subnet) *subnets.Subnet {
for _, subnet := range subnetList {
if subnet.ID == networkSubnet {
return &subnet
}
}
return nil
}
// Active wait (up to 3 minutes) until a certain number of members match a regex on status attribute.
func waitUntilNmembersReady(ctx context.Context, client *gophercloud.ServiceClient, pool *pools.Pool, n int, status string) error {
var resultingMembers []string
var err error
e2e.Logf("Waiting for %d members matching status %s in the pool %s", n, status, pool.Name)
err = wait.Poll(15*time.Second, 3*time.Minute, func() (bool, error) {
resultingMembers, err = getMembersMatchingStatus(ctx, client, pool, status)
if err != nil {
return false, err
}
if len(resultingMembers) == int(n) {
e2e.Logf("Found expected number of %s members, checking again 5 seconds later to confirm that it is stable", status)
time.Sleep(5 * time.Second)
resultingMembers, err = getMembersMatchingStatus(ctx, client, pool, status)
if err != nil {
return false, err
} else if len(resultingMembers) == int(n) {
e2e.Logf("Wait completed, %s members found: %q", status, resultingMembers)
return true, nil
}
}
e2e.Logf("Waiting for next iteration, %s members found: %q", status, resultingMembers)
return false, nil
})
if err != nil && strings.Contains(err.Error(), "timed out waiting for the condition") {
resultingMembers, err = getMembersMatchingStatus(ctx, client, pool, status)
allMembers, err := pools.ListMembers(client, pool.ID, pools.ListMembersOpts{}).AllPages(ctx)
if err != nil {
return err
}
return fmt.Errorf("expected %d members matching %s status, got %d. All members: %+v", n, status, len(resultingMembers), allMembers)
}
return err
}
// Return the name of the members matching a regex in the OperatingStatus attribute
func getMembersMatchingStatus(ctx context.Context, client *gophercloud.ServiceClient, pool *pools.Pool, status string) ([]string, error) {
var members []string
for _, aux := range pool.Members {
member, err := pools.GetMember(ctx, client, pool.ID, aux.ID).Extract()
if err != nil {
return nil, err
}
result, err := regexp.MatchString(status, member.OperatingStatus)
if err != nil {
return nil, err
} else if result {
members = append(members, member.Name)
}