Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default instance parameter values are shown to project viewers as if they were real #2331

Closed
spadgett opened this issue Oct 20, 2017 · 1 comment
Closed

Default instance parameter values are shown to project viewers as if they were real #2331

spadgett opened this issue Oct 20, 2017 · 1 comment
Assignees
@jeff-phillips-18
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

If you log into a project with a provisioned service as a viewer, the "reveal" parameters link is visible. Since you can't get secrets, you can't see the actual values. However, we show the default values in the list as if they were the actual values. We shouldn't show defaults for users who can't get secrets.

Related to #2317, but opening a separate bug to make sure we address this specifically.
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P1 labels Oct 20, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 20, 2017
@jeff-phillips-18
Copy link
Member

Fixed by #2355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@spadgett @jeff-phillips-18