New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a nil check to Container.SecurityContext #12446
Add a nil check to Container.SecurityContext #12446
Conversation
We were panicing sometimes when we dereferenced a nil pointer when looking at the Container.SecurityContext which is defined as optional. This fix adds a check to see if it is not nil before dereferencing. Fixes bug 1412087 (https://bugzilla.redhat.com/show_bug.cgi?id=1412087)
[merge] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test case?
Evaluated for origin merge up to 6255e65 |
[Test]ing while waiting on the merge queue |
LGTM |
[test] last flake was upstream flake kubernetes/kubernetes#36564 |
Evaluated for origin test up to 6255e65 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12759/) (Base Commit: 6468143) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12778/) (Base Commit: fc73b80) (Image: devenv-rhel7_5661) |
We were panicing sometimes when we dereferenced a nil pointer when
looking at the Container.SecurityContext which is defined as optional.
This fix adds a check to see if it is not nil before dereferencing.
Fixes bug 1412087 (https://bugzilla.redhat.com/show_bug.cgi?id=1412087)