Correct the way that haproxy uses the secure cookie attribute #12802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the only time that we dont want a cookie flagged as secure is when the InsecureEdgePolicy is set to Allow, currently that is not the case This patch changes the conditional and flags cookies as secure appropriately
|
@openshift/networking |
|
[test] |
|
Evaluated for origin test up to ddb865e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13575/) (Base Commit: 5565661) |
|
Looks good! LGTM |
|
@ramr PTAL |
|
[merge] |
|
Evaluated for origin merge up to ddb865e |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13625/) (Base Commit: e92d661) (Image: devenv-rhel7_5861) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the only time that we dont want a cookie flagged as secure is when the
InsecureEdgePolicy is set to Allow, currently that is not the case
This patch changes the conditional and flags cookies as secure appropriately
Bug 1412591 Link