Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that IP addrs are IPv4 where we only support IPv4 #16660

Closed
danwinship opened this issue Oct 3, 2017 · 1 comment
Closed

Validate that IP addrs are IPv4 where we only support IPv4 #16660

danwinship opened this issue Oct 3, 2017 · 1 comment
Assignees
@pravisankar
Labels
component/networking kind/bug Categorizes issue or PR as related to a bug. priority/P2 sig/networking

Comments

@danwinship
Copy link
Contributor

Several networking API objects contain IP addresses or CIDR ranges, where their validation functions check that they are IPs/CIDRs, but we don't check that they're IPv4, even though that's all we support (and the code may potentially do broken things if you put an IPv6 address there).
@danwinship danwinship mentioned this issue Oct 3, 2017
Merged
@pweil- pweil- added the kind/bug Categorizes issue or PR as related to a bug. label Oct 3, 2017
@pravisankar pravisankar assigned pravisankar and unassigned knobunc Oct 4, 2017
@pravisankar pravisankar mentioned this issue Oct 13, 2017
Merged
@pravisankar
Copy link

Fixed by #16807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pravisankar pravisankar

Labels
component/networking kind/bug Categorizes issue or PR as related to a bug. priority/P2 sig/networking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danwinship @pravisankar @pweil- @knobunc