Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 54763: increase iptables max wait from 2 seconds to 5 seconds #17062

Merged
merged 1 commit into from Oct 31, 2017
Merged

UPSTREAM: 54763: increase iptables max wait from 2 seconds to 5 seconds #17062

merged 1 commit into from Oct 31, 2017

Conversation

rajatchopra
Copy link
Contributor

@rajatchopra rajatchopra commented Oct 26, 2017 •
edited by knobunc

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 26, 2017
@eparis
Copy link
Member

eparis commented Oct 26, 2017

/retest

1 similar comment
@eparis
Copy link
Member

eparis commented Oct 27, 2017

/retest

@eparis
Copy link
Member

eparis commented Oct 27, 2017 

iptables_test.go:612: For 1.4.22 expected -w2 got [-w5]
iptables_test.go:612: For 1.5.0 expected -w2 got [-w5]
iptables_test.go:612: For 2.0.0 expected -w2 got [-w5]

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2017
knobunc
knobunc approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks Rajat

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2017
@eparis
Copy link
Member

eparis commented Oct 27, 2017

/approve
/retest

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2017
pravisankar
pravisankar approved these changes Oct 27, 2017
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@eparis
Copy link
Member

eparis commented Oct 29, 2017

CI is going to fail until the upstream PR is referenced.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2017
@imcsk8
Copy link
Contributor

imcsk8 commented Oct 30, 2017

LGTM

@rajatchopra rajatchopra changed the title UPSTREAM: increase iptables max wait from 2 seconds to 5 seconds UPSTREAM: 54763: increase iptables max wait from 2 seconds to 5 seconds Oct 30, 2017
@rajatchopra
Copy link
Contributor Author

rajatchopra commented Oct 30, 2017 •
edited

/test extended_conformance_gce

@knobunc
Copy link
Contributor

knobunc commented Oct 30, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, knobunc, rajatchopra

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@knobunc
Copy link
Contributor

knobunc commented Oct 30, 2017

/retest

1 similar comment
@knobunc
Copy link
Contributor

knobunc commented Oct 30, 2017

/retest

@pravisankar
Copy link

/test extended_conformance_gce

@knobunc
Copy link
Contributor

knobunc commented Oct 31, 2017

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2017
@knobunc
Copy link
Contributor

knobunc commented Oct 31, 2017

/retest

2 similar comments
@pravisankar
Copy link

/retest

@eparis
Copy link
Member

eparis commented Oct 31, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17105, 17036, 17062, 17093).

@openshift-merge-robot openshift-merge-robot merged commit a324f1a into openshift:master Oct 31, 2017
@openshift-ci-robot
Copy link

@rajatchopra: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 5225530 link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update 5225530 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar pravisankar approved these changes

@knobunc knobunc knobunc approved these changes

Assignees

@eparis eparis

@knobunc knobunc

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rajatchopra @eparis @openshift-bot @imcsk8 @knobunc @openshift-merge-robot @pravisankar @openshift-ci-robot @dcbw