Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore registry tests as registry moved to external repo #17958

Closed
soltysh opened this issue Jan 2, 2018 · 5 comments
Closed

Restore registry tests as registry moved to external repo #17958

soltysh opened this issue Jan 2, 2018 · 5 comments

Comments

@soltysh
Copy link
Member

soltysh commented Jan 2, 2018

As part of the 1.8 rebase (4e13893 specifically) removed registry from origin's repository to an external one -> https://github.com/openshift/image-registry.
The problem with that is that some tests where removed along the way, we need to investigate and bring those missing ones back.

@bparees
Copy link
Contributor

bparees commented Jan 2, 2018

@soltysh are you saying we need to enable tests in the origin repo, or in the image-registry repo?

I'm pretty sure @dmage already re-enabled all tests in the image-registry repo, but i'll let him assess this.

@soltysh
Copy link
Member Author

soltysh commented Jan 2, 2018

@bparees iirc the idea was to have some of those tests in origin, at least the ones that can and should exist there. @mfojtik might remember the details, as he was the one stripping that part out 😉

@dmage
Copy link
Member

dmage commented Jan 3, 2018

@dmage
Copy link
Member

dmage commented Jan 4, 2018

openshift/image-registry#38
openshift/image-registry#39

Feel free to create new issues if you find other tests.

@dmage dmage closed this as completed Jan 4, 2018
@soltysh
Copy link
Member Author

soltysh commented Jan 5, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants